[PR #14] [MERGED] fix: update coverage command in Makefile and add .nyc_output to .gitignore #51

New issue

Closed

opened 2026-05-06 16:07:19 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 16:07:19 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BreizhHardware/express-prom-bundle/pull/14
Author: @BreizhHardware
Created: 11/18/2025
Status: ✅ Merged
Merged: 11/18/2025
Merged by: @BreizhHardware

Base: main ← Head: hotfix/coverage

📝 Commits (1)

eb1a8f0 fix: update coverage command in Makefile and add .nyc_output to .gitignore

📊 Changes

2 files changed (+3 additions, -9 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 Makefile (+2 -9)

📄 Description

This pull request updates the code coverage and reporting tools in the Makefile to use more modern and streamlined commands. The main improvements are the replacement of deprecated or manual tool invocations with npx-based equivalents, simplifying the process and improving compatibility.

Coverage tooling updates:

Replaced manual istanbul invocation in the coverage target with npx nyc, and updated the command to generate both lcov and text reports. (Makefile)
Simplified the coveralls target by removing the need for the COVERALLS_REPO_TOKEN environment check and using npx nyc report piped directly to npx coveralls. (Makefile)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BreizhHardware/express-prom-bundle/pull/14 **Author:** [@BreizhHardware](https://github.com/BreizhHardware) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 11/18/2025 **Merged by:** [@BreizhHardware](https://github.com/BreizhHardware) **Base:** `main` ← **Head:** `hotfix/coverage` --- ### 📝 Commits (1) - [`eb1a8f0`](https://github.com/BreizhHardware/express-prom-bundle/commit/eb1a8f08ab36b56133c8db14e748796cdcc70ef7) fix: update coverage command in Makefile and add .nyc_output to .gitignore ### 📊 Changes **2 files changed** (+3 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `Makefile` (+2 -9) </details> ### 📄 Description This pull request updates the code coverage and reporting tools in the `Makefile` to use more modern and streamlined commands. The main improvements are the replacement of deprecated or manual tool invocations with `npx`-based equivalents, simplifying the process and improving compatibility. **Coverage tooling updates:** * Replaced manual `istanbul` invocation in the `coverage` target with `npx nyc`, and updated the command to generate both `lcov` and text reports. (`Makefile`) * Simplified the `coveralls` target by removing the need for the `COVERALLS_REPO_TOKEN` environment check and using `npx nyc report` piped directly to `npx coveralls`. (`Makefile`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>