[PR #42] [MERGED] Dev felix #41

New issue

Closed

opened 2026-05-06 12:17:29 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:17:29 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BreizhHardware/project_sanic/pull/42
Author: @BreizhHardware
Created: 4/10/2025
Status: ✅ Merged
Merged: 4/10/2025
Merged by: @BreizhHardware

Base: dev ← Head: dev_felix

📝 Commits (3)

722719e Feat(Cinematic) - Enhance cinematic playback by allowing multiple levels; refactor play_cinematic method to track played cinematics and improve text display functionality.
178074a Fix(.gitignore) - Add pycache directory to ignore list; ensure Python cache files are excluded from version control.
d617e82 Update src/Map/cinematic.py

📊 Changes

3 files changed (+97 additions, -51 deletions)

View changed files

📝 .gitignore (+2 -1)
📝 src/Map/cinematic.py (+94 -47)
📝 src/Map/parser.py (+1 -3)

📄 Description

This pull request includes significant changes to the handling of cinematics in the game. The primary updates involve refactoring the cinematic playback logic to support multiple levels and improving the cinematic display with gradient backgrounds and text animations.

Improvements to cinematic handling and display:

src/Map/cinematic.py: Replaced the has_played_level1 class variable with a played_cinematics dictionary to track the playback status of multiple levels.
src/Map/cinematic.py: Refactored the play_cinematic method to handle cinematics for multiple levels by introducing _create_gradient_background and _display_cinematic_text helper methods. [1] [2]

Code cleanup:

src/Map/parser.py: Removed the cinematic_played instance variable and updated the load_map method to play cinematics for all levels instead of just Level 1. [1] [2]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BreizhHardware/project_sanic/pull/42 **Author:** [@BreizhHardware](https://github.com/BreizhHardware) **Created:** 4/10/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@BreizhHardware](https://github.com/BreizhHardware) **Base:** `dev` ← **Head:** `dev_felix` --- ### 📝 Commits (3) - [`722719e`](https://github.com/BreizhHardware/project_sanic/commit/722719e8aff924d1dd894ff7a08086857cff8313) Feat(Cinematic) - Enhance cinematic playback by allowing multiple levels; refactor play_cinematic method to track played cinematics and improve text display functionality. - [`178074a`](https://github.com/BreizhHardware/project_sanic/commit/178074ae560641696c6029f1e860459ba514e6d8) Fix(.gitignore) - Add __pycache__ directory to ignore list; ensure Python cache files are excluded from version control. - [`d617e82`](https://github.com/BreizhHardware/project_sanic/commit/d617e82ef8429d595bbd147e7c27ec563d37fc5d) Update src/Map/cinematic.py ### 📊 Changes **3 files changed** (+97 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) 📝 `src/Map/cinematic.py` (+94 -47) 📝 `src/Map/parser.py` (+1 -3) </details> ### 📄 Description This pull request includes significant changes to the handling of cinematics in the game. The primary updates involve refactoring the cinematic playback logic to support multiple levels and improving the cinematic display with gradient backgrounds and text animations. Improvements to cinematic handling and display: * [`src/Map/cinematic.py`](diffhunk://#diff-cede1a3685f18163d83ec5e14cbc6e74343f9b20f61a8904fd375bad3c711c7aL8-R9): Replaced the `has_played_level1` class variable with a `played_cinematics` dictionary to track the playback status of multiple levels. * [`src/Map/cinematic.py`](diffhunk://#diff-cede1a3685f18163d83ec5e14cbc6e74343f9b20f61a8904fd375bad3c711c7aL31-R75): Refactored the `play_cinematic` method to handle cinematics for multiple levels by introducing `_create_gradient_background` and `_display_cinematic_text` helper methods. [[1]](diffhunk://#diff-cede1a3685f18163d83ec5e14cbc6e74343f9b20f61a8904fd375bad3c711c7aL31-R75) [[2]](diffhunk://#diff-cede1a3685f18163d83ec5e14cbc6e74343f9b20f61a8904fd375bad3c711c7aL89-R136) Code cleanup: * [`src/Map/parser.py`](diffhunk://#diff-b7d012db5b4cdd07e07d6f78dda95be51706a586fd88f44d2e2d0e9ffa228fafL39): Removed the `cinematic_played` instance variable and updated the `load_map` method to play cinematics for all levels instead of just Level 1. [[1]](diffhunk://#diff-b7d012db5b4cdd07e07d6f78dda95be51706a586fd88f44d2e2d0e9ffa228fafL39) [[2]](diffhunk://#diff-b7d012db5b4cdd07e07d6f78dda95be51706a586fd88f44d2e2d0e9ffa228fafL48-L50) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>