starred/Termix
1
0
Fork 0
mirror of https://github.com/Termix-SSH/Termix.git synced 2026-05-09 00:08:19 +02:00
Code Issues 1 Projects Packages Wiki Activity

[PR #424] [MERGED] Handle OIDC users during database import #221

New issue
Closed
opened 2026-05-06 12:37:32 +02:00 by BreizhHardware · 0 comments
BreizhHardware commented 2026-05-06 12:37:32 +02:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Termix-SSH/Termix/pull/424
Author: @nikolanovoselec
Created: 10/21/2025
Status: ✅ Merged
Merged: 10/21/2025
Merged by: @LukeGus

Base: dev-1.8.0 ← Head: feature/oidc-import

📝 Commits (10+)

  • 513a888 Update Docker image name for GitHub registry
  • 2450ae7 Fix image name casing in Docker workflow
  • 8c867d3 Remove untagged image cleanup step from workflow
  • 9dd7992 Change Docker login to use GHCR credentials
  • 300e0a2 Remove cache moving step from Docker workflow
  • ad1864f Refactor Docker image workflow for versioning and builds
  • 40ac75d Update docker-image.yml
  • 773e22f Allow OIDC users to import database without password
  • 153000d Skip import password prompt for OIDC users
  • 6f1b92b docs: clarify OIDC import unlocking flow

📊 Changes

2 files changed (+81 additions, -14 deletions)

View changed files

📝 src/backend/database/database.ts (+39 -10)
📝 src/ui/Desktop/Admin/AdminSettings.tsx (+42 -4)

📄 Description

Summary

  • let the SQLite import API detect OIDC-only accounts and unlock their data key via authenticateOIDCUser while keeping the password flow for local users
  • update the admin UI to hide the password prompt for OIDC sessions and only send the password field when a local account performs the import
  • document the new control flow in both backend and frontend code so future maintainers understand the split paths

Testing

  • docker build -f docker/Dockerfile -t termix-oidc-test .

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Termix-SSH/Termix/pull/424 **Author:** [@nikolanovoselec](https://github.com/nikolanovoselec) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/21/2025 **Merged by:** [@LukeGus](https://github.com/LukeGus) **Base:** `dev-1.8.0` ← **Head:** `feature/oidc-import` --- ### 📝 Commits (10+) - [`513a888`](https://github.com/Termix-SSH/Termix/commit/513a88826d33dd9126ee6b58fea305223bcbe94c) Update Docker image name for GitHub registry - [`2450ae7`](https://github.com/Termix-SSH/Termix/commit/2450ae732ecfdef2feb73e3ec9f0d5797e8f1cc5) Fix image name casing in Docker workflow - [`8c867d3`](https://github.com/Termix-SSH/Termix/commit/8c867d3b16f2ac827a9de911f121075a1de72925) Remove untagged image cleanup step from workflow - [`9dd7992`](https://github.com/Termix-SSH/Termix/commit/9dd79929e88df81ce4af392ce84fa38d235d463c) Change Docker login to use GHCR credentials - [`300e0a2`](https://github.com/Termix-SSH/Termix/commit/300e0a263f89c9590e957d724d63f04d86b56399) Remove cache moving step from Docker workflow - [`ad1864f`](https://github.com/Termix-SSH/Termix/commit/ad1864f062e57651b04bd332827cad4d706a0071) Refactor Docker image workflow for versioning and builds - [`40ac75d`](https://github.com/Termix-SSH/Termix/commit/40ac75de813abcf31e04390d72c762a1597826d4) Update docker-image.yml - [`773e22f`](https://github.com/Termix-SSH/Termix/commit/773e22fa3d1f8de525ca2652c717259f57ffdb3a) Allow OIDC users to import database without password - [`153000d`](https://github.com/Termix-SSH/Termix/commit/153000d3ff7b7569d8b9fe693011922be369a48e) Skip import password prompt for OIDC users - [`6f1b92b`](https://github.com/Termix-SSH/Termix/commit/6f1b92b07b6e3426d78011e919c4d5d010ffcffd) docs: clarify OIDC import unlocking flow ### 📊 Changes **2 files changed** (+81 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/backend/database/database.ts` (+39 -10) 📝 `src/ui/Desktop/Admin/AdminSettings.tsx` (+42 -4) </details> ### 📄 Description ## Summary - let the SQLite import API detect OIDC-only accounts and unlock their data key via authenticateOIDCUser while keeping the password flow for local users - update the admin UI to hide the password prompt for OIDC sessions and only send the password field when a local account performs the import - document the new control flow in both backend and frontend code so future maintainers understand the split paths ## Testing - docker build -f docker/Dockerfile -t termix-oidc-test . --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:37:32 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
dependabot/docker/docker/node-26-slim
release-1.11.2-tag
release-1.11.1-tag
release-1.11.0-tag
release-1.10.0-tag
release-1.6.0-tag
release-1.5.0-tag
release-1.4.0-tag
release-1.3.1-tag
release-0.2.0-tag
release-0.3.0-tag
release-1.3.0-tag
release-1.2.0-tag
release-0.1.0-tag
release-1.0.1-tag
release-1.1.0-tag
release-1.0.0-tag
release-1.1.1-tag
release-1.01-tag
release-0.2.1-tag
release-0.1.1-tag
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Termix#221
No description provided.