[PR #47] [MERGED] [mpy/kandinsky] Fix draw_string() on new line + good colors #218

New issue

Closed

opened 2026-05-06 13:16:18 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:16:18 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/47
Author: @ArtichOwO
Created: 10/11/2021
Status: ✅ Merged
Merged: 10/11/2021
Merged by: @Lauryy06

Base: upsilon-dev ← Head: fix-draw-string-mpy

📝 Commits (2)

9169a9e [mpy/kandinsky] Use good colors
0a7b3ac [kandinsky/context_text] Avoid returning to pos x=0 on new line, use arg's x coordinate instead

📊 Changes

2 files changed (+3 additions, -4 deletions)

View changed files

📝 kandinsky/src/context_text.cpp (+1 -1)
📝 python/port/mod/kandinsky/modkandinsky.cpp (+2 -3)

📄 Description

Uses Palette instead of b/w constants, also doesn't returns to 0 (x coordinate)

Screenshots

With draw_string("hey\nho\nmatelos", 11, 32):

Before:

Now: (correct colors!)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/47 **Author:** [@ArtichOwO](https://github.com/ArtichOwO) **Created:** 10/11/2021 **Status:** ✅ Merged **Merged:** 10/11/2021 **Merged by:** [@Lauryy06](https://github.com/Lauryy06) **Base:** `upsilon-dev` ← **Head:** `fix-draw-string-mpy` --- ### 📝 Commits (2) - [`9169a9e`](https://github.com/UpsilonNumworks/Upsilon/commit/9169a9e9049fab39fe61d6601bbd1d5e9be322cf) [mpy/kandinsky] Use good colors - [`0a7b3ac`](https://github.com/UpsilonNumworks/Upsilon/commit/0a7b3ac2debe2b6bbff358970dc32bbceebe17e2) [kandinsky/context_text] Avoid returning to pos x=0 on new line, use arg's x coordinate instead ### 📊 Changes **2 files changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `kandinsky/src/context_text.cpp` (+1 -1) 📝 `python/port/mod/kandinsky/modkandinsky.cpp` (+2 -3) </details> ### 📄 Description Uses `Palette` instead of b/w constants, also doesn't returns to 0 (x coordinate) <details> <summary>Screenshots</summary> With `draw_string("hey\nho\nmatelos", 11, 32)`: ### Before: <img width="382" alt="Capture d’écran 2021-10-11 à 18 45 40" src="https://user-images.githubusercontent.com/63865385/136835379-b2286731-3b07-4330-824a-6b617c5c3a71.png"> ### Now: (correct colors!) <img width="381" alt="Capture d’écran 2021-10-11 à 20 06 44" src="https://user-images.githubusercontent.com/63865385/136835427-fc85f155-ba56-4224-b40a-47ec179a1895.png"> </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>