[PR #51] [MERGED] Replace hard-coded color values with Palette colors and use the correct colors #222

New issue

Closed

opened 2026-05-06 13:16:20 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:16:20 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/51
Author: @lolocomotive
Created: 10/16/2021
Status: ✅ Merged
Merged: 10/20/2021
Merged by: @Lauryy06

Base: upsilon-dev ← Head: patch-2

📝 Commits (1)

de794d5 Replace hard-coded color values with Palette colors and use the correct palette colors

📊 Changes

4 files changed (+7 additions, -7 deletions)

View changed files

📝 apps/calculation/history_view_cell.cpp (+1 -1)
📝 apps/code/script_node_cell.cpp (+2 -2)
📝 apps/math_variable_box_empty_controller.cpp (+1 -1)
📝 apps/shared/scrollable_multiple_expressions_view.cpp (+3 -3)

📄 Description

Some colors are hard coded, such as in the empty variable box (math) or the functions box in the python console.
Some colors were not the right colors, such as the background of the selected expression in the calculation history which also was inconsistent (For the expressions on the left it used ListCellBackgroundSelected and for the expressions on the right it used ExpressionInputBackground whereas it should use Select on both, what is the case in Numworks/Epsilon)
This unfortunately changes the look of certain themes but it makes more sense and leads to less confusion when making new themes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/51 **Author:** [@lolocomotive](https://github.com/lolocomotive) **Created:** 10/16/2021 **Status:** ✅ Merged **Merged:** 10/20/2021 **Merged by:** [@Lauryy06](https://github.com/Lauryy06) **Base:** `upsilon-dev` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`de794d5`](https://github.com/UpsilonNumworks/Upsilon/commit/de794d5416c09f038fc3aed82e1dc15b307029e4) Replace hard-coded color values with Palette colors and use the correct palette colors ### 📊 Changes **4 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `apps/calculation/history_view_cell.cpp` (+1 -1) 📝 `apps/code/script_node_cell.cpp` (+2 -2) 📝 `apps/math_variable_box_empty_controller.cpp` (+1 -1) 📝 `apps/shared/scrollable_multiple_expressions_view.cpp` (+3 -3) </details> ### 📄 Description Some colors are hard coded, such as in the empty variable box (math) or the functions box in the python console. Some colors were not the right colors, such as the background of the selected expression in the calculation history which also was inconsistent (For the expressions on the left it used `ListCellBackgroundSelected` and for the expressions on the right it used `ExpressionInputBackground` whereas it should use `Select` on both, what is the case in Numworks/Epsilon) This unfortunately changes the look of certain themes but it makes more sense and leads to less confusion when making new themes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>