[PR #134] [MERGED] [apps/settings] Fix assert in about submenu when username enabled #278

New issue

Closed

opened 2026-05-06 13:16:36 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:16:36 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/134
Author: @Yaya-Cout
Created: 1/25/2022
Status: ✅ Merged
Merged: 1/25/2022
Merged by: @Lauryy06

Base: upsilon-dev ← Head: upsilon-dev-about-assert-fix

📝 Commits (3)

071f433 [apps/settings] Fix assert in about submenu when username enabled
d47282b Remove some broken thinks
5243682 Fix number of cells

📊 Changes

2 files changed (+1 additions, -2 deletions)

View changed files

📝 apps/settings/sub_menu/about_controller.cpp (+0 -1)
📝 apps/settings/sub_menu/about_controller.h (+1 -1)

📄 Description

When we go in end of about submenu of settings in debug mode, the simulator crash because of the total number of cells, this pull request fixes that and fix also the same bug with username enabled (there are 2 cells more than k_totalNumberOfCell)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/134 **Author:** [@Yaya-Cout](https://github.com/Yaya-Cout) **Created:** 1/25/2022 **Status:** ✅ Merged **Merged:** 1/25/2022 **Merged by:** [@Lauryy06](https://github.com/Lauryy06) **Base:** `upsilon-dev` ← **Head:** `upsilon-dev-about-assert-fix` --- ### 📝 Commits (3) - [`071f433`](https://github.com/UpsilonNumworks/Upsilon/commit/071f4331e8acea012a7f6f2fab3be0bce3b27cfe) [apps/settings] Fix assert in about submenu when username enabled - [`d47282b`](https://github.com/UpsilonNumworks/Upsilon/commit/d47282b031b56cc1325f8ef0bc2f7bfc276f86ef) Remove some broken thinks - [`5243682`](https://github.com/UpsilonNumworks/Upsilon/commit/52436824e4c785f82a91adec28942de39c1a86a2) Fix number of cells ### 📊 Changes **2 files changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/settings/sub_menu/about_controller.cpp` (+0 -1) 📝 `apps/settings/sub_menu/about_controller.h` (+1 -1) </details> ### 📄 Description When we go in end of about submenu of settings in debug mode, the simulator crash because of the total number of cells, this pull request fixes that and fix also the same bug with username enabled (there are 2 cells more than `k_totalNumberOfCell`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>