[PR #133] [MERGED] Fix CI and replacement character #279

New issue

Closed

opened 2026-05-06 13:16:36 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:16:36 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/133
Author: @Yaya-Cout
Created: 1/24/2022
Status: ✅ Merged
Merged: 1/24/2022
Merged by: @Lauryy06

Base: upsilon-dev ← Head: upsilon-dev-ci-fix

📝 Commits (1)

78867c3 Fix CI and replacement character

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 ion/test/events.cpp (+1 -1)
📝 kandinsky/include/kandinsky/font.h (+1 -1)
📝 kandinsky/src/font.cpp (+1 -1)

📄 Description

This pull request fixes the CI and the replacement character. The CI crashed because e575ffc7ce changed the behavior of shift + OK : this is no longer returning OK as event. The replacement character was ≤ instead of � that made of an assert crash when a character wasn't supported. This pull request fixes that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/133 **Author:** [@Yaya-Cout](https://github.com/Yaya-Cout) **Created:** 1/24/2022 **Status:** ✅ Merged **Merged:** 1/24/2022 **Merged by:** [@Lauryy06](https://github.com/Lauryy06) **Base:** `upsilon-dev` ← **Head:** `upsilon-dev-ci-fix` --- ### 📝 Commits (1) - [`78867c3`](https://github.com/UpsilonNumworks/Upsilon/commit/78867c3bc218c37bd225e9b76018b2b62a73188e) Fix CI and replacement character ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ion/test/events.cpp` (+1 -1) 📝 `kandinsky/include/kandinsky/font.h` (+1 -1) 📝 `kandinsky/src/font.cpp` (+1 -1) </details> ### 📄 Description This pull request fixes the CI and the replacement character. The CI crashed because e575ffc7ce3ce0b5c3091546cf0eab2d73ecec07 changed the behavior of shift + OK : this is no longer returning OK as event. The replacement character was `≤` instead of `�` that made of an assert crash when a character wasn't supported. This pull request fixes that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>