[PR #137] [MERGED] [Feature] Backlight settings #283

New issue

Closed

opened 2026-05-06 13:16:38 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:16:38 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/137
Author: @Yaya-Cout
Created: 1/30/2022
Status: ✅ Merged
Merged: 3/22/2022
Merged by: @Yaya-Cout

Base: upsilon-dev ← Head: upsilon-dev-backlight-settings

📝 Commits (10+)

f32d8c4 Added backlight settings
7c66b3d Changed location of the brightness setting
a95cabb Merge branch 'patch-16' into upsilon-dev-backlight-settings
0b7b374 Fix row size of brightness settings
1b9a803 [apps/settings/brightness] Update translations
2c839f7 Fix dimmer
a19cd72 Update translations
d68d8d2 Merge branch 'Lauryy06:upsilon-dev' into upsilon-dev-backlight-settings
5488483 [apps/settings] Add dimmer duration setting
b5a3f88 Merge branch 'upsilon-dev-backlight-settings' of https://github.com/Yaya-Cout/Upsilon into upsilon-dev-backlight-settings

📊 Changes

26 files changed (+288 additions, -80 deletions)

View changed files

📝 apps/apps_container.cpp (+4 -1)
📝 apps/backlight_dimming_timer.cpp (+15 -28)
📝 apps/backlight_dimming_timer.h (+0 -11)
📝 apps/global_preferences.cpp (+20 -1)
📝 apps/global_preferences.h (+12 -0)
📝 apps/settings/Makefile (+1 -0)
📝 apps/settings/base.de.i18n (+5 -0)
📝 apps/settings/base.en.i18n (+5 -0)
📝 apps/settings/base.es.i18n (+5 -0)
📝 apps/settings/base.fr.i18n (+5 -0)
📝 apps/settings/base.hu.i18n (+5 -0)
📝 apps/settings/base.it.i18n (+5 -0)
📝 apps/settings/base.nl.i18n (+5 -0)
📝 apps/settings/base.pt.i18n (+5 -0)
📝 apps/settings/main_controller.cpp (+7 -28)
📝 apps/settings/main_controller.h (+4 -2)
📝 apps/settings/main_controller_prompt_beta.cpp (+1 -1)
📝 apps/settings/main_controller_prompt_none.cpp (+1 -1)
📝 apps/settings/main_controller_prompt_update.cpp (+2 -2)
➕ apps/settings/sub_menu/brightness_controller.cpp (+142 -0)

...and 6 more files

📄 Description

This pull request adds backlight settings, based on Omega-Numworks#276.
To do:

Add and improve translations.
Fix dimmer
Add a setting for dimer duration
Check if brightness dimmed is inferior to the normal brightness
Fix the brightness slider with key bindings

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/137 **Author:** [@Yaya-Cout](https://github.com/Yaya-Cout) **Created:** 1/30/2022 **Status:** ✅ Merged **Merged:** 3/22/2022 **Merged by:** [@Yaya-Cout](https://github.com/Yaya-Cout) **Base:** `upsilon-dev` ← **Head:** `upsilon-dev-backlight-settings` --- ### 📝 Commits (10+) - [`f32d8c4`](https://github.com/UpsilonNumworks/Upsilon/commit/f32d8c4ff83984260ca190cf77e22c82223e0f62) Added backlight settings - [`7c66b3d`](https://github.com/UpsilonNumworks/Upsilon/commit/7c66b3d40b7f0dfeb3f8ad6d9cb83c062b25a4bc) Changed location of the brightness setting - [`a95cabb`](https://github.com/UpsilonNumworks/Upsilon/commit/a95cabba39a849b5ba89a913b9b7c09ad8e2164f) Merge branch 'patch-16' into upsilon-dev-backlight-settings - [`0b7b374`](https://github.com/UpsilonNumworks/Upsilon/commit/0b7b374a719af5312adc5b3683701a545db249c0) Fix row size of brightness settings - [`1b9a803`](https://github.com/UpsilonNumworks/Upsilon/commit/1b9a8036ddf766c1f48f584e55329bbee6ceaad0) [apps/settings/brightness] Update translations - [`2c839f7`](https://github.com/UpsilonNumworks/Upsilon/commit/2c839f79716d9909643d4c6a194df17afe6569f8) Fix dimmer - [`a19cd72`](https://github.com/UpsilonNumworks/Upsilon/commit/a19cd72635b8cd4dbd938558546c628f3e19def9) Update translations - [`d68d8d2`](https://github.com/UpsilonNumworks/Upsilon/commit/d68d8d2ee34f2c759cc568ed85cbf7b9aa88057e) Merge branch 'Lauryy06:upsilon-dev' into upsilon-dev-backlight-settings - [`5488483`](https://github.com/UpsilonNumworks/Upsilon/commit/54884833194423d2c0fc50936ea2de1301215e23) [apps/settings] Add dimmer duration setting - [`b5a3f88`](https://github.com/UpsilonNumworks/Upsilon/commit/b5a3f8899c41497c070171706c19cbab3a70cb05) Merge branch 'upsilon-dev-backlight-settings' of https://github.com/Yaya-Cout/Upsilon into upsilon-dev-backlight-settings ### 📊 Changes **26 files changed** (+288 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `apps/apps_container.cpp` (+4 -1) 📝 `apps/backlight_dimming_timer.cpp` (+15 -28) 📝 `apps/backlight_dimming_timer.h` (+0 -11) 📝 `apps/global_preferences.cpp` (+20 -1) 📝 `apps/global_preferences.h` (+12 -0) 📝 `apps/settings/Makefile` (+1 -0) 📝 `apps/settings/base.de.i18n` (+5 -0) 📝 `apps/settings/base.en.i18n` (+5 -0) 📝 `apps/settings/base.es.i18n` (+5 -0) 📝 `apps/settings/base.fr.i18n` (+5 -0) 📝 `apps/settings/base.hu.i18n` (+5 -0) 📝 `apps/settings/base.it.i18n` (+5 -0) 📝 `apps/settings/base.nl.i18n` (+5 -0) 📝 `apps/settings/base.pt.i18n` (+5 -0) 📝 `apps/settings/main_controller.cpp` (+7 -28) 📝 `apps/settings/main_controller.h` (+4 -2) 📝 `apps/settings/main_controller_prompt_beta.cpp` (+1 -1) 📝 `apps/settings/main_controller_prompt_none.cpp` (+1 -1) 📝 `apps/settings/main_controller_prompt_update.cpp` (+2 -2) ➕ `apps/settings/sub_menu/brightness_controller.cpp` (+142 -0) _...and 6 more files_ </details> ### 📄 Description This pull request adds backlight settings, based on Omega-Numworks#276. To do: - [x] Add and improve translations. - [x] Fix dimmer - [x] Add a setting for dimer duration - [x] Check if brightness dimmed is inferior to the normal brightness - [x] Fix the brightness slider with key bindings --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>