[PR #148] [MERGED] 2 corrections of bugs about the battery level in the settings #292

New issue

Closed

opened 2026-05-06 13:16:40 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:16:40 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/148
Author: @AlexandreArduino
Created: 2/7/2022
Status: ✅ Merged
Merged: 3/3/2022
Merged by: @Yaya-Cout

Base: upsilon-dev ← Head: upsilon-dev-battery-level

📝 Commits (6)

0e6da5d added battery level handler for simulator
acdf01f added battery level > 100% when charging
b207d82 corrected version
b0ec54a laury version but with float type
58e57ca Update apps/settings/sub_menu/about_controller.cpp
32afe77 Update apps/settings/sub_menu/about_controller.cpp

📊 Changes

1 file changed (+15 additions, -5 deletions)

View changed files

📝 apps/settings/sub_menu/about_controller.cpp (+15 -5)

📄 Description

First bug :

when you use the simulator and go in the about section, you see that the battery level (in %) is -537% or something like that, with my patch it is now 0%

Second bug :

when you plug your calculator, the battery level is > 100% obviously but it is not necessary to show this "fake" value I think. So the battery level when the calculator is plugged is blocked to 100% whereas the battery voltage is the real voltage.

Bye :p

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/148 **Author:** [@AlexandreArduino](https://github.com/AlexandreArduino) **Created:** 2/7/2022 **Status:** ✅ Merged **Merged:** 3/3/2022 **Merged by:** [@Yaya-Cout](https://github.com/Yaya-Cout) **Base:** `upsilon-dev` ← **Head:** `upsilon-dev-battery-level` --- ### 📝 Commits (6) - [`0e6da5d`](https://github.com/UpsilonNumworks/Upsilon/commit/0e6da5d6e7bfdb6a2af030ac334d0c32b443d458) added battery level handler for simulator - [`acdf01f`](https://github.com/UpsilonNumworks/Upsilon/commit/acdf01fd20db07c7ce2c0da59e3ac2bafc1f5203) added battery level > 100% when charging - [`b207d82`](https://github.com/UpsilonNumworks/Upsilon/commit/b207d828b68e78276d4fbc781583b96a532cddf6) corrected version - [`b0ec54a`](https://github.com/UpsilonNumworks/Upsilon/commit/b0ec54a354987eaf12f4f0062cf1eabaaa737b1d) laury version but with float type - [`58e57ca`](https://github.com/UpsilonNumworks/Upsilon/commit/58e57cad718f51cecb62e1dec8909fc98c159c21) Update apps/settings/sub_menu/about_controller.cpp - [`32afe77`](https://github.com/UpsilonNumworks/Upsilon/commit/32afe77cbb5cf7e3af30e7ae002fe33a6b803f69) Update apps/settings/sub_menu/about_controller.cpp ### 📊 Changes **1 file changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `apps/settings/sub_menu/about_controller.cpp` (+15 -5) </details> ### 📄 Description First bug : - when you use the simulator and go in the about section, you see that the battery level (in %) is -537% or something like that, with my patch it is now 0% Second bug : - when you plug your calculator, the battery level is > 100% obviously but it is not necessary to show this "fake" value I think. So the battery level when the calculator is plugged is blocked to 100% whereas the battery voltage is the real voltage. Bye :p --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>