[PR #175] [ graph ] Tangent toggle functionnality (#156) #297

New issue

Open

opened 2026-05-06 13:16:41 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:16:41 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/175
Author: @devdl11
Created: 3/11/2022
Status: 🔄 Open

Base: upsilon-dev ← Head: upsilon-issue156bis

📝 Commits (7)

10750b7 unpack error
380ae81 tangent switch solved.
ca41a01 Tangent button moved in the first menu and fixed zooms issues.
b27d22f orthographic error corrected
c5641b4 orthographic error corrected (bis)
b3d690e Remove useless code
b1ee05f Rename the ifndef as the review suggested

📊 Changes

16 files changed (+150 additions, -44 deletions)

View changed files

📝 apps/apps_container.cpp (+7 -1)
📝 apps/apps_container.h (+6 -0)
📝 apps/graph/graph/calculation_parameter_controller.cpp (+8 -11)
📝 apps/graph/graph/calculation_parameter_controller.h (+4 -4)
📝 apps/graph/graph/curve_parameter_controller.cpp (+14 -5)
📝 apps/graph/graph/curve_parameter_controller.h (+2 -0)
📝 apps/graph/graph/graph_view.cpp (+1 -4)
📝 apps/graph/graph/tangent_graph_controller.cpp (+37 -10)
📝 apps/graph/graph/tangent_graph_controller.h (+8 -2)
📝 apps/shared/Makefile (+1 -0)
➕ apps/shared/function_active_function_toggle.cpp (+22 -0)
➕ apps/shared/function_active_function_toggle.h (+27 -0)
📝 apps/shared/function_curve_parameter_controller.cpp (+6 -3)
📝 apps/shared/function_curve_parameter_controller.h (+3 -2)
📝 apps/shared/function_graph_controller.cpp (+3 -2)
📝 apps/shared/function_graph_controller.h (+1 -0)

📄 Description

The students can now switch between the tangents directly from the tangent's view using the up and down keys

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/175 **Author:** [@devdl11](https://github.com/devdl11) **Created:** 3/11/2022 **Status:** 🔄 Open **Base:** `upsilon-dev` ← **Head:** `upsilon-issue156bis` --- ### 📝 Commits (7) - [`10750b7`](https://github.com/UpsilonNumworks/Upsilon/commit/10750b78773980f0509b2a160f412b4554c95122) unpack error - [`380ae81`](https://github.com/UpsilonNumworks/Upsilon/commit/380ae812bde255aac53cfbb3df169c94dd04a54b) tangent switch solved. - [`ca41a01`](https://github.com/UpsilonNumworks/Upsilon/commit/ca41a01b49b69369f9377351488ed206214d53a4) Tangent button moved in the first menu and fixed zooms issues. - [`b27d22f`](https://github.com/UpsilonNumworks/Upsilon/commit/b27d22fe93f6b06043577be487079834c1d3838e) orthographic error corrected - [`c5641b4`](https://github.com/UpsilonNumworks/Upsilon/commit/c5641b4b9e14a20a28d01b03ecbf1d484b0e9699) orthographic error corrected (bis) - [`b3d690e`](https://github.com/UpsilonNumworks/Upsilon/commit/b3d690e662353abe51904e824d1c1b9e7c2ee6a4) Remove useless code - [`b1ee05f`](https://github.com/UpsilonNumworks/Upsilon/commit/b1ee05f865f28097bae50dd9d970b5014236edc5) Rename the ifndef as the review suggested ### 📊 Changes **16 files changed** (+150 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `apps/apps_container.cpp` (+7 -1) 📝 `apps/apps_container.h` (+6 -0) 📝 `apps/graph/graph/calculation_parameter_controller.cpp` (+8 -11) 📝 `apps/graph/graph/calculation_parameter_controller.h` (+4 -4) 📝 `apps/graph/graph/curve_parameter_controller.cpp` (+14 -5) 📝 `apps/graph/graph/curve_parameter_controller.h` (+2 -0) 📝 `apps/graph/graph/graph_view.cpp` (+1 -4) 📝 `apps/graph/graph/tangent_graph_controller.cpp` (+37 -10) 📝 `apps/graph/graph/tangent_graph_controller.h` (+8 -2) 📝 `apps/shared/Makefile` (+1 -0) ➕ `apps/shared/function_active_function_toggle.cpp` (+22 -0) ➕ `apps/shared/function_active_function_toggle.h` (+27 -0) 📝 `apps/shared/function_curve_parameter_controller.cpp` (+6 -3) 📝 `apps/shared/function_curve_parameter_controller.h` (+3 -2) 📝 `apps/shared/function_graph_controller.cpp` (+3 -2) 📝 `apps/shared/function_graph_controller.h` (+1 -0) </details> ### 📄 Description The students can now switch between the tangents directly from the tangent's view using the up and down keys --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>