interval] Pass parameter by const * #310

New issue

Closed

opened 2026-05-06 13:16:45 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:16:45 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/202
Author: @Tunas1337
Created: 4/7/2022
Status: ❌ Closed

Base: upsilon-dev ← Head: upsilon-dev-parameter-const

📝 Commits (1)

e642483 [apps/shared/interval] Pass parameter by const *

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 apps/shared/interval.cpp (+1 -1)
📝 apps/shared/interval.h (+2 -2)

📄 Description

In apps/shared/interval.{cpp,h}, there are two function calls that have a parameter passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
I have tested this on the calculator and everything seems in order. I'm making this PR to see if it'll change the RAM/flash usage and/or performance; it should theoretically, but I don't know if it will be noticeable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/202 **Author:** [@Tunas1337](https://github.com/Tunas1337) **Created:** 4/7/2022 **Status:** ❌ Closed **Base:** `upsilon-dev` ← **Head:** `upsilon-dev-parameter-const` --- ### 📝 Commits (1) - [`e642483`](https://github.com/UpsilonNumworks/Upsilon/commit/e642483adbde61d8d5546baab9792e7f5e527580) [apps/shared/interval] Pass parameter by const * ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `apps/shared/interval.cpp` (+1 -1) 📝 `apps/shared/interval.h` (+2 -2) </details> ### 📄 Description In apps/shared/interval.{cpp,h}, there are two function calls that have a parameter passed by value. It could be passed as a const reference which is usually faster and recommended in C++. I have tested this on the calculator and everything seems in order. I'm making this PR to see if it'll change the RAM/flash usage and/or performance; it should theoretically, but I don't know if it will be noticeable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>