[PR #320] [CLOSED] little fix with key EE #364

New issue

Closed

opened 2026-05-06 13:17:01 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:17:01 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/320
Author: @ZetaMap
Created: 4/4/2023
Status: ❌ Closed

Base: upsilon-dev ← Head: patch-1

📝 Commits (1)

e8eb129 little fix with key EE

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 apps/apps_container.cpp (+2 -2)

📄 Description

The calculator crash when this key is pressed and if an app like rpn, reader, or other, is not present so will use the constant APPS_CONTAINER_SNAPSHOT_COUNT to know index of settings.

Note : I haven't tested the case where it could always select the last of apps, if there are external ones. I don't know if this variable also counts external apps, but I see it used above, so why not use it.

EDIT: I tested this case and is work perfectly, the key always open settings even 1 or more apps is not present. 😉

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/320 **Author:** [@ZetaMap](https://github.com/ZetaMap) **Created:** 4/4/2023 **Status:** ❌ Closed **Base:** `upsilon-dev` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`e8eb129`](https://github.com/UpsilonNumworks/Upsilon/commit/e8eb129a3617b48c0f572931ad2a531edc13c1e9) little fix with key EE ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/apps_container.cpp` (+2 -2) </details> ### 📄 Description The calculator crash when this key is pressed and if an app like rpn, reader, or other, is not present so will use the constant APPS_CONTAINER_SNAPSHOT_COUNT to know index of settings. **Note :** I haven't tested the case where it could always select the last of apps, if there are external ones. I don't know if this variable also counts external apps, but I see it used above, so why not use it. **EDIT:** I tested this case and is work perfectly, the key always open settings even 1 or more apps is not present. 😉 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>