[PR #340] [MERGED] [NSpire Simulator] Fix framebuffer in nspire port #370

New issue

Closed

opened 2026-05-06 13:17:03 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:17:03 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/340
Author: @Luminoso-256
Created: 9/15/2023
Status: ✅ Merged
Merged: 9/15/2023
Merged by: @Yaya-Cout

Base: upsilon-dev ← Head: fix-nspire-port

📝 Commits (2)

be464cc Fix the nspire port (ergo: framebuffer functions, shift/ctrl don't corrupt things due to weird draw calls)
6c8c87e cleanup the k_csdk changes

📊 Changes

6 files changed (+16 additions, -54 deletions)

View changed files

📝 ion/src/simulator/nspire/display.cpp (+4 -19)
📝 ion/src/simulator/nspire/k_csdk.c (+2 -1)
📝 ion/src/simulator/nspire/keyboard.cpp (+3 -0)
📝 ion/src/simulator/nspire/main.cpp (+1 -30)
📝 ion/src/simulator/nspire/main.h (+0 -2)
📝 ion/src/simulator/nspire/power.cpp (+6 -2)

📄 Description

Resolves the issue brought up in UpsilonNumworks/Upsilon#339 (and therefore closes #339 )

The issue ultimately boils down to incorrectly handling the fact that some calculators use a different framebuffer implementation under the hood that is not compatible with the assumptions that were being made.

Also makes the framebuffer copy more efficient - direct passing of the buffer via lcd_blit instead of the loop-through-and-draw-1x1-rectangles algorithm being used before.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/340 **Author:** [@Luminoso-256](https://github.com/Luminoso-256) **Created:** 9/15/2023 **Status:** ✅ Merged **Merged:** 9/15/2023 **Merged by:** [@Yaya-Cout](https://github.com/Yaya-Cout) **Base:** `upsilon-dev` ← **Head:** `fix-nspire-port` --- ### 📝 Commits (2) - [`be464cc`](https://github.com/UpsilonNumworks/Upsilon/commit/be464cc278af602f6dd94be10550b9c8ea968842) Fix the nspire port (ergo: framebuffer functions, shift/ctrl don't corrupt things due to weird draw calls) - [`6c8c87e`](https://github.com/UpsilonNumworks/Upsilon/commit/6c8c87e6f3c26d907d41dc977dcd28fcb416dcb8) cleanup the k_csdk changes ### 📊 Changes **6 files changed** (+16 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `ion/src/simulator/nspire/display.cpp` (+4 -19) 📝 `ion/src/simulator/nspire/k_csdk.c` (+2 -1) 📝 `ion/src/simulator/nspire/keyboard.cpp` (+3 -0) 📝 `ion/src/simulator/nspire/main.cpp` (+1 -30) 📝 `ion/src/simulator/nspire/main.h` (+0 -2) 📝 `ion/src/simulator/nspire/power.cpp` (+6 -2) </details> ### 📄 Description Resolves the issue brought up in UpsilonNumworks/Upsilon#339 (and therefore closes #339 ) The issue ultimately boils down to incorrectly handling the fact that some calculators use a different framebuffer implementation under the hood that is not compatible with the assumptions that were being made. Also makes the framebuffer copy more efficient - direct passing of the buffer via `lcd_blit` instead of the loop-through-and-draw-1x1-rectangles algorithm being used before. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>