[PR #386] [MERGED] Fix: correct console text background color #394

New issue

Closed

opened 2026-05-06 13:17:10 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:17:10 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/UpsilonNumworks/Upsilon/pull/386
Author: @LukasMFR
Created: 11/2/2025
Status: ✅ Merged
Merged: 11/2/2025
Merged by: @Yaya-Cout

Base: upsilon-dev ← Head: fix-console-text-background

📝 Commits (1)

14bc5b0 Fix highlight background in console line view

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 apps/code/console_line_cell.cpp (+1 -1)

📄 Description

Description

This pull request changes the background color used behind console text lines.
Previously, non-highlighted console lines were drawn using Palette::BackgroundApps.
This caused a mismatch with the expected Palette::CodeBackground used elsewhere in the Python app.

Changes

In console_line_cell.cpp, replaced:

  Palette::BackgroundApps

with:

Palette::CodeBackground

in ConsoleLineCell::ScrollableConsoleLineView::ConsoleLineView::drawRect().

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UpsilonNumworks/Upsilon/pull/386 **Author:** [@LukasMFR](https://github.com/LukasMFR) **Created:** 11/2/2025 **Status:** ✅ Merged **Merged:** 11/2/2025 **Merged by:** [@Yaya-Cout](https://github.com/Yaya-Cout) **Base:** `upsilon-dev` ← **Head:** `fix-console-text-background` --- ### 📝 Commits (1) - [`14bc5b0`](https://github.com/UpsilonNumworks/Upsilon/commit/14bc5b04dd3dfb9d51d5113cb89cc39efe197458) Fix highlight background in console line view ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/code/console_line_cell.cpp` (+1 -1) </details> ### 📄 Description ### Description This pull request changes the background color used behind console text lines. Previously, non-highlighted console lines were drawn using `Palette::BackgroundApps`. This caused a mismatch with the expected `Palette::CodeBackground` used elsewhere in the Python app. ### Changes - In `console_line_cell.cpp`, replaced: ```cpp Palette::BackgroundApps ``` with: ```cpp Palette::CodeBackground ``` in `ConsoleLineCell::ScrollableConsoleLineView::ConsoleLineView::drawRect()`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>