starred/bambuddy-maziggy-1
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 08:25:54 +02:00
Code Issues 44 Projects Packages Wiki Activity

[PR #344] [CLOSED] New Feature: Confirm Part Removal #1008

New issue
Closed
opened 2026-05-07 00:15:27 +02:00 by BreizhHardware · 0 comments
BreizhHardware commented 2026-05-07 00:15:27 +02:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/344
Author: @cadtoolbox
Created: 2/12/2026
Status: ❌ Closed

Base: 0.2.1b ← Head: feature_confirm_removal

📝 Commits (10+)

  • 55cef1f Initial plan
  • 9d25547 Backend: Add part removal confirmation database fields and API endpoint
  • a670367 Frontend: Add Part Removal Confirmation UI with button and info box
  • bd3e721 Frontend: Add i18n translations for Part Removal feature (de, it, ja)
  • 3e57fa5 Final: Part Removal Confirmation feature implementation complete
  • 391add4 Backend: Implement auto-pause logic for Part Removal Confirmation
  • 84fb3c0 Frontend: Add pause warning message for Part Removal and translations
  • d7bd413 Fix: Remove circular import in on_printer_status_change
  • 4367daf Merge Pull Request #32 : Initial batch of changes required for new features
  • 7bf41ef Initial plan

📊 Changes

31 files changed (+10454 additions, -8773 deletions)

View changed files

📝 backend/app/api/routes/print_queue.py (+17 -1)
📝 backend/app/api/routes/printers.py (+119 -0)
📝 backend/app/core/database.py (+36 -0)
📝 backend/app/core/websocket.py (+10 -0)
📝 backend/app/main.py (+180 -0)
📝 backend/app/models/printer.py (+8 -0)
📝 backend/app/schemas/print_queue.py (+4 -0)
📝 backend/app/schemas/printer.py (+15 -0)
📝 backend/app/services/bambu_mqtt.py (+28 -4)
📝 backend/app/services/firmware_check.py (+5 -0)
📝 backend/app/services/notification_service.py (+24 -0)
📝 backend/app/services/print_scheduler.py (+41 -4)
📝 backend/tests/unit/test_scheduler_ams_mapping.py (+70 -0)
📝 frontend/src/__tests__/components/PrinterQueueWidget.test.tsx (+59 -0)
📝 frontend/src/__tests__/hooks/useLongPress.test.ts (+69 -0)
📝 frontend/src/__tests__/pages/PrintersPage.test.tsx (+523 -0)
📝 frontend/src/api/client.ts (+25 -0)
📝 frontend/src/components/PrinterQueueWidget.tsx (+1 -1)
📝 frontend/src/hooks/useLongPress.ts (+5 -0)
📝 frontend/src/hooks/useWebSocket.ts (+18 -0)

...and 11 more files

📄 Description

Description

This introduces a new manual method of confirming the printer build plate is clear before allowing the next print job to start on the printer.

  1. Each printer, an Admin must set 'Part Removal Confirmation' to enabled. This cannot be used with the visual build plate confirmation feature.
  2. Print starts on printer.
  3. Print successfully completes on printer.
  4. Part removal confirmation must be completed from the printer card or the completed print queue record.
  5. If another print job is sent to the same printer before confirmation is made, the print starts but immediately pauses.
  6. The removal confirmation must still be made using Bambuddy. Resuming the print from the physical printer itself accomplishes the same confirmation and the next print is allow to proceed normally.

Note: Any user in Bambuddy is allowed to confirm part removal.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • New feature for part removal confirmation screens.
  • Some MQTT robustness changes.

Screenshots

2026-02-12_10-02-24
2026-02-12_10-02-00
2026-02-12_10-01-45

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: X1E and H2D Pro

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/344 **Author:** [@cadtoolbox](https://github.com/cadtoolbox) **Created:** 2/12/2026 **Status:** ❌ Closed **Base:** `0.2.1b` ← **Head:** `feature_confirm_removal` --- ### 📝 Commits (10+) - [`55cef1f`](https://github.com/maziggy/bambuddy/commit/55cef1f83304bb26966a8361b0b03e2165d2378c) Initial plan - [`9d25547`](https://github.com/maziggy/bambuddy/commit/9d255478a680f30d99cc9c8a468db12a4f487988) Backend: Add part removal confirmation database fields and API endpoint - [`a670367`](https://github.com/maziggy/bambuddy/commit/a670367e834e06ce5367677e203a4dfa9ba24787) Frontend: Add Part Removal Confirmation UI with button and info box - [`bd3e721`](https://github.com/maziggy/bambuddy/commit/bd3e721c169500babb9d963b5fe9507478ceae0c) Frontend: Add i18n translations for Part Removal feature (de, it, ja) - [`3e57fa5`](https://github.com/maziggy/bambuddy/commit/3e57fa5ced0b79d8a055fd49e6c2bdf36650a61d) Final: Part Removal Confirmation feature implementation complete - [`391add4`](https://github.com/maziggy/bambuddy/commit/391add4acd0ca08fe557b7b8b30d3bec489d1cf4) Backend: Implement auto-pause logic for Part Removal Confirmation - [`84fb3c0`](https://github.com/maziggy/bambuddy/commit/84fb3c02cec3a7bc32d85e5da6e500f5b78a211d) Frontend: Add pause warning message for Part Removal and translations - [`d7bd413`](https://github.com/maziggy/bambuddy/commit/d7bd4131bb72b83688b5b3011dc4da3953d5648d) Fix: Remove circular import in on_printer_status_change - [`4367daf`](https://github.com/maziggy/bambuddy/commit/4367daf83b6768bd84fa249c90e74203e71557b0) Merge Pull Request #32 : Initial batch of changes required for new features - [`7bf41ef`](https://github.com/maziggy/bambuddy/commit/7bf41efa0ed0068460d9c06517821deb2a6ffbb3) Initial plan ### 📊 Changes **31 files changed** (+10454 additions, -8773 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/api/routes/print_queue.py` (+17 -1) 📝 `backend/app/api/routes/printers.py` (+119 -0) 📝 `backend/app/core/database.py` (+36 -0) 📝 `backend/app/core/websocket.py` (+10 -0) 📝 `backend/app/main.py` (+180 -0) 📝 `backend/app/models/printer.py` (+8 -0) 📝 `backend/app/schemas/print_queue.py` (+4 -0) 📝 `backend/app/schemas/printer.py` (+15 -0) 📝 `backend/app/services/bambu_mqtt.py` (+28 -4) 📝 `backend/app/services/firmware_check.py` (+5 -0) 📝 `backend/app/services/notification_service.py` (+24 -0) 📝 `backend/app/services/print_scheduler.py` (+41 -4) 📝 `backend/tests/unit/test_scheduler_ams_mapping.py` (+70 -0) 📝 `frontend/src/__tests__/components/PrinterQueueWidget.test.tsx` (+59 -0) 📝 `frontend/src/__tests__/hooks/useLongPress.test.ts` (+69 -0) 📝 `frontend/src/__tests__/pages/PrintersPage.test.tsx` (+523 -0) 📝 `frontend/src/api/client.ts` (+25 -0) 📝 `frontend/src/components/PrinterQueueWidget.tsx` (+1 -1) 📝 `frontend/src/hooks/useLongPress.ts` (+5 -0) 📝 `frontend/src/hooks/useWebSocket.ts` (+18 -0) _...and 11 more files_ </details> ### 📄 Description ## Description This introduces a new manual method of confirming the printer build plate is clear before allowing the next print job to start on the printer. 1. Each printer, an Admin must set 'Part Removal Confirmation' to enabled. This cannot be used with the visual build plate confirmation feature. 2. Print starts on printer. 3. Print successfully completes on printer. 4. Part removal confirmation must be completed from the printer card or the completed print queue record. 5. If another print job is sent to the same printer before confirmation is made, the print starts but immediately pauses. 6. The removal confirmation must still be made using Bambuddy. Resuming the print from the physical printer itself accomplishes the same confirmation and the next print is allow to proceed normally. Note: Any user in Bambuddy is allowed to confirm part removal. ## Type of Change <!-- Mark the relevant option with an "x" --> - [X] Bug fix (non-breaking change that fixes an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made <!-- List the specific changes made in this PR --> - New feature for part removal confirmation screens. - Some MQTT robustness changes. ## Screenshots <!-- If applicable, add screenshots to demonstrate your changes --> ![2026-02-12_10-02-24](https://github.com/user-attachments/assets/66920d6e-dad4-4692-b801-c9cd50d88f2a) ![2026-02-12_10-02-00](https://github.com/user-attachments/assets/ee4cc9e1-eee2-4ede-97e4-0e50254fda19) ![2026-02-12_10-01-45](https://github.com/user-attachments/assets/9295b133-f3e0-46b7-87fb-df57c6f9bab3) ## Testing <!-- Describe how you tested your changes --> - [X] I have tested this on my local machine - [X] I have tested with my printer model: X1E and H2D Pro ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes <!-- Add any additional information that reviewers should know --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 00:15:27 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
github-repo-stats
bug-report-assets
dev
0.2.4b3
0.2.4b2
0.2.4b1
pr/1114
0.2.3.2
0.2.3.1
0.2.3
0.2.3b3
0.2.3b2
0.2.3b1
0.2.2.2
0.2.2.1
0.2.2b3
0.2.2
0.2.2b2
0.2.2b1
0.2.1.1
0.2.1
0.2.1b3
0.2.1b2
0.2.1b
0.2.0
0.2.0b
0.1.5-2-ctrl
v0.2.4b4-daily.20260508
v0.2.4b2
v0.2.4b3
v0.2.4b1
v0.2.3.2
v0.2.3.1
v0.2.3
v0.2.3b3
v0.2.3b2
v0.2.3b1-daily.20260407
v0.2.3b1
v0.2.2.2
v0.2.2.1
v0.2.3b1-daily.20260318
v0.2.3b1-daily.20260317
v0.2.3b1-daily.20260316
v0.2.2
v0.2.2b4-daily.20260314
v0.2.2b4-daily.20260313
v0.2.2b3-daily.20260312
v0.2.2b3-1
v0.2.2b2
v0.2.2-b2
v0.2.2b3
v0.2.2-b1
v0.2.2b1
v0.2.1.1
v0.2.1
v0.2.1b3
v0.2.1b2
v0.2.1b
v0.2.0
v0.1.9
v0.1.8.1
v0.1.8
v0.1.7
v0.1.6.2
v0.1.6.1
v0.1.6-hotfix
v0.1.6
v0.1.6b11
v0.1.6b10
v0.1.6b9
v0.1.6b8
v0.1.6b7
v0.1.6b6
v0.1.6b5
v0.1.6b4
v0.1.6b3
v0.1.6b2
v0.1.6b
v0.1.5-final
v0.1.5b7
v0.1.5b6
v0.1.5b5
v0.1.5b4
v0.1.5b3
v0.1.5b2
v0.1.5b
v0.1.4
v0.1.3
v0.1.2-bugfix
v0.1.2-final
v0.1.2
0.1.1
Labels
Clear labels   
A1

   
automated

   
automated

   
bug

   
bug

   
Closed due to inactivity

   
contrib

   
dependencies

   
dependencies

   
duplicate

   
enhancement

   
feedback

   
hold

   
invalid

   
Notes

   
P1S

   
pull-request
Mirrored from GitHub Pull Request

  
security

   
ThumbsUp

   
user-report

   
wontfix
No labels
A1
automated
automated
bug
bug
Closed due to inactivity
contrib
dependencies
dependencies
duplicate
enhancement
feedback
hold
invalid
Notes
P1S
pull-request
security
ThumbsUp
user-report
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy-maziggy-1#1008
No description provided.