[PR #578] [MERGED] [Fix]: AMS slot modal infinite scroll loop on Windows

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/bambuddy-maziggy-1#1076

BreizhHardware commented

2026-05-07 00:15:52 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/578
Author: @aneopsy
Created: 3/3/2026
Status: ✅ Merged
Merged: 3/3/2026
Merged by: @maziggy

Base: 0.2.2b1 ← Head: fix-ams-slot

📝 Commits (2)

d048d72 Fix AMS slot modal infinite scroll loop on Windows
01b8fbb Merge branch '0.2.2b1' into fix-ams-slot

📊 Changes

1 file changed (+16 additions, -7 deletions)

View changed files

📝 frontend/src/components/ConfigureAmsSlotModal.tsx (+16 -7)

📄 Description

Fixes #575

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

Inline callback refs on preset buttons called scrollIntoView on every
re-render, creating a scroll → re-render → scrollIntoView loop on
Windows.
Replace with a useEffect + data attribute approach that only
scrolls when the selected preset actually changes.

Testing

I have tested this on my local machine
I have tested with my printer model: WINDOWS

Checklist

My code follows the project's coding style
I have commented my code where necessary
I have updated the documentation (if needed)
My changes generate no new warnings
I have tested my changes thoroughly

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/578 **Author:** [@aneopsy](https://github.com/aneopsy) **Created:** 3/3/2026 **Status:** ✅ Merged **Merged:** 3/3/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.2.2b1` ← **Head:** `fix-ams-slot` --- ### 📝 Commits (2) - [`d048d72`](https://github.com/maziggy/bambuddy/commit/d048d72df2cda2e1148f306611c7e7287d0d55ae) Fix AMS slot modal infinite scroll loop on Windows - [`01b8fbb`](https://github.com/maziggy/bambuddy/commit/01b8fbb14f9fc56dec8c47a86fc2d534f576cea3) Merge branch '0.2.2b1' into fix-ams-slot ### 📊 Changes **1 file changed** (+16 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/ConfigureAmsSlotModal.tsx` (+16 -7) </details> ### 📄 Description ## Related Issue Fixes #575 ## Type of Change - [X] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made Inline callback refs on preset buttons called scrollIntoView on every re-render, creating a scroll → re-render → scrollIntoView loop on Windows. Replace with a useEffect + data attribute approach that only scrolls when the selected preset actually changes. ## Testing - [X] I have tested this on my local machine - [X] I have tested with my printer model: WINDOWS ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [X] I have updated the documentation (if needed) - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

closed this issue
added the
pull-request
label

Rows
Columns

[PR #578] [MERGED] [Fix]: AMS slot modal infinite scroll loop on Windows #1076