starred/bambuddy-maziggy-1

Fork

You've already forked bambuddy-maziggy-1

mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 08:25:54 +02:00

Code Issues 44 Projects Packages Wiki Activity

[PR #582] [CLOSED] [Feature] Rework Archive duplicates tagging #1080

New issue

Closed

opened 2026-05-07 00:15:52 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:15:52 +02:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/582
Author: @Keybored02
Created: 3/3/2026
Status: ❌ Closed

Base: 0.2.3b1 ← Head: feature/duplicate_rework

📝 Commits (10+)

1da8712 Use SHA256 for duplicate count, show archive_id on card
a024d70 Fix double scrollbars on Archive page
3633076 Show reduced SHA256 to identify print file
92e250a Compact duplicate tags, send to father on click
4a69372 Add Hide Duplicates button
74cf749 Add button localisation
d950bc5 Refactor duplicate handling to return name/hash pairs
26d996f Fix title attribute to reference original archive ID in ArchiveCard and ArchiveListRow
537b00f Add localization for "view original print" message
c9e87f4 Add duplicate sequence and original archive ID to archive responses

📊 Changes

12 files changed (+162 additions, -26 deletions)

View changed files

📝 backend/app/api/routes/archives.py (+47 -5)
📝 backend/app/schemas/archive.py (+2 -0)
📝 backend/app/services/archive.py (+21 -12)
📝 frontend/src/api/client.ts (+2 -0)
📝 frontend/src/i18n/locales/de.ts (+2 -0)
📝 frontend/src/i18n/locales/en.ts (+2 -0)
📝 frontend/src/i18n/locales/fr.ts (+2 -0)
📝 frontend/src/i18n/locales/it.ts (+2 -0)
📝 frontend/src/i18n/locales/ja.ts (+2 -0)
📝 frontend/src/i18n/locales/pt-BR.ts (+2 -0)
📝 frontend/src/i18n/locales/zh-CN.ts (+2 -0)
📝 frontend/src/pages/ArchivesPage.tsx (+76 -9)

📄 Description

Description

This PR proposes a quick fix to improve duplication handling in the archive page. The idea is to improve usability without fully reworking the archiving behavior. This Pr introduces a different logic to tag duplicates, an UI improvement on the tag itself, a more detailed Archive card, and minor fixes to the Archive page.

Related Issue

Fixes #397 and #512

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

Changed duplicate tagging: now both the name and SHA256 need to match to tag a print as duplicates. Fixes different print being tagged only on the base of the same name
"Duplicate" text removed form the tag, now the tag shows the number of reprints
Tag is now a button that sends back to the parent print, with outline highlights
A new filter Hide Duplicates has been added to the filter bar, with localisation
Archive cards included a reduced SHA256 hash to identify associated files and an archive_id to distinguish similar archive entries
Fixed double scrollbar appearing in Archive page

Screenshots

Testing

I have tested this on my local machine
I have tested with my printer model: H2C

Checklist

My code follows the project's coding style
I have commented my code where necessary
I have updated the documentation (if needed)
My changes generate no new warnings
I have tested my changes thoroughly

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/582 **Author:** [@Keybored02](https://github.com/Keybored02) **Created:** 3/3/2026 **Status:** ❌ Closed **Base:** `0.2.3b1` ← **Head:** `feature/duplicate_rework` --- ### 📝 Commits (10+) - [`1da8712`](https://github.com/maziggy/bambuddy/commit/1da87125102b0791f6ea1cd6d5167b86c5cb9239) Use SHA256 for duplicate count, show archive_id on card - [`a024d70`](https://github.com/maziggy/bambuddy/commit/a024d70d72b61f1e18680bffbfdd93950e1b5f52) Fix double scrollbars on Archive page - [`3633076`](https://github.com/maziggy/bambuddy/commit/3633076d2a7d85493e680559504143dd814d2168) Show reduced SHA256 to identify print file - [`92e250a`](https://github.com/maziggy/bambuddy/commit/92e250a14fd2a87ca96161410757e8649401738d) Compact duplicate tags, send to father on click - [`4a69372`](https://github.com/maziggy/bambuddy/commit/4a693720b5c204bda6a939018e7984c1598ef331) Add Hide Duplicates button - [`74cf749`](https://github.com/maziggy/bambuddy/commit/74cf749035c7af4396e40f012d6250157d4ad4ed) Add button localisation - [`d950bc5`](https://github.com/maziggy/bambuddy/commit/d950bc535bf61a07df9d5ec5b513530a146a11d7) Refactor duplicate handling to return name/hash pairs - [`26d996f`](https://github.com/maziggy/bambuddy/commit/26d996f88fc6babe4654086f5e817ac9c5c1edd8) Fix title attribute to reference original archive ID in ArchiveCard and ArchiveListRow - [`537b00f`](https://github.com/maziggy/bambuddy/commit/537b00f282088f1ef9356856e4b5bbd9d6926845) Add localization for "view original print" message - [`c9e87f4`](https://github.com/maziggy/bambuddy/commit/c9e87f41b92a08c77d0349669249a764aaa19e3c) Add duplicate sequence and original archive ID to archive responses ### 📊 Changes **12 files changed** (+162 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/api/routes/archives.py` (+47 -5) 📝 `backend/app/schemas/archive.py` (+2 -0) 📝 `backend/app/services/archive.py` (+21 -12) 📝 `frontend/src/api/client.ts` (+2 -0) 📝 `frontend/src/i18n/locales/de.ts` (+2 -0) 📝 `frontend/src/i18n/locales/en.ts` (+2 -0) 📝 `frontend/src/i18n/locales/fr.ts` (+2 -0) 📝 `frontend/src/i18n/locales/it.ts` (+2 -0) 📝 `frontend/src/i18n/locales/ja.ts` (+2 -0) 📝 `frontend/src/i18n/locales/pt-BR.ts` (+2 -0) 📝 `frontend/src/i18n/locales/zh-CN.ts` (+2 -0) 📝 `frontend/src/pages/ArchivesPage.tsx` (+76 -9) </details> ### 📄 Description ## Description This PR proposes a quick fix to improve duplication handling in the archive page. The idea is to improve usability without fully reworking the archiving behavior. This Pr introduces a different logic to tag duplicates, an UI improvement on the tag itself, a more detailed Archive card, and minor fixes to the Archive page. ## Related Issue  Fixes #397 and #512 ## Type of Change  - [x] Bug fix (non-breaking change that fixes an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made  - Changed duplicate tagging: now both the name and SHA256 need to match to tag a print as duplicates. Fixes different print being tagged only on the base of the same name - "Duplicate" text removed form the tag, now the tag shows the number of reprints - Tag is now a button that sends back to the parent print, with outline highlights - A new filter Hide Duplicates has been added to the filter bar, with localisation - Archive cards included a reduced SHA256 hash to identify associated files and an `archive_id` to distinguish similar archive entries - Fixed double scrollbar appearing in Archive page ## Screenshots  <img width="396" height="531" alt="image" src="https://github.com/user-attachments/assets/aa0fc2b3-973a-414d-a6ba-da63dfa71369" /> <img width="438" height="67" alt="image" src="https://github.com/user-attachments/assets/a2e2408c-3bec-4fa5-9fba-183a0e16dd8c" /> ## Testing  - [x] I have tested this on my local machine - [x] I have tested with my printer model: H2C ## Checklist - [x] My code follows the project's coding style - [x] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

2026-05-07 00:15:52 +02:00

closed this issue
added the
pull-request
label

No Branch/Tag specified

main

github-repo-stats

bug-report-assets

dev

0.2.4b3

0.2.4b2

0.2.4b1

pr/1114

0.2.3.2

0.2.3.1

0.2.3

0.2.3b3

0.2.3b2

0.2.3b1

0.2.2.2

0.2.2.1

0.2.2b3

0.2.2

0.2.2b2

0.2.2b1

0.2.1.1

0.2.1

0.2.1b3

0.2.1b2

0.2.1b

0.2.0

0.2.0b

0.1.5-2-ctrl

v0.2.4b4-daily.20260508

v0.2.4b2

v0.2.4b3

v0.2.4b1

v0.2.3.2

v0.2.3.1

v0.2.3

v0.2.3b3

v0.2.3b2

v0.2.3b1-daily.20260407

v0.2.3b1

v0.2.2.2

v0.2.2.1

v0.2.3b1-daily.20260318

v0.2.3b1-daily.20260317

v0.2.3b1-daily.20260316

v0.2.2

v0.2.2b4-daily.20260314

v0.2.2b4-daily.20260313

v0.2.2b3-daily.20260312

v0.2.2b3-1

v0.2.2b2

v0.2.2-b2

v0.2.2b3

v0.2.2-b1

v0.2.2b1

v0.2.1.1

v0.2.1

v0.2.1b3

v0.2.1b2

v0.2.1b

v0.2.0

v0.1.9

v0.1.8.1

v0.1.8

v0.1.7

v0.1.6.2

v0.1.6.1

v0.1.6-hotfix

v0.1.6

v0.1.6b11

v0.1.6b10

v0.1.6b9

v0.1.6b8

v0.1.6b7

v0.1.6b6

v0.1.6b5

v0.1.6b4

v0.1.6b3

v0.1.6b2

v0.1.6b

v0.1.5-final

v0.1.5b7

v0.1.5b6

v0.1.5b5

v0.1.5b4

v0.1.5b3

v0.1.5b2

v0.1.5b

v0.1.4

v0.1.3

v0.1.2-bugfix

v0.1.2-final

v0.1.2

0.1.1

Labels

Clear labels

automated

bug

Closed due to inactivity

Mirrored from GitHub Pull Request

No labels

Closed due to inactivity

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/bambuddy-maziggy-1#1080

Reference in a new issue

Repository

starred/bambuddy-maziggy-1

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns