1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 08:25:54 +02:00

[PR #693] [MERGED] Feature: Advanced Authentication User Email Notifications #1099

Closed
opened 2026-05-07 00:16:00 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/693
Author: @cadtoolbox
Created: 3/13/2026
Status: Merged
Merged: 3/17/2026
Merged by: @maziggy

Base: devHead: dev_user-notifications


📝 Commits (10+)

  • 1ab888d Advanced Authentication - user notifications updates + Bug Fixes
  • c49311b Merge branch 'dev' into dev_user-notifications
  • 1059494 Updates for PR#700
  • ff1ab66 Merge branch 'dev' into dev_user-notifications
  • 18d7f68 Merge branch 'dev' into dev_user-notifications
  • 17570b9 Merge branch 'dev' into dev_user-notifications
  • 4678772 Merge branch 'dev' into dev_user-notifications
  • a89bd0e Incorporate Maziggy comments from PR#693 (#115)
  • 794fd7b Merge branch 'dev' into dev_user-notifications
  • ee6b1e9 Merge branch 'dev' into dev_user-notifications

📊 Changes

29 files changed (+1328 additions, -13 deletions)

View changed files

📝 backend/app/api/routes/notification_templates.py (+5 -0)
📝 backend/app/api/routes/print_queue.py (+11 -0)
📝 backend/app/api/routes/settings.py (+1 -0)
backend/app/api/routes/user_notifications.py (+107 -0)
📝 backend/app/api/routes/users.py (+2 -1)
📝 backend/app/core/database.py (+47 -0)
📝 backend/app/core/permissions.py (+3 -1)
📝 backend/app/main.py (+327 -5)
📝 backend/app/models/notification_template.py (+25 -0)
📝 backend/app/models/user.py (+10 -0)
backend/app/models/user_email_pref.py (+31 -0)
📝 backend/app/schemas/notification_template.py (+34 -0)
📝 backend/app/schemas/settings.py (+7 -0)
backend/app/schemas/user_notifications.py (+24 -0)
📝 backend/app/services/email_service.py (+66 -0)
📝 backend/app/services/notification_service.py (+114 -0)
📝 backend/app/services/print_scheduler.py (+8 -1)
📝 frontend/src/App.tsx (+2 -0)
📝 frontend/src/api/client.ts (+20 -1)
📝 frontend/src/components/Layout.tsx (+19 -3)

...and 9 more files

📄 Description

Description

  • New Feature: Advanced Authentication user notifications
    This allows for basic email notifications for user specific print jobs, start, complete, error/stop and fail.
    Requires Advanced Authentication to be enabled + User Notifications

  • Bug Fix: Unable to update email address for Advanced Auth users

Fixes #683

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • Adds 'User Notifications' toggle within Notifications Admin settings.
  • Adds 'Notifications' Nav menu option
  • Adds Email templates for User Notifications

Screenshots

2026-03-12_22-51-07
2026-03-13_11-26-48

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: H2D Pro, X1E

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/693 **Author:** [@cadtoolbox](https://github.com/cadtoolbox) **Created:** 3/13/2026 **Status:** ✅ Merged **Merged:** 3/17/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `dev` ← **Head:** `dev_user-notifications` --- ### 📝 Commits (10+) - [`1ab888d`](https://github.com/maziggy/bambuddy/commit/1ab888d6a950eb6b3120738cd870b305e2ed871b) Advanced Authentication - user notifications updates + Bug Fixes - [`c49311b`](https://github.com/maziggy/bambuddy/commit/c49311bcc3a1862e85e29d91e6e2960a0cd2c050) Merge branch 'dev' into dev_user-notifications - [`1059494`](https://github.com/maziggy/bambuddy/commit/10594945601be9e99ee1d08156e6713644831fff) Updates for PR#700 - [`ff1ab66`](https://github.com/maziggy/bambuddy/commit/ff1ab66e0c632e2094e7324810e3c13222d34e34) Merge branch 'dev' into dev_user-notifications - [`18d7f68`](https://github.com/maziggy/bambuddy/commit/18d7f683eadcfe84faa763d60e60ad4e72e132ef) Merge branch 'dev' into dev_user-notifications - [`17570b9`](https://github.com/maziggy/bambuddy/commit/17570b97870382b4a869d4b1afbcd7b14ef087f9) Merge branch 'dev' into dev_user-notifications - [`4678772`](https://github.com/maziggy/bambuddy/commit/4678772061bdc655c91f951b84418bab700ca374) Merge branch 'dev' into dev_user-notifications - [`a89bd0e`](https://github.com/maziggy/bambuddy/commit/a89bd0e1ad2f082b9ea7cab24695cd523bbe560e) Incorporate Maziggy comments from PR#693 (#115) - [`794fd7b`](https://github.com/maziggy/bambuddy/commit/794fd7bfd2524d6c6c717691769a32c8b6b15584) Merge branch 'dev' into dev_user-notifications - [`ee6b1e9`](https://github.com/maziggy/bambuddy/commit/ee6b1e944c7b9b9fd3f1356511f1674c39bf797e) Merge branch 'dev' into dev_user-notifications ### 📊 Changes **29 files changed** (+1328 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/api/routes/notification_templates.py` (+5 -0) 📝 `backend/app/api/routes/print_queue.py` (+11 -0) 📝 `backend/app/api/routes/settings.py` (+1 -0) ➕ `backend/app/api/routes/user_notifications.py` (+107 -0) 📝 `backend/app/api/routes/users.py` (+2 -1) 📝 `backend/app/core/database.py` (+47 -0) 📝 `backend/app/core/permissions.py` (+3 -1) 📝 `backend/app/main.py` (+327 -5) 📝 `backend/app/models/notification_template.py` (+25 -0) 📝 `backend/app/models/user.py` (+10 -0) ➕ `backend/app/models/user_email_pref.py` (+31 -0) 📝 `backend/app/schemas/notification_template.py` (+34 -0) 📝 `backend/app/schemas/settings.py` (+7 -0) ➕ `backend/app/schemas/user_notifications.py` (+24 -0) 📝 `backend/app/services/email_service.py` (+66 -0) 📝 `backend/app/services/notification_service.py` (+114 -0) 📝 `backend/app/services/print_scheduler.py` (+8 -1) 📝 `frontend/src/App.tsx` (+2 -0) 📝 `frontend/src/api/client.ts` (+20 -1) 📝 `frontend/src/components/Layout.tsx` (+19 -3) _...and 9 more files_ </details> ### 📄 Description ## Description - New Feature: Advanced Authentication user notifications This allows for basic email notifications for user specific print jobs, start, complete, error/stop and fail. Requires Advanced Authentication to be enabled + User Notifications - Bug Fix: Unable to update email address for Advanced Auth users ## Related Issue <!-- Link to the issue this PR addresses (if applicable) --> Fixes #683 ## Type of Change <!-- Mark the relevant option with an "x" --> - [X] Bug fix (non-breaking change that fixes an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made <!-- List the specific changes made in this PR --> - Adds 'User Notifications' toggle within Notifications Admin settings. - Adds 'Notifications' Nav menu option - Adds Email templates for User Notifications ## Screenshots <!-- If applicable, add screenshots to demonstrate your changes --> ![2026-03-12_22-51-07](https://github.com/user-attachments/assets/2a018485-2942-4c94-88b8-8ddb938daca6) ![2026-03-13_11-26-48](https://github.com/user-attachments/assets/31c55c4b-284e-4e75-8801-db71178b938e) ## Testing <!-- Describe how you tested your changes --> - [X] I have tested this on my local machine - [X] I have tested with my printer model: H2D Pro, X1E ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [X] I have updated the documentation (if needed) - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes <!-- Add any additional information that reviewers should know --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 00:16:00 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy-maziggy-1#1099
No description provided.