1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 08:25:54 +02:00

[PR #761] [MERGED] Feature: Admin Set Default Nav-Menu Order #1112

Closed
opened 2026-05-07 00:16:05 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/761
Author: @cadtoolbox
Created: 3/20/2026
Status: Merged
Merged: 3/21/2026
Merged by: @maziggy

Base: devHead: dev_menu_order


📝 Commits (10+)

  • 26a08da Added Feature - Admin lockable side navigation menu
  • 6447360 Updates for lock/unlock workflow of nav menu. Changed button label.
  • d468af8 Removed need for menu order updates to require settings read permission
  • 77a1ceb Change logic from lock/unlock to set default for menu order
  • b01c92b Cosmetic changes
  • d5cbd32 Merge branch 'dev' into dev_menu_order
  • 6163e38 Merge branch 'dev' into dev_menu_order
  • 79afd76 Updates per PR#761 code review
  • 7762b48 Merge branch 'dev' into dev_menu_order
  • 43101ee Changed logic of 'Set Default' button for sidebar. Now applies to new users only. Fixed bugs.

📊 Changes

14 files changed (+325 additions, -169 deletions)

View changed files

📝 backend/app/api/routes/settings.py (+14 -0)
📝 backend/app/schemas/settings.py (+29 -1)
📝 frontend/src/api/client.ts (+3 -0)
📝 frontend/src/components/Layout.tsx (+33 -0)
📝 frontend/src/i18n/locales/de.ts (+5 -0)
📝 frontend/src/i18n/locales/en.ts (+5 -0)
📝 frontend/src/i18n/locales/fr.ts (+5 -0)
📝 frontend/src/i18n/locales/it.ts (+5 -0)
📝 frontend/src/i18n/locales/ja.ts (+5 -0)
📝 frontend/src/i18n/locales/pt-BR.ts (+5 -0)
📝 frontend/src/i18n/locales/zh-CN.ts (+5 -0)
📝 frontend/src/pages/SettingsPage.tsx (+54 -11)
📝 static/assets/index-BI_XE14_.js (+156 -156)
📝 static/index.html (+1 -1)

📄 Description

Description

This feature allows an Admin when User Authentication is enabled to set the default menu order based on how the Admin has the menu order configured.

  1. Admin customizes their own menu order.
  2. Admin uses the new 'Set Default' toggle within the Admin; General; Sidebar Order settings.
  3. New user's menu order updates to new default upon first login.
  4. User is allowed to re-configure menu afterwards as normal.

Fixes #586

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • New 'Set Default' button within the Admin; General; Sidebar Order settings.

Screenshots

2026-03-20_10-22-22

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: N/A

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/761 **Author:** [@cadtoolbox](https://github.com/cadtoolbox) **Created:** 3/20/2026 **Status:** ✅ Merged **Merged:** 3/21/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `dev` ← **Head:** `dev_menu_order` --- ### 📝 Commits (10+) - [`26a08da`](https://github.com/maziggy/bambuddy/commit/26a08daf60a8c7f3f446661340a39d492d398015) Added Feature - Admin lockable side navigation menu - [`6447360`](https://github.com/maziggy/bambuddy/commit/6447360b466825ad0a12f7cfb3a4235946e24729) Updates for lock/unlock workflow of nav menu. Changed button label. - [`d468af8`](https://github.com/maziggy/bambuddy/commit/d468af89c4c7a264c33f6788e08e10a7703de8b8) Removed need for menu order updates to require settings read permission - [`77a1ceb`](https://github.com/maziggy/bambuddy/commit/77a1cebdb123d9a1b57dc5da74e5faeb2153c34a) Change logic from lock/unlock to set default for menu order - [`b01c92b`](https://github.com/maziggy/bambuddy/commit/b01c92b91786fa31c0af2dcf1b43b5228a96cb0a) Cosmetic changes - [`d5cbd32`](https://github.com/maziggy/bambuddy/commit/d5cbd32582d1fe07c0d1ffbd888aad1ce9cd9323) Merge branch 'dev' into dev_menu_order - [`6163e38`](https://github.com/maziggy/bambuddy/commit/6163e383697c683103d41ca9081c30e8b5ac6c08) Merge branch 'dev' into dev_menu_order - [`79afd76`](https://github.com/maziggy/bambuddy/commit/79afd766300bd1f6f784b51006ed6a808ca8154e) Updates per PR#761 code review - [`7762b48`](https://github.com/maziggy/bambuddy/commit/7762b484ebc2353540db22704dc2a1261e82aeb5) Merge branch 'dev' into dev_menu_order - [`43101ee`](https://github.com/maziggy/bambuddy/commit/43101ee9ff990b0affc060f5331f16d5b220554e) Changed logic of 'Set Default' button for sidebar. Now applies to new users only. Fixed bugs. ### 📊 Changes **14 files changed** (+325 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/api/routes/settings.py` (+14 -0) 📝 `backend/app/schemas/settings.py` (+29 -1) 📝 `frontend/src/api/client.ts` (+3 -0) 📝 `frontend/src/components/Layout.tsx` (+33 -0) 📝 `frontend/src/i18n/locales/de.ts` (+5 -0) 📝 `frontend/src/i18n/locales/en.ts` (+5 -0) 📝 `frontend/src/i18n/locales/fr.ts` (+5 -0) 📝 `frontend/src/i18n/locales/it.ts` (+5 -0) 📝 `frontend/src/i18n/locales/ja.ts` (+5 -0) 📝 `frontend/src/i18n/locales/pt-BR.ts` (+5 -0) 📝 `frontend/src/i18n/locales/zh-CN.ts` (+5 -0) 📝 `frontend/src/pages/SettingsPage.tsx` (+54 -11) 📝 `static/assets/index-BI_XE14_.js` (+156 -156) 📝 `static/index.html` (+1 -1) </details> ### 📄 Description ## Description This feature allows an Admin when User Authentication is enabled to set the default menu order based on how the Admin has the menu order configured. 1. Admin customizes their own menu order. 2. Admin uses the new 'Set Default' toggle within the Admin; General; Sidebar Order settings. 3. New user's menu order updates to new default upon first login. 4. User is allowed to re-configure menu afterwards as normal. ## Related Issue <!-- Link to the issue this PR addresses (if applicable) --> Fixes #586 ## Type of Change <!-- Mark the relevant option with an "x" --> - [ ] Bug fix (non-breaking change that fixes an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made <!-- List the specific changes made in this PR --> - New 'Set Default' button within the Admin; General; Sidebar Order settings. ## Screenshots <!-- If applicable, add screenshots to demonstrate your changes --> ![2026-03-20_10-22-22](https://github.com/user-attachments/assets/e05da97e-d33c-4eec-b296-2b63ccb0d7fe) ## Testing <!-- Describe how you tested your changes --> - [X] I have tested this on my local machine - [X] I have tested with my printer model: N/A ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes <!-- Add any additional information that reviewers should know --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 00:16:05 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy-maziggy-1#1112
No description provided.