1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 08:25:54 +02:00

[PR #814] [MERGED] Spoolbuddy init and diagnostic improvements #1122

Closed
opened 2026-05-07 00:16:08 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/814
Author: @Keybored02
Created: 3/25/2026
Status: Merged
Merged: 3/26/2026
Merged by: @maziggy

Base: devHead: feature/spoolbuddy_fixes


📝 Commits (10+)

  • b39a507 Add stricter init sequence
  • 316abed Unify classes
  • a9f1681 Fix missing methods, add SPI self checks
  • c16b214 Fix import
  • 46d4ca4 Upgrade PN5180 registry dump
  • 3d1a49c Remove descriptors, add baudarate reg
  • 616810c Cleanup
  • 6df13b9 Merge branch 'dev' into feature/spoolbuddy_fixes
  • cb798d2 Fixes and updates
  • 73492b5 Add back missing scale diag details

📊 Changes

4 files changed (+319 additions, -419 deletions)

View changed files

📝 spoolbuddy/daemon/nau7802.py (+114 -35)
📝 spoolbuddy/daemon/pn5180.py (+12 -0)
📝 spoolbuddy/scripts/pn5180_diag.py (+127 -272)
📝 spoolbuddy/scripts/scale_diag.py (+66 -112)

📄 Description

Description

This pull request refactors and enhances the diagnostic scripts for the PN5180 NFC reader and NAU7802 scale.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • Refactored both scripts to use shared driver classes from the daemon directory, eliminating code duplication.
  • Added and decoded additional diagnostic registers (SIGPRO_CONFIG, TEMP_CONTROL, SYSTEM_STATUS) with human-readable output, including baudrate and temperature decoding.
  • Added self-tests for SPI device and GPIO pin accessibility.

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: H2C/ RPi 3B+

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/814 **Author:** [@Keybored02](https://github.com/Keybored02) **Created:** 3/25/2026 **Status:** ✅ Merged **Merged:** 3/26/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `dev` ← **Head:** `feature/spoolbuddy_fixes` --- ### 📝 Commits (10+) - [`b39a507`](https://github.com/maziggy/bambuddy/commit/b39a5078d2769b2d6a06326590df54cddcdd078e) Add stricter init sequence - [`316abed`](https://github.com/maziggy/bambuddy/commit/316abed827fa37aaf297c30b1f06bd561bdafb89) Unify classes - [`a9f1681`](https://github.com/maziggy/bambuddy/commit/a9f1681b592828964b9c353c9042a98f1b81a071) Fix missing methods, add SPI self checks - [`c16b214`](https://github.com/maziggy/bambuddy/commit/c16b21494b87c80e283ad85840615c986d6634c0) Fix import - [`46d4ca4`](https://github.com/maziggy/bambuddy/commit/46d4ca4f247295b7b315350551fc18b129e6cad3) Upgrade PN5180 registry dump - [`3d1a49c`](https://github.com/maziggy/bambuddy/commit/3d1a49cc440821351108a46614e9679177d05404) Remove descriptors, add baudarate reg - [`616810c`](https://github.com/maziggy/bambuddy/commit/616810c5653076176b18fbc43a244b3a19467545) Cleanup - [`6df13b9`](https://github.com/maziggy/bambuddy/commit/6df13b9f06ee69db5ee28277f2b5c6c393f69498) Merge branch 'dev' into feature/spoolbuddy_fixes - [`cb798d2`](https://github.com/maziggy/bambuddy/commit/cb798d20fae4fa7d79722798fdc83af66f7b2102) Fixes and updates - [`73492b5`](https://github.com/maziggy/bambuddy/commit/73492b5160c5a841fe9a1d3cd83e96baa8d2061e) Add back missing scale diag details ### 📊 Changes **4 files changed** (+319 additions, -419 deletions) <details> <summary>View changed files</summary> 📝 `spoolbuddy/daemon/nau7802.py` (+114 -35) 📝 `spoolbuddy/daemon/pn5180.py` (+12 -0) 📝 `spoolbuddy/scripts/pn5180_diag.py` (+127 -272) 📝 `spoolbuddy/scripts/scale_diag.py` (+66 -112) </details> ### 📄 Description ## Description This pull request refactors and enhances the diagnostic scripts for the PN5180 NFC reader and NAU7802 scale. ## Type of Change <!-- Mark the relevant option with an "x" --> - [x] Bug fix (non-breaking change that fixes an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made <!-- List the specific changes made in this PR --> - Refactored both scripts to use shared driver classes from the daemon directory, eliminating code duplication. - Added and decoded additional diagnostic registers (SIGPRO_CONFIG, TEMP_CONTROL, SYSTEM_STATUS) with human-readable output, including baudrate and temperature decoding. - Added self-tests for SPI device and GPIO pin accessibility. ## Testing <!-- Describe how you tested your changes --> - [ ] I have tested this on my local machine - [x] I have tested with my printer model: H2C/ RPi 3B+ ## Checklist - [x] My code follows the project's coding style - [x] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes <!-- Add any additional information that reviewers should know --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 00:16:08 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy-maziggy-1#1122
No description provided.