mirror of
https://github.com/maziggy/bambuddy.git
synced 2026-05-09 08:25:54 +02:00
[PR #958] [MERGED] feat: Shows vendor name in Spoolman Link Modal #1143
Labels
No labels
A1
automated
automated
bug
bug
Closed due to inactivity
contrib
dependencies
dependencies
duplicate
enhancement
feedback
hold
invalid
Notes
P1S
pull-request
security
ThumbsUp
user-report
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/bambuddy-maziggy-1#1143
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/maziggy/bambuddy/pull/958
Author: @shrunbr
Created: 4/13/2026
Status: ✅ Merged
Merged: 4/13/2026
Merged by: @maziggy
Base:
dev← Head:feature/spoolmanVendor📝 Commits (3)
6267b28Add filament_vendor field to UnlinkedSpool model and populate from API response2e7a614Add filament_vendor field to UnlinkedSpool interfaceee04d22Enhance LinkSpoolModal to include filament_vendor in search and display📊 Changes
3 files changed (+5 additions, -0 deletions)
View changed files
📝
backend/app/api/routes/spoolman.py(+2 -0)📝
frontend/src/api/client.ts(+1 -0)📝
frontend/src/components/LinkSpoolModal.tsx(+2 -0)📄 Description
Description
This pull request adds support for displaying and searching by filament vendor for unlinked spools throughout both the backend and frontend. The main changes update data models, API responses, UI display, and search functionality to include the new
filament_vendorfield.Related Issue
#926
Documentation
Pick one:
Type of Change
Changes Made
Backend changes:
filament_vendorfield to theUnlinkedSpooldata model inspoolman.pyto store the vendor name.get_unlinked_spoolsAPI endpoint to populate the newfilament_vendorfield from the filament data.Frontend changes:
UnlinkedSpoolTypeScript interface to include the newfilament_vendorfield.UI/UX improvements:
LinkSpoolModalto allow searching by filament vendor.LinkSpoolModalto show the filament vendor next to the material and spool ID.Screenshots
Testing
Checklist
Additional Notes
N/A
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.