1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 00:08:34 +02:00

[PR #1203] [FEAT] Printer page header update #1180

Open
opened 2026-05-07 00:16:29 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/1203
Author: @EdwardChamberlain
Created: 5/3/2026
Status: 🔄 Open

Base: devHead: feat-printer-page-header-update


📝 Commits (10+)

  • e1d6c68 add printers page icon to header
  • c17e49c align sort / filter controls and search
  • e9e9841 Enforce UI Element height consistency
  • 8aaea08 Enforce element consistency for bulk select button
  • 9d1693b move away from OS style checkbox.
  • 00aee43 move away from OS drop downs to bambuddy styled drop downs
  • ee0a8b9 update sort order button to match ui
  • 9cde761 Re-order elements into groups:
  • 3b00f1f reduce visual weight
  • 42bc6d6 update "subtitle" formatting to match queue page

📊 Changes

10 files changed (+419 additions, -181 deletions)

View changed files

📝 frontend/src/__tests__/pages/PrintersPage.test.tsx (+15 -12)
📝 frontend/src/i18n/locales/de.ts (+5 -0)
📝 frontend/src/i18n/locales/en.ts (+5 -0)
📝 frontend/src/i18n/locales/fr.ts (+5 -0)
📝 frontend/src/i18n/locales/it.ts (+5 -0)
📝 frontend/src/i18n/locales/ja.ts (+5 -0)
📝 frontend/src/i18n/locales/pt-BR.ts (+5 -0)
📝 frontend/src/i18n/locales/zh-CN.ts (+5 -0)
📝 frontend/src/i18n/locales/zh-TW.ts (+5 -0)
📝 frontend/src/pages/PrintersPage.tsx (+364 -169)

📄 Description

Description

Update to the printers page header to add element consistency and layout tightening.

Partial implementation as discussed in #1060

Documentation

Companion docs PRs (delete lines that don't apply):

Pick one:

  • Docs PR(s) linked above
  • No docs update required — reason: No functional change - only Element clean up

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring (UI Refactor)
  • Performance improvement
  • Test addition or update

Changes Made

  • Add printer icon to header
  • Align sort / filter controls with search
  • Enforce consistent UI element height and style
  • Use "Bambuddy styled" UI elements for drop down and check box instead of relying on variable system elements.
  • Reorder header elements into clear groups: Filter, View, Action
  • Match "subtitle" formatting to other pages
  • Implement collapsing for better consistency across UI widths

Screenshots

Full width Desktop:
image

Mobile:
image

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: P1S / H2S

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes

Tested against multiple screen widths.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/1203 **Author:** [@EdwardChamberlain](https://github.com/EdwardChamberlain) **Created:** 5/3/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `feat-printer-page-header-update` --- ### 📝 Commits (10+) - [`e1d6c68`](https://github.com/maziggy/bambuddy/commit/e1d6c689f22630d65237ce885d59c13a2eee8602) add printers page icon to header - [`c17e49c`](https://github.com/maziggy/bambuddy/commit/c17e49c90dc5c59fc347cd04968241d064f5af74) align sort / filter controls and search - [`e9e9841`](https://github.com/maziggy/bambuddy/commit/e9e9841349c18cf532d0dc73d9839eeca54db7ad) Enforce UI Element height consistency - [`8aaea08`](https://github.com/maziggy/bambuddy/commit/8aaea08e063ee050bf7f6e53a649c51a5ae71aa1) Enforce element consistency for bulk select button - [`9d1693b`](https://github.com/maziggy/bambuddy/commit/9d1693bd7169b66ae6331a9fb43ec14ecb61562a) move away from OS style checkbox. - [`00aee43`](https://github.com/maziggy/bambuddy/commit/00aee43a2d5913a0a175261c0ef94a9b0897af8f) move away from OS drop downs to bambuddy styled drop downs - [`ee0a8b9`](https://github.com/maziggy/bambuddy/commit/ee0a8b98cfa544a24915a41aa459cbb38a869cc3) update sort order button to match ui - [`9cde761`](https://github.com/maziggy/bambuddy/commit/9cde7610821e8a80a003e60d5ca4fd50ab57d440) Re-order elements into groups: - [`3b00f1f`](https://github.com/maziggy/bambuddy/commit/3b00f1f558a1de6a6ddac106eada77499a679778) reduce visual weight - [`42bc6d6`](https://github.com/maziggy/bambuddy/commit/42bc6d6d13dfe5384304cd47c7853f35e868ac00) update "subtitle" formatting to match queue page ### 📊 Changes **10 files changed** (+419 additions, -181 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/__tests__/pages/PrintersPage.test.tsx` (+15 -12) 📝 `frontend/src/i18n/locales/de.ts` (+5 -0) 📝 `frontend/src/i18n/locales/en.ts` (+5 -0) 📝 `frontend/src/i18n/locales/fr.ts` (+5 -0) 📝 `frontend/src/i18n/locales/it.ts` (+5 -0) 📝 `frontend/src/i18n/locales/ja.ts` (+5 -0) 📝 `frontend/src/i18n/locales/pt-BR.ts` (+5 -0) 📝 `frontend/src/i18n/locales/zh-CN.ts` (+5 -0) 📝 `frontend/src/i18n/locales/zh-TW.ts` (+5 -0) 📝 `frontend/src/pages/PrintersPage.tsx` (+364 -169) </details> ### 📄 Description ## Description Update to the printers page header to add element consistency and layout tightening. ## Related Issue Partial implementation as discussed in #1060 ## Documentation <!-- If this PR changes user-visible behavior, config keys, ports, CLI flags, URLs, or installation steps, link matching PRs in the docs repos below. Internal refactors, bug fixes with no observable change, and test-only changes are exempt — just check the "not required" box and say why. See CONTRIBUTING.md → Documentation Requirements for the full rules. --> **Companion docs PRs** (delete lines that don't apply): **Pick one**: - [ ] Docs PR(s) linked above - [X] No docs update required — reason: No functional change - only Element clean up ## Type of Change <!-- Mark the relevant option with an "x" --> - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [X] Code refactoring (UI Refactor) - [ ] Performance improvement - [ ] Test addition or update ## Changes Made <!-- List the specific changes made in this PR --> - Add printer icon to header - Align sort / filter controls with search - Enforce consistent UI element height and style - Use "Bambuddy styled" UI elements for drop down and check box instead of relying on variable system elements. - Reorder header elements into clear groups: Filter, View, Action - Match "subtitle" formatting to other pages - Implement collapsing for better consistency across UI widths ## Screenshots <!-- If applicable, add screenshots to demonstrate your changes --> Full width Desktop: <img width="1512" height="185" alt="image" src="https://github.com/user-attachments/assets/501980e5-581a-4411-8af3-cb9258aba378" /> Mobile: <img width="570" height="241" alt="image" src="https://github.com/user-attachments/assets/6cca07f7-313a-4476-82db-5e5d9b341ee5" /> ## Testing <!-- Describe how you tested your changes --> - [X] I have tested this on my local machine - [X] I have tested with my printer model: P1S / H2S ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes <!-- Add any additional information that reviewers should know --> Tested against multiple screen widths. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy-maziggy-1#1180
No description provided.