[PR #128] [MERGED] Fixed re-auth setup and gitignore node modules

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/128 **Author:** [@JesseFPV](https://github.com/JesseFPV) **Created:** 1/22/2026 **Status:** ✅ Merged **Merged:** 1/22/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.1.6b11` ← **Head:** `0.1.6b11` --- ### 📝 Commits (1) - [`3a84864`](https://github.com/maziggy/bambuddy/commit/3a848643c0c7df585bed1e5ed792d5da4ab87939) Fixed re-auth setup and gitignore node modules ### 📊 Changes **8 files changed** (+591 additions, -499 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `backend/app/api/routes/auth.py` (+72 -36) 📝 `frontend/src/App.tsx` (+3 -0) 📝 `frontend/src/contexts/AuthContext.tsx` (+24 -5) 📝 `frontend/src/pages/SettingsPage.tsx` (+5 -1) 📝 `frontend/src/pages/SetupPage.tsx` (+64 -37) 📝 `static/assets/index-7nHE42SH.js` (+419 -419) 📝 `static/index.html` (+1 -1) </details> ### 📄 Description ## Description This PR fixes authentication setup issues, particularly around re-enabling authentication and preventing redirect loops. It also adds `node_modules/` to `.gitignore` to prevent accidentally committing Node.js dependencies. ## Related Issue  Fixes # ## Type of Change  - [X] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made  - Added `setup_completed` status tracking to prevent infinite redirect loops when setup was already completed - Fixed authentication setup flow to allow re-enabling auth without requiring new admin user creation if admin users already exist - Improved redirect logic in `AuthContext` to prevent redirect loops and handle setup completion state properly - Added proper handling for when users navigate to `/setup` after authentication was already enabled - Added `node_modules/` to `.gitignore` to prevent committing Node.js dependencies - Updated `SetupPage` to refresh auth status after setup completion and handle cases where admin users already exist - Fixed button type in SettingsPage to prevent form submission when navigating to setup page ## Screenshots  ## Testing  - [X] I have tested this on my local machine - [ ] I have tested with my printer model:  **Test scenarios:** - Initial setup with authentication enabled (creates admin user) - Initial setup with authentication disabled - Re-enabling authentication when admin users already exist (should not require new admin creation) - Navigating to `/setup` after authentication is already enabled (should redirect to login) - Verifying no redirect loops occur when setup is completed ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes  - The `setup_completed` flag is now tracked in the database to distinguish between "auth not enabled" and "setup not completed yet" - This allows users to skip authentication during initial setup and enable it later without being forced into a redirect loop - The setup endpoint now intelligently checks if admin users exist before requiring admin credentials, making it easier to re-enable authentication --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware commented

2026-05-07 00:15:05 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/128
Author: @JesseFPV
Created: 1/22/2026
Status: ✅ Merged
Merged: 1/22/2026
Merged by: @maziggy

Base: 0.1.6b11 ← Head: 0.1.6b11

📝 Commits (1)

3a84864 Fixed re-auth setup and gitignore node modules

📊 Changes

8 files changed (+591 additions, -499 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 backend/app/api/routes/auth.py (+72 -36)
📝 frontend/src/App.tsx (+3 -0)
📝 frontend/src/contexts/AuthContext.tsx (+24 -5)
📝 frontend/src/pages/SettingsPage.tsx (+5 -1)
📝 frontend/src/pages/SetupPage.tsx (+64 -37)
📝 static/assets/index-7nHE42SH.js (+419 -419)
📝 static/index.html (+1 -1)

📄 Description

Description

This PR fixes authentication setup issues, particularly around re-enabling authentication and preventing redirect loops. It also adds node_modules/ to .gitignore to prevent accidentally committing Node.js dependencies.

Fixes #

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

Added setup_completed status tracking to prevent infinite redirect loops when setup was already completed
Fixed authentication setup flow to allow re-enabling auth without requiring new admin user creation if admin users already exist
Improved redirect logic in AuthContext to prevent redirect loops and handle setup completion state properly
Added proper handling for when users navigate to /setup after authentication was already enabled
Added node_modules/ to .gitignore to prevent committing Node.js dependencies
Updated SetupPage to refresh auth status after setup completion and handle cases where admin users already exist
Fixed button type in SettingsPage to prevent form submission when navigating to setup page

Screenshots

Testing

I have tested this on my local machine
I have tested with my printer model:

Test scenarios:

Initial setup with authentication enabled (creates admin user)
Initial setup with authentication disabled
Re-enabling authentication when admin users already exist (should not require new admin creation)
Navigating to /setup after authentication is already enabled (should redirect to login)
Verifying no redirect loops occur when setup is completed

Checklist

My code follows the project's coding style
I have commented my code where necessary
I have updated the documentation (if needed)
My changes generate no new warnings
I have tested my changes thoroughly

Additional Notes

The setup_completed flag is now tracked in the database to distinguish between "auth not enabled" and "setup not completed yet"
This allows users to skip authentication during initial setup and enable it later without being forced into a redirect loop
The setup endpoint now intelligently checks if admin users exist before requiring admin credentials, making it easier to re-enable authentication

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

BreizhHardware

closed this issue
added the
pull-request
label

BreizhHardware referenced this issue

2026-05-07 00:16:21 +02:00

[PR #1029] [MERGED] v0.2.3 final #1155

Rows
Columns

[PR #128] [MERGED] Fixed re-auth setup and gitignore node modules #941