[PR #202] [CLOSED] String Separation and Localization #965

New issue

Closed

opened 2026-05-07 00:15:13 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:15:13 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/202
Author: @nmori
Created: 1/31/2026
Status: ❌ Closed

Base: main ← Head: i18n_ja

📝 Commits (10+)

95e114f ・Separate embedded strings into resources
f6419c7 packed exe
9d6d026 ・Reflected Copilot suggestions
7c30d2b Merge branch 'main' of https://github.com/maziggy/bambuddy into i18n_exe
89100a0 add i18n
60eb15e ・Update repository updates
1323004 Fix conflicts
bc22414 Merge branch 'main' into i18n_ja
f7b06de Fixing Lint Check Failures
6e66cc0 Merge branch 'main' of https://github.com/maziggy/bambuddy into i18n_ja

📊 Changes

77 files changed (+19643 additions, -12219 deletions)

View changed files

➕ =2.8.0 (+5 -0)
➕ backend/.coverage (+0 -0)
📝 backend/app/core/config.py (+9 -1)
📝 backend/app/i18n/__init__.py (+33 -0)
📝 deploy/bambuddy.service (+18 -48)
📝 frontend/src/__tests__/components/PrintModal.test.tsx (+5 -5)
📝 frontend/src/__tests__/components/SmartPlugCard.test.tsx (+16 -101)
📝 frontend/src/__tests__/pages/ArchivesPage.test.tsx (+4 -42)
📝 frontend/src/__tests__/pages/SettingsPage.test.tsx (+2 -2)
📝 frontend/src/__tests__/pages/StatsPage.test.tsx (+15 -24)
📝 frontend/src/components/APIBrowser.tsx (+25 -22)
📝 frontend/src/components/AddExternalLinkModal.tsx (+19 -17)
📝 frontend/src/components/AddNotificationModal.tsx (+70 -76)
📝 frontend/src/components/AddSmartPlugModal.tsx (+97 -95)
📝 frontend/src/components/BackupModal.tsx (+33 -19)
📝 frontend/src/components/BatchProjectModal.tsx (+14 -12)
📝 frontend/src/components/BatchTagModal.tsx (+3 -1)
📝 frontend/src/components/CalendarView.tsx (+12 -8)
📝 frontend/src/components/ConfigureAmsSlotModal.tsx (+7 -5)
📝 frontend/src/components/Dashboard.tsx (+11 -8)

...and 57 more files

📄 Description

Description

・Localize the UI into Japanese
・Separate embedded resources during localization

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

・Separate embedded strings into resources
・Add Japanese localization

Screenshots

Testing

I have tested this on my local machine
I have tested with my printer model:
P1S、P2S

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/202 **Author:** [@nmori](https://github.com/nmori) **Created:** 1/31/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `i18n_ja` --- ### 📝 Commits (10+) - [`95e114f`](https://github.com/maziggy/bambuddy/commit/95e114f48981a3ab6ef96cf407567422e095d0d3) ・Separate embedded strings into resources - [`f6419c7`](https://github.com/maziggy/bambuddy/commit/f6419c70d041635edc25ea9279b01bd82e0f3061) packed exe - [`9d6d026`](https://github.com/maziggy/bambuddy/commit/9d6d026b88420c6c0dccdce80e715b9495a38a1c) ・Reflected Copilot suggestions - [`7c30d2b`](https://github.com/maziggy/bambuddy/commit/7c30d2bf45ee5039617d6921ed560ae08a28302a) Merge branch 'main' of https://github.com/maziggy/bambuddy into i18n_exe - [`89100a0`](https://github.com/maziggy/bambuddy/commit/89100a081a1d48f97bdc5cedd79da5200b970163) add i18n - [`60eb15e`](https://github.com/maziggy/bambuddy/commit/60eb15e3dabe3e3ec58c04c1b28b12d0c9929952) ・Update repository updates - [`1323004`](https://github.com/maziggy/bambuddy/commit/13230048fc75bbb6f82bd175233bd18343496b1f) Fix conflicts - [`bc22414`](https://github.com/maziggy/bambuddy/commit/bc224140236d7b1e3b9193f2576814d89cb36047) Merge branch 'main' into i18n_ja - [`f7b06de`](https://github.com/maziggy/bambuddy/commit/f7b06de790f70965fe6b600bd5c6bebe468bd740) Fixing Lint Check Failures - [`6e66cc0`](https://github.com/maziggy/bambuddy/commit/6e66cc0b4918f22acd4ba8cc31d7d74a56cd4ea9) Merge branch 'main' of https://github.com/maziggy/bambuddy into i18n_ja ### 📊 Changes **77 files changed** (+19643 additions, -12219 deletions) <details> <summary>View changed files</summary> ➕ `=2.8.0` (+5 -0) ➕ `backend/.coverage` (+0 -0) 📝 `backend/app/core/config.py` (+9 -1) 📝 `backend/app/i18n/__init__.py` (+33 -0) 📝 `deploy/bambuddy.service` (+18 -48) 📝 `frontend/src/__tests__/components/PrintModal.test.tsx` (+5 -5) 📝 `frontend/src/__tests__/components/SmartPlugCard.test.tsx` (+16 -101) 📝 `frontend/src/__tests__/pages/ArchivesPage.test.tsx` (+4 -42) 📝 `frontend/src/__tests__/pages/SettingsPage.test.tsx` (+2 -2) 📝 `frontend/src/__tests__/pages/StatsPage.test.tsx` (+15 -24) 📝 `frontend/src/components/APIBrowser.tsx` (+25 -22) 📝 `frontend/src/components/AddExternalLinkModal.tsx` (+19 -17) 📝 `frontend/src/components/AddNotificationModal.tsx` (+70 -76) 📝 `frontend/src/components/AddSmartPlugModal.tsx` (+97 -95) 📝 `frontend/src/components/BackupModal.tsx` (+33 -19) 📝 `frontend/src/components/BatchProjectModal.tsx` (+14 -12) 📝 `frontend/src/components/BatchTagModal.tsx` (+3 -1) 📝 `frontend/src/components/CalendarView.tsx` (+12 -8) 📝 `frontend/src/components/ConfigureAmsSlotModal.tsx` (+7 -5) 📝 `frontend/src/components/Dashboard.tsx` (+11 -8) _...and 57 more files_ </details> ### 📄 Description ## Description ・Localize the UI into Japanese ・Separate embedded resources during localization ## Type of Change - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [X] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [X] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made ・Separate embedded strings into resources ・Add Japanese localization ## Screenshots <img width="1056" height="634" alt="image" src="https://github.com/user-attachments/assets/addfc4c5-c062-48ff-b5c4-0bd0a5002eb1" /> ## Testing  - [X] I have tested this on my local machine - [X] I have tested with my printer model:  P1S、P2S --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>