[PR #289] [MERGED] Fix FTP download reporting success on 0-byte files #992

New issue

Closed

opened 2026-05-07 00:15:22 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:15:22 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/289
Author: @maziggy
Created: 2/7/2026
Status: ✅ Merged
Merged: 2/7/2026
Merged by: @maziggy

Base: main ← Head: 0.1.8.1

📝 Commits (2)

70e7cba Fix FTP download reporting success on 0-byte files
b27f198 Merge branch 'main' into 0.1.8.1

📊 Changes

2 files changed (+6 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 backend/app/services/bambu_ftp.py (+5 -0)

📄 Description

download_to_file() returned True when retrbinary transferred 0 bytes without raising an exception. This caused the /cover endpoint to hit the empty file check and raise HTTP 500 instead of retrying or returning 404.

Now treats 0-byte downloads as failures, allowing the cover endpoint's retry logic to work and falling back to 404 if all attempts fail.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/289 **Author:** [@maziggy](https://github.com/maziggy) **Created:** 2/7/2026 **Status:** ✅ Merged **Merged:** 2/7/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `main` ← **Head:** `0.1.8.1` --- ### 📝 Commits (2) - [`70e7cba`](https://github.com/maziggy/bambuddy/commit/70e7cba5e7dfaa8069e585e7dbb54a6410370e6b) Fix FTP download reporting success on 0-byte files - [`b27f198`](https://github.com/maziggy/bambuddy/commit/b27f198386a62c474f799cc6d2cb6829eef67c41) Merge branch 'main' into 0.1.8.1 ### 📊 Changes **2 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `backend/app/services/bambu_ftp.py` (+5 -0) </details> ### 📄 Description download_to_file() returned True when retrbinary transferred 0 bytes without raising an exception. This caused the /cover endpoint to hit the empty file check and raise HTTP 500 instead of retrying or returning 404. Now treats 0-byte downloads as failures, allowing the cover endpoint's retry logic to work and falling back to 404 if all attempts fail. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>