[PR #361] [MERGED] Add material mismatch check #1014

Closed
opened 2026-05-06 12:34:29 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/361
Author: @Keybored02
Created: 2/13/2026
Status: Merged
Merged: 2/15/2026
Merged by: @maziggy

Base: 0.2.0bHead: 0.2.0b


📝 Commits (10+)

📊 Changes

12 files changed (+277 additions, -13 deletions)

View changed files

📝 backend/app/api/routes/settings.py (+5 -0)
📝 backend/app/schemas/settings.py (+5 -0)
📝 frontend/src/api/client.ts (+5 -3)
📝 frontend/src/components/AssignSpoolModal.tsx (+53 -2)
📝 frontend/src/components/ConfirmModal.tsx (+2 -2)
📝 frontend/src/components/PrintModal/index.tsx (+127 -4)
📝 frontend/src/components/SpoolmanSettings.tsx (+26 -2)
📝 frontend/src/i18n/locales/de.ts (+9 -0)
📝 frontend/src/i18n/locales/en.ts (+9 -0)
📝 frontend/src/i18n/locales/fr.ts (+9 -0)
📝 frontend/src/i18n/locales/it.ts (+18 -0)
📝 frontend/src/i18n/locales/ja.ts (+9 -0)

📄 Description

Description

Add material mismatch check when assigning spools. This is implemented for non-BL spools only.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • Check spoolmaterial against traymaterial (only types, no colors)
  • Ask user for confirmation in case of mismatch with confirm modal
  • Updated locales

Screenshots

image

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: H2C

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/361 **Author:** [@Keybored02](https://github.com/Keybored02) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/15/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.2.0b` ← **Head:** `0.2.0b` --- ### 📝 Commits (10+) - [`51d3a92`](https://github.com/maziggy/bambuddy/commit/51d3a922637344eb4e46a4785d042fd3344a582b) Add material mismatch check - [`4588cae`](https://github.com/maziggy/bambuddy/commit/4588cae4aff44ef9e756818d32f817cb96e6f7d7) Merge branch '0.2.0b' of https://github.com/Keybored02/bambuddy into 0.2.0b - [`12e758e`](https://github.com/maziggy/bambuddy/commit/12e758e68ec1880325567b030621b7f9178c3a2b) Add insufficient filament warning - [`f8ba8d4`](https://github.com/maziggy/bambuddy/commit/f8ba8d4ef9bdfb906c2806029e6f945ecb08ed6e) Merge branch '0.2.0b' into 0.2.0b - [`33c4bd8`](https://github.com/maziggy/bambuddy/commit/33c4bd8f8450603b954af4839fff104520ff15a9) Fix spool assignments query, mismatch dialog premature closing, confirm modal black text, add missing de.ts, fr.ts, and ja.ts locales - [`4f59be4`](https://github.com/maziggy/bambuddy/commit/4f59be46c9f503adf1a68ece050f5dbccaf8344f) Merge branch '0.2.0b' of https://github.com/Keybored02/bambuddy into 0.2.0b - [`9fb0c59`](https://github.com/maziggy/bambuddy/commit/9fb0c59dbad6e547ec222202bc82927465a75c07) Merge branch '0.2.0b' into 0.2.0b - [`4820a0d`](https://github.com/maziggy/bambuddy/commit/4820a0df6f8a41c84285fdcb6ab5f8f0ab6a9d7e) Merge branch '0.2.0b' into 0.2.0b - [`5f2bb02`](https://github.com/maziggy/bambuddy/commit/5f2bb02ff99ae7aeb91c9d4f051e156a9635d393) Fix spelling errors in German localization - [`b7f9979`](https://github.com/maziggy/bambuddy/commit/b7f9979f57a1cea971ac0d02e328dfc9e1db8232) Merge branch '0.2.0b' into 0.2.0b ### 📊 Changes **12 files changed** (+277 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/api/routes/settings.py` (+5 -0) 📝 `backend/app/schemas/settings.py` (+5 -0) 📝 `frontend/src/api/client.ts` (+5 -3) 📝 `frontend/src/components/AssignSpoolModal.tsx` (+53 -2) 📝 `frontend/src/components/ConfirmModal.tsx` (+2 -2) 📝 `frontend/src/components/PrintModal/index.tsx` (+127 -4) 📝 `frontend/src/components/SpoolmanSettings.tsx` (+26 -2) 📝 `frontend/src/i18n/locales/de.ts` (+9 -0) 📝 `frontend/src/i18n/locales/en.ts` (+9 -0) 📝 `frontend/src/i18n/locales/fr.ts` (+9 -0) 📝 `frontend/src/i18n/locales/it.ts` (+18 -0) 📝 `frontend/src/i18n/locales/ja.ts` (+9 -0) </details> ### 📄 Description ## Description Add material mismatch check when assigning spools. This is implemented for non-BL spools only. ## Related Issue ## Type of Change <!-- Mark the relevant option with an "x" --> - [ ] Bug fix (non-breaking change that fixes an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made - Check spoolmaterial against traymaterial (only types, no colors) - Ask user for confirmation in case of mismatch with confirm modal - Updated locales ## Screenshots <img width="473" height="226" alt="image" src="https://github.com/user-attachments/assets/5ee142cd-5832-4b3b-b189-3f5562f35ca6" /> <!-- If applicable, add screenshots to demonstrate your changes --> ## Testing <!-- Describe how you tested your changes --> - [x] I have tested this on my local machine - [x] I have tested with my printer model: H2C ## Checklist - [x] My code follows the project's coding style - [x] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:34:29 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy#1014
No description provided.