[PR #388] [MERGED] Adding the option to include the ip tables route when installing via … #1021

Closed
opened 2026-05-06 12:34:31 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/388
Author: @wreuel
Created: 2/15/2026
Status: Merged
Merged: 2/19/2026
Merged by: @maziggy

Base: 0.2.1bHead: feature/addIpTablesOnDockerInstal


📝 Commits (9)

  • ac597e5 Adding the option to include the ip tables route when installing via docker-install.sh
  • ee1a012 Merge branch '0.2.0b' into feature/addIpTablesOnDockerInstal
  • 0d7cf0f Complying with PR
  • 9d9a2eb Merge branch '0.2.1b' into feature/addIpTablesOnDockerInstal
  • 17eb482 Merge branch '0.2.1b' into feature/addIpTablesOnDockerInstal
  • c879a78 Complying with PR
  • ca0fb0c Merge branch '0.2.1b' into feature/addIpTablesOnDockerInstal
  • a097bda Merge branch '0.2.1b' into feature/addIpTablesOnDockerInstal
  • 324c716 Fix indentation in iptables check

📊 Changes

1 file changed (+77 additions, -0 deletions)

View changed files

📝 install/docker-install.sh (+77 -0)

📄 Description

…docker-install.sh

Description

Added an option to do the IP Tables on the install

Fixes #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

Just added a call on the sh to create the IP Tables entry

Screenshots

Testing

  • I have tested this on my local machine
  • I have tested with my printer model:

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/388 **Author:** [@wreuel](https://github.com/wreuel) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/19/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.2.1b` ← **Head:** `feature/addIpTablesOnDockerInstal` --- ### 📝 Commits (9) - [`ac597e5`](https://github.com/maziggy/bambuddy/commit/ac597e5ff6e659dbc75c6148a7ad225b86ad52da) Adding the option to include the ip tables route when installing via docker-install.sh - [`ee1a012`](https://github.com/maziggy/bambuddy/commit/ee1a0125ee13974dccb9876249b993fa6183f917) Merge branch '0.2.0b' into feature/addIpTablesOnDockerInstal - [`0d7cf0f`](https://github.com/maziggy/bambuddy/commit/0d7cf0f227751f0db7d93e758b9addd3ecf4a2be) Complying with PR - [`9d9a2eb`](https://github.com/maziggy/bambuddy/commit/9d9a2eb90451cd5ab9d030b24cba53c17ed067d0) Merge branch '0.2.1b' into feature/addIpTablesOnDockerInstal - [`17eb482`](https://github.com/maziggy/bambuddy/commit/17eb48284990d1555d286286571682692d3b94ad) Merge branch '0.2.1b' into feature/addIpTablesOnDockerInstal - [`c879a78`](https://github.com/maziggy/bambuddy/commit/c879a787f666ea17ca625279745a4c37c8002e5e) Complying with PR - [`ca0fb0c`](https://github.com/maziggy/bambuddy/commit/ca0fb0cca0ef8aec6125cb87f92c792963220a1e) Merge branch '0.2.1b' into feature/addIpTablesOnDockerInstal - [`a097bda`](https://github.com/maziggy/bambuddy/commit/a097bda2a30b4884046823663804e41db04e536c) Merge branch '0.2.1b' into feature/addIpTablesOnDockerInstal - [`324c716`](https://github.com/maziggy/bambuddy/commit/324c71669272fb91f0e7f5174cba5090ef3179b9) Fix indentation in iptables check ### 📊 Changes **1 file changed** (+77 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `install/docker-install.sh` (+77 -0) </details> ### 📄 Description …docker-install.sh ## Description Added an option to do the IP Tables on the install Fixes # ## Type of Change - [ ] Bug fix (non-breaking change that fixes an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made Just added a call on the sh to create the IP Tables entry - - - ## Screenshots ## Testing <!-- Describe how you tested your changes --> - [ ] I have tested this on my local machine - [ ] I have tested with my printer model: <!-- e.g., X1C, P1S, A1 --> ## Checklist - [ ] My code follows the project's coding style - [X] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [ ] My changes generate no new warnings - [ ] I have tested my changes thoroughly ## Additional Notes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:34:31 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy#1021
No description provided.