starred/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 05:35:30 +02:00
Code Issues 41 Projects Packages Wiki Activity

[PR #455] [MERGED] Allow external materials/brands to be used when adding spool #1045

New issue
Closed
opened 2026-05-06 12:34:40 +02:00 by BreizhHardware · 0 comments
BreizhHardware commented 2026-05-06 12:34:40 +02:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/455
Author: @Keybored02
Created: 2/19/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @maziggy

Base: 0.2.1b2 ← Head: feature/material_catalog

📝 Commits (10+)

  • 97c5886 feat(spool-form): enhance brand and material selection in color section
  • 58af27f feat(spool-form): change input field behavoiur when deleting all chars, fix scroll menu theming
  • 6f27b08 feat(spool-form): add available materials to SpoolFormModal and FilamentSection
  • c94dc24 refactor(ColorSection): remove unnecessary hasCatalogMatch variable
  • 7b8590d feat(SpoolFormModal): add bilateral brand and material filtering logic
  • b270d13 feat(ColorCatalogSettings): improve input field sizes and layout for color and material selection
  • 16e4f69 Merge branch '0.2.1b' into feature/material_catalog
  • 67150b6 Merge branch '0.2.1b2' into feature/material_catalog
  • b91f102 Refactor colorCatalog settings and dependencies, allow custom materials, fix ml-12 marging, show catalog colors on brand/material selection
  • 382e6dc Merge branch '0.2.1b2' into feature/material_catalog

📊 Changes

12 files changed (+296 additions, -49 deletions)

View changed files

📝 frontend/src/components/ColorCatalogSettings.tsx (+12 -12)
📝 frontend/src/components/SpoolFormModal.tsx (+85 -5)
📝 frontend/src/components/spool-form/AdditionalSection.tsx (+23 -3)
📝 frontend/src/components/spool-form/ColorSection.tsx (+49 -14)
📝 frontend/src/components/spool-form/FilamentSection.tsx (+111 -15)
📝 frontend/src/components/spool-form/types.ts (+10 -0)
📝 frontend/src/i18n/locales/de.ts (+1 -0)
📝 frontend/src/i18n/locales/en.ts (+1 -0)
📝 frontend/src/i18n/locales/fr.ts (+1 -0)
📝 frontend/src/i18n/locales/it.ts (+1 -0)
📝 frontend/src/i18n/locales/ja.ts (+1 -0)
📝 frontend/src/i18n/locales/pt-BR.ts (+1 -0)

📄 Description

Description

This PR integrates the materials and brands fetched from the external database into the Add Spool form. It also allows for custom colors, brands and materials in Color Catalog to be included when adding a spool. It fixes a few minor UI inconsistencies and sizing issues.

Related Issue

Fixes #419

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • The Add spool modal now fetches from both the hard-coded list of materials/brands and the external database.
  • A bilateral filter kicks in when the user selects a brand or material, filtering the other options based on what is available in the pair (custom fields are still allowed).
  • Ui fixes:
    • Drop down menus are now unified in theme and scrollbar style
    • The add form for the Color Catalog has been reworked to enlarge the color selection button
    • When a numeric input field content is deleted it's no more populated with a 0 automatically

Screenshots

Screenshot 2026-02-17 210909 Screenshot 2026-02-17 210924 Screenshot 2026-02-18 155312 Screenshot 2026-02-18 155320

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: H2C

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/455 **Author:** [@Keybored02](https://github.com/Keybored02) **Created:** 2/19/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.2.1b2` ← **Head:** `feature/material_catalog` --- ### 📝 Commits (10+) - [`97c5886`](https://github.com/maziggy/bambuddy/commit/97c588699273b6bb51e587a23d558c3a699f0d99) feat(spool-form): enhance brand and material selection in color section - [`58af27f`](https://github.com/maziggy/bambuddy/commit/58af27f951383f8aa9ae27b38f9c3eff66448017) feat(spool-form): change input field behavoiur when deleting all chars, fix scroll menu theming - [`6f27b08`](https://github.com/maziggy/bambuddy/commit/6f27b08bd6027269f6b726421fb13bb32b1e1199) feat(spool-form): add available materials to SpoolFormModal and FilamentSection - [`c94dc24`](https://github.com/maziggy/bambuddy/commit/c94dc244c547730ff87032713a6f145cf1c9bb27) refactor(ColorSection): remove unnecessary hasCatalogMatch variable - [`7b8590d`](https://github.com/maziggy/bambuddy/commit/7b8590dc5735be97d0d9729db1d267ec19b1559c) feat(SpoolFormModal): add bilateral brand and material filtering logic - [`b270d13`](https://github.com/maziggy/bambuddy/commit/b270d13f1ade6633ace2424a7c79ed6d2099161c) feat(ColorCatalogSettings): improve input field sizes and layout for color and material selection - [`16e4f69`](https://github.com/maziggy/bambuddy/commit/16e4f69199987b566b20de63339602280354dfac) Merge branch '0.2.1b' into feature/material_catalog - [`67150b6`](https://github.com/maziggy/bambuddy/commit/67150b6e257e947898679c092bf1a9a7fb83981d) Merge branch '0.2.1b2' into feature/material_catalog - [`b91f102`](https://github.com/maziggy/bambuddy/commit/b91f102a9bddc5c238d6f2bfb77502d59119ec54) Refactor colorCatalog settings and dependencies, allow custom materials, fix ml-12 marging, show catalog colors on brand/material selection - [`382e6dc`](https://github.com/maziggy/bambuddy/commit/382e6dcf4deecb8c02448dadfee673d5c5daa5b1) Merge branch '0.2.1b2' into feature/material_catalog ### 📊 Changes **12 files changed** (+296 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/ColorCatalogSettings.tsx` (+12 -12) 📝 `frontend/src/components/SpoolFormModal.tsx` (+85 -5) 📝 `frontend/src/components/spool-form/AdditionalSection.tsx` (+23 -3) 📝 `frontend/src/components/spool-form/ColorSection.tsx` (+49 -14) 📝 `frontend/src/components/spool-form/FilamentSection.tsx` (+111 -15) 📝 `frontend/src/components/spool-form/types.ts` (+10 -0) 📝 `frontend/src/i18n/locales/de.ts` (+1 -0) 📝 `frontend/src/i18n/locales/en.ts` (+1 -0) 📝 `frontend/src/i18n/locales/fr.ts` (+1 -0) 📝 `frontend/src/i18n/locales/it.ts` (+1 -0) 📝 `frontend/src/i18n/locales/ja.ts` (+1 -0) 📝 `frontend/src/i18n/locales/pt-BR.ts` (+1 -0) </details> ### 📄 Description ## Description This PR integrates the materials and brands fetched from the external database into the Add Spool form. It also allows for custom colors, brands and materials in Color Catalog to be included when adding a spool. It fixes a few minor UI inconsistencies and sizing issues. ## Related Issue <!-- Link to the issue this PR addresses (if applicable) --> Fixes #419 ## Type of Change <!-- Mark the relevant option with an "x" --> - [x] Bug fix (non-breaking change that fixes an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made - The Add spool modal now fetches from both the hard-coded list of materials/brands and the external database. - A bilateral filter kicks in when the user selects a brand or material, filtering the other options based on what is available in the pair (custom fields are still allowed). - Ui fixes: - Drop down menus are now unified in theme and scrollbar style - The add form for the Color Catalog has been reworked to enlarge the color selection button - When a numeric input field content is deleted it's no more populated with a 0 automatically ## Screenshots <img width="433" height="84" alt="Screenshot 2026-02-17 210909" src="https://github.com/user-attachments/assets/9c3561fb-c325-456c-a44c-4c4dd36b5785" /> <img width="439" height="77" alt="Screenshot 2026-02-17 210924" src="https://github.com/user-attachments/assets/c547dddb-03b9-4bc3-abeb-254ffacea2bf" /> <img width="1009" height="119" alt="Screenshot 2026-02-18 155312" src="https://github.com/user-attachments/assets/da6fc4bf-f908-46ad-aeaa-b0bf239a1cd7" /> <img width="1007" height="133" alt="Screenshot 2026-02-18 155320" src="https://github.com/user-attachments/assets/bc4397c5-6737-4aa4-a08c-3c2a03485232" /> ## Testing <!-- Describe how you tested your changes --> - [x] I have tested this on my local machine - [x] I have tested with my printer model: H2C ## Checklist - [x] My code follows the project's coding style - [x] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:34:40 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
github-repo-stats
bug-report-assets
dev
0.2.4b3
0.2.4b2
0.2.4b1
pr/1114
0.2.3.2
0.2.3.1
0.2.3
0.2.3b3
0.2.3b2
0.2.3b1
0.2.2.2
0.2.2.1
0.2.2b3
0.2.2
0.2.2b2
0.2.2b1
0.2.1.1
0.2.1
0.2.1b3
0.2.1b2
0.2.1b
0.2.0
0.2.0b
0.1.5-2-ctrl
v0.2.4b4-daily.20260508
v0.2.4b2
v0.2.4b3
v0.2.4b1
v0.2.3.2
v0.2.3.1
v0.2.3
v0.2.3b3
v0.2.3b2
v0.2.3b1-daily.20260407
v0.2.3b1
v0.2.2.2
v0.2.2.1
v0.2.3b1-daily.20260318
v0.2.3b1-daily.20260317
v0.2.3b1-daily.20260316
v0.2.2
v0.2.2b4-daily.20260314
v0.2.2b4-daily.20260313
v0.2.2b3-daily.20260312
v0.2.2b3-1
v0.2.2b2
v0.2.2-b2
v0.2.2b3
v0.2.2-b1
v0.2.2b1
v0.2.1.1
v0.2.1
v0.2.1b3
v0.2.1b2
v0.2.1b
v0.2.0
v0.1.9
v0.1.8.1
v0.1.8
v0.1.7
v0.1.6.2
v0.1.6.1
v0.1.6-hotfix
v0.1.6
v0.1.6b11
v0.1.6b10
v0.1.6b9
v0.1.6b8
v0.1.6b7
v0.1.6b6
v0.1.6b5
v0.1.6b4
v0.1.6b3
v0.1.6b2
v0.1.6b
v0.1.5-final
v0.1.5b7
v0.1.5b6
v0.1.5b5
v0.1.5b4
v0.1.5b3
v0.1.5b2
v0.1.5b
v0.1.4
v0.1.3
v0.1.2-bugfix
v0.1.2-final
v0.1.2
0.1.1
Labels
Clear labels   
A1

   
automated

   
automated

   
bug

   
bug

   
Closed due to inactivity

   
contrib

   
dependencies

   
dependencies

   
duplicate

   
enhancement

   
feedback

   
hold

   
invalid

   
Notes

   
P1S

   
pull-request
Mirrored from GitHub Pull Request

  
security

   
security

   
ThumbsUp

   
user-report

   
wontfix
No labels
A1
automated
automated
bug
bug
Closed due to inactivity
contrib
dependencies
dependencies
duplicate
enhancement
feedback
hold
invalid
Notes
P1S
pull-request
security
security
ThumbsUp
user-report
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy#1045
No description provided.