starred/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 05:35:30 +02:00
Code Issues 41 Projects Packages Wiki Activity

[PR #502] [CLOSED] Add material mismatch and insufficient filament checks #1054

New issue
Closed
opened 2026-05-06 12:34:43 +02:00 by BreizhHardware · 0 comments
BreizhHardware commented 2026-05-06 12:34:43 +02:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/502
Author: @Keybored02
Created: 2/23/2026
Status: ❌ Closed

Base: 0.2.2b1 ← Head: feature/material_mismatch

📝 Commits (10+)

  • 559d8dd feat(queue): show spool grams left in filament slot mapping
  • a55f5e2 Bumped version
  • a4a4316 Add SpoolBuddy AMS slot config, external slots, and dashboard redesign
  • 13ab050 Fix SpoolBuddy daemon crash when read_tag module is missing
  • 81c1267 Fix SpoolBuddy daemon failing to import hardware drivers
  • 3c68b19 Increase scale moving average window to reduce weight bouncing
  • 549fdef Remove stability flipping as scale report trigger
  • 36e3669 Fix formatting of option elements in FilamentMapping
  • 246457b Add material mismatch check
  • 704f8d1 Add insufficient filament warning

📊 Changes

24 files changed (+9431 additions, -317 deletions)

View changed files

📝 CHANGELOG.md (+11 -14)
📝 backend/app/api/routes/settings.py (+5 -0)
📝 backend/app/schemas/settings.py (+5 -0)
📝 frontend/src/api/client.ts (+5 -3)
📝 frontend/src/components/AssignSpoolModal.tsx (+264 -128)
📝 frontend/src/components/ConfirmModal.tsx (+2 -2)
📝 frontend/src/components/PrintModal/index.tsx (+132 -8)
📝 frontend/src/components/SpoolmanSettings.tsx (+26 -2)
📝 frontend/src/components/spoolbuddy/AmsUnitCard.tsx (+9 -12)
📝 frontend/src/components/spoolbuddy/SpoolBuddyTopBar.tsx (+1 -6)
📝 frontend/src/i18n/locales/de.ts (+11 -0)
📝 frontend/src/i18n/locales/en.ts (+11 -0)
📝 frontend/src/i18n/locales/fr.ts (+11 -0)
📝 frontend/src/i18n/locales/it.ts (+20 -0)
📝 frontend/src/i18n/locales/ja.ts (+11 -0)
📝 frontend/src/i18n/locales/pt-BR.ts (+11 -0)
📝 frontend/src/pages/PrintersPage.tsx (+7 -4)
📝 frontend/src/pages/spoolbuddy/SpoolBuddyAmsPage.tsx (+99 -55)
📝 frontend/src/pages/spoolbuddy/SpoolBuddyDashboard.tsx (+91 -48)
📝 spoolbuddy/daemon/main.py (+3 -1)

...and 4 more files

📄 Description

Description

Add material mismatch check when assigning non-BL spools. The warning can be dismissed. Addedchecks prior to printing for insufficient filament on the spool. This is a re-merge of #361 for branch 0.2.1b4

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • Check spoolmaterial against traymaterial (only types, no colors)
  • Ask user for confirmation in case of mismatch with confirm modal
  • Added checks for insufficient material to PrintModal
  • Added toggle in Setting, Filament to disable insufficiency warning
  • Updated locales

Screenshots

image image

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: H2C

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/502 **Author:** [@Keybored02](https://github.com/Keybored02) **Created:** 2/23/2026 **Status:** ❌ Closed **Base:** `0.2.2b1` ← **Head:** `feature/material_mismatch` --- ### 📝 Commits (10+) - [`559d8dd`](https://github.com/maziggy/bambuddy/commit/559d8dd09df35f1b44cbe35f5d6d0051523a7115) feat(queue): show spool grams left in filament slot mapping - [`a55f5e2`](https://github.com/maziggy/bambuddy/commit/a55f5e2a85c4d70c16ffd93ef3eeacc78ef115b5) Bumped version - [`a4a4316`](https://github.com/maziggy/bambuddy/commit/a4a4316601762cc55108df0a3195a6bd276cb161) Add SpoolBuddy AMS slot config, external slots, and dashboard redesign - [`13ab050`](https://github.com/maziggy/bambuddy/commit/13ab050b24e15e199e46bc778865d9a3917074d2) Fix SpoolBuddy daemon crash when read_tag module is missing - [`81c1267`](https://github.com/maziggy/bambuddy/commit/81c126735322d47001d4d48e7b9b22f51f68ae54) Fix SpoolBuddy daemon failing to import hardware drivers - [`3c68b19`](https://github.com/maziggy/bambuddy/commit/3c68b1932526254dff280ded575aa6082b44dee5) Increase scale moving average window to reduce weight bouncing - [`549fdef`](https://github.com/maziggy/bambuddy/commit/549fdef8326e6a5592c9200ee5aaf0c0ef8a8779) Remove stability flipping as scale report trigger - [`36e3669`](https://github.com/maziggy/bambuddy/commit/36e366952c13604e7ef3491b9fb3880f9fb4f04f) Fix formatting of option elements in FilamentMapping - [`246457b`](https://github.com/maziggy/bambuddy/commit/246457be054d5e26ceeb53ae2c576fe9e15bf333) Add material mismatch check - [`704f8d1`](https://github.com/maziggy/bambuddy/commit/704f8d11d6ba2e08b3f78a4189e0336a607228d2) Add insufficient filament warning ### 📊 Changes **24 files changed** (+9431 additions, -317 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+11 -14) 📝 `backend/app/api/routes/settings.py` (+5 -0) 📝 `backend/app/schemas/settings.py` (+5 -0) 📝 `frontend/src/api/client.ts` (+5 -3) 📝 `frontend/src/components/AssignSpoolModal.tsx` (+264 -128) 📝 `frontend/src/components/ConfirmModal.tsx` (+2 -2) 📝 `frontend/src/components/PrintModal/index.tsx` (+132 -8) 📝 `frontend/src/components/SpoolmanSettings.tsx` (+26 -2) 📝 `frontend/src/components/spoolbuddy/AmsUnitCard.tsx` (+9 -12) 📝 `frontend/src/components/spoolbuddy/SpoolBuddyTopBar.tsx` (+1 -6) 📝 `frontend/src/i18n/locales/de.ts` (+11 -0) 📝 `frontend/src/i18n/locales/en.ts` (+11 -0) 📝 `frontend/src/i18n/locales/fr.ts` (+11 -0) 📝 `frontend/src/i18n/locales/it.ts` (+20 -0) 📝 `frontend/src/i18n/locales/ja.ts` (+11 -0) 📝 `frontend/src/i18n/locales/pt-BR.ts` (+11 -0) 📝 `frontend/src/pages/PrintersPage.tsx` (+7 -4) 📝 `frontend/src/pages/spoolbuddy/SpoolBuddyAmsPage.tsx` (+99 -55) 📝 `frontend/src/pages/spoolbuddy/SpoolBuddyDashboard.tsx` (+91 -48) 📝 `spoolbuddy/daemon/main.py` (+3 -1) _...and 4 more files_ </details> ### 📄 Description ## Description Add material mismatch check when assigning non-BL spools. The warning can be dismissed. Addedchecks prior to printing for insufficient filament on the spool. This is a re-merge of #361 for branch 0.2.1b4 ## Related Issue ## Type of Change <!-- Mark the relevant option with an "x" --> - [ ] Bug fix (non-breaking change that fixes an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made - Check spoolmaterial against traymaterial (only types, no colors) - Ask user for confirmation in case of mismatch with confirm modal - Added checks for insufficient material to PrintModal - Added toggle in Setting, Filament to disable insufficiency warning - Updated locales ## Screenshots <img width="473" height="226" alt="image" src="https://github.com/user-attachments/assets/5ee142cd-5832-4b3b-b189-3f5562f35ca6" /> <img width="533" height="532" alt="image" src="https://github.com/user-attachments/assets/f22a3a1f-b492-4d89-b5ef-ca39fc92bb18" /> <!-- If applicable, add screenshots to demonstrate your changes --> ## Testing <!-- Describe how you tested your changes --> - [x] I have tested this on my local machine - [x] I have tested with my printer model: H2C ## Checklist - [x] My code follows the project's coding style - [x] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:34:43 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
github-repo-stats
bug-report-assets
dev
0.2.4b3
0.2.4b2
0.2.4b1
pr/1114
0.2.3.2
0.2.3.1
0.2.3
0.2.3b3
0.2.3b2
0.2.3b1
0.2.2.2
0.2.2.1
0.2.2b3
0.2.2
0.2.2b2
0.2.2b1
0.2.1.1
0.2.1
0.2.1b3
0.2.1b2
0.2.1b
0.2.0
0.2.0b
0.1.5-2-ctrl
v0.2.4b4-daily.20260508
v0.2.4b2
v0.2.4b3
v0.2.4b1
v0.2.3.2
v0.2.3.1
v0.2.3
v0.2.3b3
v0.2.3b2
v0.2.3b1-daily.20260407
v0.2.3b1
v0.2.2.2
v0.2.2.1
v0.2.3b1-daily.20260318
v0.2.3b1-daily.20260317
v0.2.3b1-daily.20260316
v0.2.2
v0.2.2b4-daily.20260314
v0.2.2b4-daily.20260313
v0.2.2b3-daily.20260312
v0.2.2b3-1
v0.2.2b2
v0.2.2-b2
v0.2.2b3
v0.2.2-b1
v0.2.2b1
v0.2.1.1
v0.2.1
v0.2.1b3
v0.2.1b2
v0.2.1b
v0.2.0
v0.1.9
v0.1.8.1
v0.1.8
v0.1.7
v0.1.6.2
v0.1.6.1
v0.1.6-hotfix
v0.1.6
v0.1.6b11
v0.1.6b10
v0.1.6b9
v0.1.6b8
v0.1.6b7
v0.1.6b6
v0.1.6b5
v0.1.6b4
v0.1.6b3
v0.1.6b2
v0.1.6b
v0.1.5-final
v0.1.5b7
v0.1.5b6
v0.1.5b5
v0.1.5b4
v0.1.5b3
v0.1.5b2
v0.1.5b
v0.1.4
v0.1.3
v0.1.2-bugfix
v0.1.2-final
v0.1.2
0.1.1
Labels
Clear labels   
A1

   
automated

   
automated

   
bug

   
bug

   
Closed due to inactivity

   
contrib

   
dependencies

   
dependencies

   
duplicate

   
enhancement

   
feedback

   
hold

   
invalid

   
Notes

   
P1S

   
pull-request
Mirrored from GitHub Pull Request

  
security

   
security

   
ThumbsUp

   
user-report

   
wontfix
No labels
A1
automated
automated
bug
bug
Closed due to inactivity
contrib
dependencies
dependencies
duplicate
enhancement
feedback
hold
invalid
Notes
P1S
pull-request
security
security
ThumbsUp
user-report
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy#1054
No description provided.