[PR #750] [MERGED] Improve Home Assistant notifications #1105

Closed
opened 2026-05-06 12:35:04 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/750
Author: @mrtncode
Created: 3/18/2026
Status: Merged
Merged: 3/20/2026
Merged by: @maziggy

Base: devHead: feature/homeassistant-notifications


📝 Commits (7)

  • be99b4f Improve home assistant notifications
  • 633cc81 Merge branch 'dev' into feature/homeassistant-notifications
  • ddde133 fix review suggestions
  • bb691ef Merge branch 'feature/homeassistant-notifications' of https://github.com/mrtncode/bambuddy into feature/homeassistant-notifications
  • 2fc0c0e Merge branch 'dev' into feature/homeassistant-notifications
  • ef4b29b Update docstring for _send_homeassistant method
  • be40a94 Merge branch 'dev' into feature/homeassistant-notifications

📊 Changes

2 files changed (+35 additions, -5 deletions)

View changed files

📝 backend/app/services/notification_service.py (+32 -4)
📝 frontend/src/components/AddNotificationModal.tsx (+3 -1)

📄 Description

Description

Here again ☺️

Fixes #656

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • Add Home Assistant notify services for notifications
  • Adjust frontend -> Add input field

Screenshots

Testing

  • I have tested this on my local machine
  • I have tested with my printer model:

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes

Two things :)

  1. I dont know if the frontend should be built by me.. I have built the frontend, if that shouldnt be, we can just revert the last commit.
  2. You mentioned in the last PR that I should use i18n keys. But the only frontend change is in AddNotificationsModal.tsx. The other input fields have hardcoded strings (not t('...') keys)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/750 **Author:** [@mrtncode](https://github.com/mrtncode) **Created:** 3/18/2026 **Status:** ✅ Merged **Merged:** 3/20/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `dev` ← **Head:** `feature/homeassistant-notifications` --- ### 📝 Commits (7) - [`be99b4f`](https://github.com/maziggy/bambuddy/commit/be99b4f9acb6be3a4bfaeb663e2410a6008737a5) Improve home assistant notifications - [`633cc81`](https://github.com/maziggy/bambuddy/commit/633cc8107ae0d45317a5bd983bf9da29cff59103) Merge branch 'dev' into feature/homeassistant-notifications - [`ddde133`](https://github.com/maziggy/bambuddy/commit/ddde1338da4513dc7083424f56369849cc0f1328) fix review suggestions - [`bb691ef`](https://github.com/maziggy/bambuddy/commit/bb691ef9d859851931ab68aa787c6857f0fe6296) Merge branch 'feature/homeassistant-notifications' of https://github.com/mrtncode/bambuddy into feature/homeassistant-notifications - [`2fc0c0e`](https://github.com/maziggy/bambuddy/commit/2fc0c0ed8d4c0420a3a7b6c963d75c5974764b8e) Merge branch 'dev' into feature/homeassistant-notifications - [`ef4b29b`](https://github.com/maziggy/bambuddy/commit/ef4b29b29f83246fd5b372fcab5954a5501a08ea) Update docstring for _send_homeassistant method - [`be40a94`](https://github.com/maziggy/bambuddy/commit/be40a948255e88ea2c8d92d236701da7724cea0d) Merge branch 'dev' into feature/homeassistant-notifications ### 📊 Changes **2 files changed** (+35 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/services/notification_service.py` (+32 -4) 📝 `frontend/src/components/AddNotificationModal.tsx` (+3 -1) </details> ### 📄 Description ## Description Here again ☺️ <!-- Provide a brief description of your changes --> ## Related Issue <!-- Link to the issue this PR addresses (if applicable) --> Fixes #656 ## Type of Change <!-- Mark the relevant option with an "x" --> - [ ] Bug fix (non-breaking change that fixes an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made <!-- List the specific changes made in this PR --> - Add Home Assistant notify services for notifications - Adjust frontend -> Add input field - ## Screenshots <!-- If applicable, add screenshots to demonstrate your changes --> ## Testing <!-- Describe how you tested your changes --> - [X] I have tested this on my local machine - [ ] I have tested with my printer model: <!-- e.g., X1C, P1S, A1 --> ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes <!-- Add any additional information that reviewers should know --> Two things :) 1. I dont know if the frontend should be built by me.. I have built the frontend, if that shouldnt be, we can just revert the last commit. 2. You mentioned in the last PR that I should use i18n keys. But the only frontend change is in AddNotificationsModal.tsx. The other input fields have hardcoded strings (not t('...') keys) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:35:04 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy#1105
No description provided.