[PR #749] [CLOSED] Add more Home Assistant notification options #1107

Closed
opened 2026-05-06 12:35:05 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/749
Author: @mrtncode
Created: 3/18/2026
Status: Closed

Base: mainHead: main


📝 Commits (2)

📊 Changes

5 files changed (+280 additions, -228 deletions)

View changed files

📝 backend/app/schemas/notification.py (+14 -0)
📝 backend/app/services/notification_service.py (+31 -1)
📝 frontend/src/components/AddNotificationModal.tsx (+9 -1)
📝 static/assets/index-BVSYf89u.js (+180 -180)
📝 static/index.html (+46 -46)

📄 Description

Description

Fixes #656

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • Add notify options in the backend
  • Frontend adjustments to support an input field for the notify id

Screenshots

Testing

  • I have tested this on my local machine
  • I have tested with my printer model:

I have tested this with my home assistant instance :)

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/749 **Author:** [@mrtncode](https://github.com/mrtncode) **Created:** 3/18/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`957634e`](https://github.com/maziggy/bambuddy/commit/957634eb921188e8738f46a51ee03634b9fd0c58) add home assistant notify options - [`8d7e0bd`](https://github.com/maziggy/bambuddy/commit/8d7e0bdc9669936ca961ac8488604be4394858e4) build frontend ### 📊 Changes **5 files changed** (+280 additions, -228 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/schemas/notification.py` (+14 -0) 📝 `backend/app/services/notification_service.py` (+31 -1) 📝 `frontend/src/components/AddNotificationModal.tsx` (+9 -1) 📝 `static/assets/index-BVSYf89u.js` (+180 -180) 📝 `static/index.html` (+46 -46) </details> ### 📄 Description ## Description <!-- Provide a brief description of your changes --> ## Related Issue <!-- Link to the issue this PR addresses (if applicable) --> Fixes #656 ## Type of Change <!-- Mark the relevant option with an "x" --> - [ ] Bug fix (non-breaking change that fixes an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made <!-- List the specific changes made in this PR --> - Add notify options in the backend - Frontend adjustments to support an input field for the notify id ## Screenshots <!-- If applicable, add screenshots to demonstrate your changes --> ## Testing <!-- Describe how you tested your changes --> - [X] I have tested this on my local machine - [ ] I have tested with my printer model: <!-- e.g., X1C, P1S, A1 --> I have tested this with my home assistant instance :) ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes <!-- Add any additional information that reviewers should know --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:35:05 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy#1107
No description provided.