starred/bambuddy

Fork

You've already forked bambuddy

mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 05:35:30 +02:00

Code Issues 41 Projects Packages Wiki Activity

[PR #939] [MERGED] Enhance plate-clear tracking and visibility in printer cards #1135

New issue

Closed

opened 2026-05-06 12:35:16 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:35:16 +02:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/939
Author: @EdwardChamberlain
Created: 4/10/2026
Status: ✅ Merged
Merged: 4/19/2026
Merged by: @maziggy

Base: dev ← Head: feature/enhance-plate-clear-tracking-and-visibility

📝 Commits (5)

d5fcb5f implement plate clear button, add plate status indicator, enable hide on setting change
8330f33 added plate cleared icon
4fa546f added smaller plate cleared button on "small" printers view
88f49c4 tighten layout slightly
c1a23fd fix(printers): restore plate-clear card controls

📊 Changes

12 files changed (+398 additions, -16 deletions)

View changed files

📝 frontend/src/__tests__/pages/PrintersPage.test.tsx (+195 -0)
➕ frontend/src/components/icons/PlateClearedIcon.tsx (+51 -0)
📝 frontend/src/i18n/locales/de.ts (+7 -1)
📝 frontend/src/i18n/locales/en.ts (+7 -1)
📝 frontend/src/i18n/locales/fr.ts (+7 -1)
📝 frontend/src/i18n/locales/it.ts (+7 -1)
📝 frontend/src/i18n/locales/ja.ts (+7 -1)
📝 frontend/src/i18n/locales/pt-BR.ts (+7 -1)
📝 frontend/src/i18n/locales/zh-CN.ts (+7 -1)
📝 frontend/src/i18n/locales/zh-TW.ts (+7 -1)
📝 frontend/src/pages/PrintersPage.tsx (+95 -7)
📝 frontend/src/pages/SettingsPage.tsx (+1 -1)

📄 Description

Description

This PR improves the printer card workflow around plate-clear confirmation so the existing plate_cleared flag is visible and actionable directly in the main printer UI, without relying on the queue-specific flow.

Previously, the web UI only exposed a per-printer plate-clear action widget when a compatible queued job was waiting. As a result, a finished printer with no waiting queue item had no normal card-level way to be marked as cleared, even though the backend already supported that state through the existing API.

This change adds plate-clear visibility and control directly to printer cards, while keeping behaviour aligned with the existing scheduler semantics and workflow setting.

Related Issue

Fixes #935

Documentation

Companion docs PRs (delete lines that don't apply):
Pick one:

Docs PR(s) linked above
No docs update required — reason: UI behaviour changed, but no standalone documentation update is needed for this change

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

Added a plate status badge to printer cards showing "Plate Cleared", "Plate in use", "Plate Not Cleared"
Added a Mark plate as cleared button to printer cards visible when not printing and uncleared.
Require plate-clear confirmation button hides both indicator and button for those not interested.
Updated the Require plate-clear confirmation setting description to clarify that disabling plate-clear confirmation also hides the plate status badge and card button
Added and updated frontend tests to cover the new printer card behaviour

Screenshots

Testing

I have tested this on my local machine
I have tested with my printer model: P1S

All tests passed locally.

Checklist

My code follows the project's coding style
I have commented my code where necessary
My changes generate no new warnings
I have tested my changes thoroughly

Additional Notes

Behaviour when Require plate-clear confirmation is enabled:

RUNNING / PAUSE printers show Plate in Use
FINISH / FAILED printers with plate_cleared = false show Plate not Clear
FINISH / FAILED printers with plate_cleared = true show Plate Clear
The Mark plate as cleared button appears only for connected FINISH / FAILED printers where plate_cleared = false

Behaviour when Require plate-clear confirmation is disabled:

The plate status badge is hidden
The Mark plate as cleared button is hidden
Scheduler behaviour remains unchanged and does not rely on the flag for FINISH / FAILED printers

The existing bulk clear-plate action is intentionally left untouched but it might be worth considering also disabling this option when Require plate-clear confirmation is disabled as it doesn't serve any purpose.

I only speak English - translated strings were generated using AI and not checked for accuracy by a native speaker.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/939 **Author:** [@EdwardChamberlain](https://github.com/EdwardChamberlain) **Created:** 4/10/2026 **Status:** ✅ Merged **Merged:** 4/19/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `dev` ← **Head:** `feature/enhance-plate-clear-tracking-and-visibility` --- ### 📝 Commits (5) - [`d5fcb5f`](https://github.com/maziggy/bambuddy/commit/d5fcb5f21d58c6b0bb28b712f0b5494e0ffe3533) implement plate clear button, add plate status indicator, enable hide on setting change - [`8330f33`](https://github.com/maziggy/bambuddy/commit/8330f3354cdc7d74e04caf7132ced89c9d1bbf92) added plate cleared icon - [`4fa546f`](https://github.com/maziggy/bambuddy/commit/4fa546fdfe7bbda858d577a517fa97e2cb12c119) added smaller plate cleared button on "small" printers view - [`88f49c4`](https://github.com/maziggy/bambuddy/commit/88f49c432a5c02bf13a623df83343510afe882ac) tighten layout slightly - [`c1a23fd`](https://github.com/maziggy/bambuddy/commit/c1a23fd3143be7fde89dd4dc69ab56aed420fcd2) fix(printers): restore plate-clear card controls ### 📊 Changes **12 files changed** (+398 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/__tests__/pages/PrintersPage.test.tsx` (+195 -0) ➕ `frontend/src/components/icons/PlateClearedIcon.tsx` (+51 -0) 📝 `frontend/src/i18n/locales/de.ts` (+7 -1) 📝 `frontend/src/i18n/locales/en.ts` (+7 -1) 📝 `frontend/src/i18n/locales/fr.ts` (+7 -1) 📝 `frontend/src/i18n/locales/it.ts` (+7 -1) 📝 `frontend/src/i18n/locales/ja.ts` (+7 -1) 📝 `frontend/src/i18n/locales/pt-BR.ts` (+7 -1) 📝 `frontend/src/i18n/locales/zh-CN.ts` (+7 -1) 📝 `frontend/src/i18n/locales/zh-TW.ts` (+7 -1) 📝 `frontend/src/pages/PrintersPage.tsx` (+95 -7) 📝 `frontend/src/pages/SettingsPage.tsx` (+1 -1) </details> ### 📄 Description ## Description This PR improves the printer card workflow around plate-clear confirmation so the existing `plate_cleared` flag is visible and actionable directly in the main printer UI, without relying on the queue-specific flow. Previously, the web UI only exposed a per-printer plate-clear action widget when a compatible queued job was waiting. As a result, a finished printer with no waiting queue item had no normal card-level way to be marked as cleared, even though the backend already supported that state through the existing API. This change adds plate-clear visibility and control directly to printer cards, while keeping behaviour aligned with the existing scheduler semantics and workflow setting. ## Related Issue Fixes #935 ## Documentation **Companion docs PRs** (delete lines that don't apply): **Pick one**: - [ ] Docs PR(s) linked above - [x] No docs update required — reason: UI behaviour changed, but no standalone documentation update is needed for this change ## Type of Change  - [ ] Bug fix (non-breaking change that fixes an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made - Added a plate status badge to printer cards showing "Plate Cleared", "Plate in use", "Plate Not Cleared" - Added a Mark plate as cleared button to printer cards visible when not printing and uncleared. - `Require plate-clear confirmation` button hides both indicator and button for those not interested. - Updated the `Require plate-clear confirmation` setting description to clarify that disabling plate-clear confirmation also hides the plate status badge and card button - Added and updated frontend tests to cover the new printer card behaviour ## Screenshots <img width="516" height="185" alt="image" src="https://github.com/user-attachments/assets/bc6dc55e-bb35-4d3e-8041-71fd8231b962" /> <img width="618" height="764" alt="image" src="https://github.com/user-attachments/assets/72d54a1b-42a4-46ef-878e-8238a974f123" /> <img width="618" height="754" alt="image" src="https://github.com/user-attachments/assets/39445884-5293-494b-9bda-b60a43e201b7" /> ## Testing  - [X] I have tested this on my local machine - [X] I have tested with my printer model: P1S All tests passed locally. ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes Behaviour when Require plate-clear confirmation is enabled: - RUNNING / PAUSE printers show Plate in Use - FINISH / FAILED printers with plate_cleared = false show Plate not Clear - FINISH / FAILED printers with plate_cleared = true show Plate Clear - The Mark plate as cleared button appears only for connected FINISH / FAILED printers where plate_cleared = false Behaviour when Require plate-clear confirmation is disabled: - The plate status badge is hidden - The Mark plate as cleared button is hidden - Scheduler behaviour remains unchanged and does not rely on the flag for FINISH / FAILED printers The existing bulk clear-plate action is intentionally left untouched but it might be worth considering also disabling this option when `Require plate-clear confirmation` is disabled as it doesn't serve any purpose. I only speak English - translated strings were generated using AI and **not** checked for accuracy by a native speaker. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

2026-05-06 12:35:16 +02:00

closed this issue
added the
pull-request
label

No Branch/Tag specified

main

github-repo-stats

bug-report-assets

dev

0.2.4b3

0.2.4b2

0.2.4b1

pr/1114

0.2.3.2

0.2.3.1

0.2.3

0.2.3b3

0.2.3b2

0.2.3b1

0.2.2.2

0.2.2.1

0.2.2b3

0.2.2

0.2.2b2

0.2.2b1

0.2.1.1

0.2.1

0.2.1b3

0.2.1b2

0.2.1b

0.2.0

0.2.0b

0.1.5-2-ctrl

v0.2.4b4-daily.20260508

v0.2.4b2

v0.2.4b3

v0.2.4b1

v0.2.3.2

v0.2.3.1

v0.2.3

v0.2.3b3

v0.2.3b2

v0.2.3b1-daily.20260407

v0.2.3b1

v0.2.2.2

v0.2.2.1

v0.2.3b1-daily.20260318

v0.2.3b1-daily.20260317

v0.2.3b1-daily.20260316

v0.2.2

v0.2.2b4-daily.20260314

v0.2.2b4-daily.20260313

v0.2.2b3-daily.20260312

v0.2.2b3-1

v0.2.2b2

v0.2.2-b2

v0.2.2b3

v0.2.2-b1

v0.2.2b1

v0.2.1.1

v0.2.1

v0.2.1b3

v0.2.1b2

v0.2.1b

v0.2.0

v0.1.9

v0.1.8.1

v0.1.8

v0.1.7

v0.1.6.2

v0.1.6.1

v0.1.6-hotfix

v0.1.6

v0.1.6b11

v0.1.6b10

v0.1.6b9

v0.1.6b8

v0.1.6b7

v0.1.6b6

v0.1.6b5

v0.1.6b4

v0.1.6b3

v0.1.6b2

v0.1.6b

v0.1.5-final

v0.1.5b7

v0.1.5b6

v0.1.5b5

v0.1.5b4

v0.1.5b3

v0.1.5b2

v0.1.5b

v0.1.4

v0.1.3

v0.1.2-bugfix

v0.1.2-final

v0.1.2

0.1.1

Labels

Clear labels

automated

bug

Closed due to inactivity

Mirrored from GitHub Pull Request

No labels

Closed due to inactivity

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/bambuddy#1135

Reference in a new issue

Repository

starred/bambuddy

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns