[PR #958] [MERGED] feat: Shows vendor name in Spoolman Link Modal #1137

Closed
opened 2026-05-06 12:35:16 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/958
Author: @shrunbr
Created: 4/13/2026
Status: Merged
Merged: 4/13/2026
Merged by: @maziggy

Base: devHead: feature/spoolmanVendor


📝 Commits (3)

  • 6267b28 Add filament_vendor field to UnlinkedSpool model and populate from API response
  • 2e7a614 Add filament_vendor field to UnlinkedSpool interface
  • ee04d22 Enhance LinkSpoolModal to include filament_vendor in search and display

📊 Changes

3 files changed (+5 additions, -0 deletions)

View changed files

📝 backend/app/api/routes/spoolman.py (+2 -0)
📝 frontend/src/api/client.ts (+1 -0)
📝 frontend/src/components/LinkSpoolModal.tsx (+2 -0)

📄 Description

Description

This pull request adds support for displaying and searching by filament vendor for unlinked spools throughout both the backend and frontend. The main changes update data models, API responses, UI display, and search functionality to include the new filament_vendor field.

#926

Documentation

Pick one:

  • Docs PR(s) linked above
  • No docs update required — reason: UX enhancement

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

Backend changes:

  • Added a new filament_vendor field to the UnlinkedSpool data model in spoolman.py to store the vendor name.
  • Updated the get_unlinked_spools API endpoint to populate the new filament_vendor field from the filament data.

Frontend changes:

  • Updated the UnlinkedSpool TypeScript interface to include the new filament_vendor field.

UI/UX improvements:

  • Enhanced the search functionality in LinkSpoolModal to allow searching by filament vendor.
  • Updated the spool display in LinkSpoolModal to show the filament vendor next to the material and spool ID.

Screenshots

image image image

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: P2S

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes

N/A


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/958 **Author:** [@shrunbr](https://github.com/shrunbr) **Created:** 4/13/2026 **Status:** ✅ Merged **Merged:** 4/13/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `dev` ← **Head:** `feature/spoolmanVendor` --- ### 📝 Commits (3) - [`6267b28`](https://github.com/maziggy/bambuddy/commit/6267b288ed8f7faa5628a0c6d4639c448c348868) Add filament_vendor field to UnlinkedSpool model and populate from API response - [`2e7a614`](https://github.com/maziggy/bambuddy/commit/2e7a6143d3161b62dac14aee0db8530629ebeb2d) Add filament_vendor field to UnlinkedSpool interface - [`ee04d22`](https://github.com/maziggy/bambuddy/commit/ee04d2297b9319d397b7d6745eb8083362d17912) Enhance LinkSpoolModal to include filament_vendor in search and display ### 📊 Changes **3 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/api/routes/spoolman.py` (+2 -0) 📝 `frontend/src/api/client.ts` (+1 -0) 📝 `frontend/src/components/LinkSpoolModal.tsx` (+2 -0) </details> ### 📄 Description ## Description This pull request adds support for displaying and searching by filament vendor for unlinked spools throughout both the backend and frontend. The main changes update data models, API responses, UI display, and search functionality to include the new `filament_vendor` field. ## Related Issue #926 ## Documentation <!-- If this PR changes user-visible behavior, config keys, ports, CLI flags, URLs, or installation steps, link matching PRs in the docs repos below. Internal refactors, bug fixes with no observable change, and test-only changes are exempt — just check the "not required" box and say why. See CONTRIBUTING.md → Documentation Requirements for the full rules. --> **Pick one**: - [ ] Docs PR(s) linked above - [X] No docs update required — reason: UX enhancement ## Type of Change <!-- Mark the relevant option with an "x" --> - [ ] Bug fix (non-breaking change that fixes an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made **Backend changes:** * Added a new `filament_vendor` field to the `UnlinkedSpool` data model in `spoolman.py` to store the vendor name. * Updated the `get_unlinked_spools` API endpoint to populate the new `filament_vendor` field from the filament data. **Frontend changes:** * Updated the `UnlinkedSpool` TypeScript interface to include the new `filament_vendor` field. **UI/UX improvements:** * Enhanced the search functionality in `LinkSpoolModal` to allow searching by filament vendor. * Updated the spool display in `LinkSpoolModal` to show the filament vendor next to the material and spool ID. ## Screenshots <img width="455" height="397" alt="image" src="https://github.com/user-attachments/assets/947d9e03-8381-4c4b-ae05-118f30aaefeb" /> <img width="460" height="333" alt="image" src="https://github.com/user-attachments/assets/4ea4a6bf-1c42-470e-91d8-8fa575d9a7a0" /> <img width="485" height="349" alt="image" src="https://github.com/user-attachments/assets/b36529b0-752c-4ae6-9e09-3284b0d86862" /> ## Testing <!-- Describe how you tested your changes --> - [X] I have tested this on my local machine - [X] I have tested with my printer model: P2S ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:35:16 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy#1137
No description provided.