[PR #1079] [CLOSED] fix(printers): deduplicate plate clear action

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/bambuddy#1154

BreizhHardware commented

2026-05-06 12:35:23 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/1079
Author: @EdwardChamberlain
Created: 4/21/2026
Status: ❌ Closed

Base: dev ← Head: fix/duplicate_plate_clear

📝 Commits (2)

6664a9f fix(printers): deduplicate plate clear action
8f3b058 Merge branch 'dev' into fix/duplicate_plate_clear

📊 Changes

3 files changed (+43 additions, -155 deletions)

View changed files

📝 frontend/src/__tests__/components/PrinterQueueWidgetClearPlate.test.tsx (+34 -74)
📝 frontend/src/components/PrinterQueueWidget.tsx (+3 -79)
📝 frontend/src/pages/PrintersPage.tsx (+6 -2)

📄 Description

Description

Fixes duplicate plate-clear actions in the Printers UI and aligns plate status placement with the existing status badge row.

This removes the queued-widget clear-plate action so only the printer-card clear action remains, and moves the plate status indicator out of the print-status box into the expanded card’s top badge row with matching badge styling.

Documentation

Pick one:

Docs PR(s) linked above
No docs update required — reason: Fix

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

Removed the queued-only green clear-plate action path from frontend/src/components/PrinterQueueWidget.tsx.
Moved expanded-card plate status display into the top status badge row in frontend/src/pages/PrintersPage.tsx and removed in-box duplicate rendering.
Updated frontend/src/tests/components/PrinterQueueWidgetClearPlate.test.tsx to assert passive queue-widget behavior while preserving existing filament/filtering coverage.

Screenshots

Testing

I have tested this on my local machine
I have tested with my printer model: P1S / H2S

Checklist

My code follows the project's coding style
I have commented my code where necessary
My changes generate no new warnings
I have tested my changes thoroughly

Additional Notes

This is primarily to rectify the duplication generated in #939

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/1079 **Author:** [@EdwardChamberlain](https://github.com/EdwardChamberlain) **Created:** 4/21/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/duplicate_plate_clear` --- ### 📝 Commits (2) - [`6664a9f`](https://github.com/maziggy/bambuddy/commit/6664a9f4373fab871ddc01c27ccd0bec678caaa5) fix(printers): deduplicate plate clear action - [`8f3b058`](https://github.com/maziggy/bambuddy/commit/8f3b058ff6cb1b9fe71efc11e9a1782a96a52161) Merge branch 'dev' into fix/duplicate_plate_clear ### 📊 Changes **3 files changed** (+43 additions, -155 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/__tests__/components/PrinterQueueWidgetClearPlate.test.tsx` (+34 -74) 📝 `frontend/src/components/PrinterQueueWidget.tsx` (+3 -79) 📝 `frontend/src/pages/PrintersPage.tsx` (+6 -2) </details> ### 📄 Description ## Description Fixes duplicate plate-clear actions in the Printers UI and aligns plate status placement with the existing status badge row. This removes the queued-widget clear-plate action so only the printer-card clear action remains, and moves the plate status indicator out of the print-status box into the expanded card’s top badge row with matching badge styling. ## Related Issue ## Documentation **Pick one**: - [ ] Docs PR(s) linked above - [X] No docs update required — reason: Fix ## Type of Change  - [X] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [X] Test addition or update ## Changes Made - Removed the queued-only green clear-plate action path from frontend/src/components/PrinterQueueWidget.tsx. - Moved expanded-card plate status display into the top status badge row in frontend/src/pages/PrintersPage.tsx and removed in-box duplicate rendering. - Updated frontend/src/__tests__/components/PrinterQueueWidgetClearPlate.test.tsx to assert passive queue-widget behavior while preserving existing filament/filtering coverage. ## Screenshots <img width="412" height="503" alt="image" src="https://github.com/user-attachments/assets/702b81e3-e466-47c3-9c1d-16d395829d20" /> ## Testing  - [X] I have tested this on my local machine - [X] I have tested with my printer model: P1S / H2S ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes This is primarily to rectify the duplication generated in #939 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1079] [CLOSED] fix(printers): deduplicate plate clear action #1154