[PR #1183] [CLOSED] Add ai detection box drawing support to notifications #1169

Closed
opened 2026-05-06 12:35:28 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/1183
Author: @vasmarfas
Created: 4/30/2026
Status: Closed

Base: mainHead: main


📝 Commits (1)

  • b7b5231 Add detection box drawing support to notifications and expand action dispatch parameters

📊 Changes

2 files changed (+90 additions, -7 deletions)

View changed files

📝 backend/app/services/obico_actions.py (+71 -3)
📝 backend/app/services/obico_detection.py (+19 -4)

📄 Description

Description

Fixes AI failure detection notifications so they include an image, and adds optional visual highlighting of detected failure regions.

Documentation

  • No docs update required — reason: backend-only bug fix; no user-facing settings, URLs, ports, or install steps changed.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • Updated Obico failure dispatch flow to pass the captured frame and detections into action execution.
  • Enhanced AI failure notification path to attach image_data for ai_failure_detection events.
  • Added bounding-box rendering on the failure snapshot (supports normalized or absolute bbox coordinates) before sending notifications.

Testing

  • I have tested this on my local machine
  • I have tested with my printer model: A1

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes

When detections are present, the outgoing image is annotated with red boxes.
If detections are missing or malformed, notifications still include the original image (no overlay) to avoid dropping attachments.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/1183 **Author:** [@vasmarfas](https://github.com/vasmarfas) **Created:** 4/30/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`b7b5231`](https://github.com/maziggy/bambuddy/commit/b7b5231e58d4ca0bde705c6a894f9f0861e05ee3) Add detection box drawing support to notifications and expand action dispatch parameters ### 📊 Changes **2 files changed** (+90 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/services/obico_actions.py` (+71 -3) 📝 `backend/app/services/obico_detection.py` (+19 -4) </details> ### 📄 Description ## Description Fixes AI failure detection notifications so they include an image, and adds optional visual highlighting of detected failure regions. ## Documentation - [x] No docs update required — reason: backend-only bug fix; no user-facing settings, URLs, ports, or install steps changed. ## Type of Change - [x] Bug fix (non-breaking change that fixes an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made - Updated Obico failure dispatch flow to pass the captured frame and detections into action execution. - Enhanced AI failure notification path to attach `image_data` for `ai_failure_detection` events. - Added bounding-box rendering on the failure snapshot (supports normalized or absolute bbox coordinates) before sending notifications. ## Testing - [x] I have tested this on my local machine - [x] I have tested with my printer model: A1 ## Checklist - [x] My code follows the project's coding style - [x] I have commented my code where necessary - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes When detections are present, the outgoing image is annotated with red boxes. If detections are missing or malformed, notifications still include the original image (no overlay) to avoid dropping attachments. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:35:28 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy#1169
No description provided.