starred/bambuddy

Fork 0

mirror of https://github.com/maziggy/bambuddy.git synced 2026-05-09 05:35:30 +02:00

[GH-ISSUE #372] [Feature]: Add option to attach the finished print photo to “print finished” notifications (not just {finish_photo_url}) #233

New issue

Closed

opened 2026-05-06 12:27:28 +02:00 by BreizhHardware · 5 comments

BreizhHardware commented

2026-05-06 12:27:28 +02:00

Owner

Originally created by @fila612 on GitHub (Feb 14, 2026).
Original GitHub issue: https://github.com/maziggy/bambuddy/issues/372

Originally assigned to: @maziggy on GitHub.

Problem or Use Case

Hi Bambuddy team,

currently the “print finished” notification can include the local photo URL via {finish_photo_url}. This is useful, but in practice it’s often not accessible from outside the local network (or from mobile push providers / remote clients).

Feature request
Please add an option to attach the “finished print” photo as an actual image attachment in the notification (or alternatively embed it), instead of only providing the local URL.

Why this matters / problem statement
• {finish_photo_url} is typically a local URL, so it often can’t be opened when I’m not on the same network/VPN.
• Many notification targets (mobile push, messaging bridges, etc.) work much better with an image attachment/preview than with a plain link.
• For a “print finished” event, the photo is the most relevant payload—seeing it directly is the point.

Proposed Solution

Suggested behavior / acceptance criteria
• Add a new placeholder and/or setting, e.g. {finish_photo} as binary attachment (or a boolean “Attach finish photo”).
• If the backend can fetch the image reliably, include it as an attachment for supported notifiers.
• If attachment is not supported by the target notifier, fall back to including {finish_photo_url} (current behavior).
• Optional: allow selecting image size/quality to keep payload small.

Alternatives Considered

No response

Feature Category

Notifications

Priority

Nice to have

Mockups or Examples

Notes / constraints
• A direct attachment implies Bambuddy either:
1. already has access to the image data locally and can pass it through, or
2. can fetch it from the printer/camera endpoint and then attach it.
• If remote access is a concern, even a proxied/served image URL from Bambuddy (instead of the printer’s local URL) would already be a big improvement—but attachment would be ideal.

Thanks!

Contribution

I would be willing to help implement this feature

Checklist

I have searched existing issues to ensure this feature hasn't already been requested

Originally created by @fila612 on GitHub (Feb 14, 2026). Original GitHub issue: https://github.com/maziggy/bambuddy/issues/372 Originally assigned to: @maziggy on GitHub. ### Problem or Use Case Hi Bambuddy team, currently the “print finished” notification can include the local photo URL via {finish_photo_url}. This is useful, but in practice it’s often not accessible from outside the local network (or from mobile push providers / remote clients). Feature request Please add an option to attach the “finished print” photo as an actual image attachment in the notification (or alternatively embed it), instead of only providing the local URL. Why this matters / problem statement • {finish_photo_url} is typically a local URL, so it often can’t be opened when I’m not on the same network/VPN. • Many notification targets (mobile push, messaging bridges, etc.) work much better with an image attachment/preview than with a plain link. • For a “print finished” event, the photo is the most relevant payload—seeing it directly is the point. ### Proposed Solution Suggested behavior / acceptance criteria • Add a new placeholder and/or setting, e.g. {finish_photo} as binary attachment (or a boolean “Attach finish photo”). • If the backend can fetch the image reliably, include it as an attachment for supported notifiers. • If attachment is not supported by the target notifier, fall back to including {finish_photo_url} (current behavior). • Optional: allow selecting image size/quality to keep payload small. ### Alternatives Considered _No response_ ### Feature Category Notifications ### Priority Nice to have ### Mockups or Examples Notes / constraints • A direct attachment implies Bambuddy either: 1. already has access to the image data locally and can pass it through, or 2. can fetch it from the printer/camera endpoint and then attach it. • If remote access is a concern, even a proxied/served image URL from Bambuddy (instead of the printer’s local URL) would already be a big improvement—but attachment would be ideal. Thanks! ### Contribution - [ ] I would be willing to help implement this feature ### Checklist - [x] I have searched existing issues to ensure this feature hasn't already been requested

BreizhHardware

2026-05-06 12:27:28 +02:00

closed this issue
added the
enhancement
label

BreizhHardware commented

2026-05-06 12:27:28 +02:00

Author

Owner

@maziggy commented on GitHub (Feb 14, 2026):

Problem is, that not all providers are supporting image attachments.

@maziggy commented on GitHub (Feb 14, 2026): Problem is, that not all providers are supporting image attachments.

BreizhHardware commented

2026-05-06 12:27:29 +02:00

Author

Owner

@fila612 commented on GitHub (Feb 14, 2026):

okay, valid point. maybe this can be added only for providers who supporting that.

@fila612 commented on GitHub (Feb 14, 2026): okay, valid point. maybe this can be added only for providers who supporting that.

BreizhHardware commented

2026-05-06 12:27:29 +02:00

Author

Owner

@maziggy commented on GitHub (Feb 14, 2026):

But then we would also need separate templates for each provider. That would blew up things too much.

@maziggy commented on GitHub (Feb 14, 2026): But then we would also need separate templates for each provider. That would blew up things too much.

BreizhHardware commented

2026-05-06 12:27:29 +02:00

Author

Owner

@penner42 commented on GitHub (Feb 15, 2026):

Doesn't it already do this for Pushover though? I don't think it needs a separate template, just an option to include image if it's available. Can default not having. I would like it for ntfy, and was going to submit a feature request. Looking at the code (github.com/maziggy/bambuddy@40f6ddc059/backend/app/services/notification_service.py (L243)) it looks like it just always sends an image for Pushover. Can just do this for the ones that support it, or have an option to disable it.

@penner42 commented on GitHub (Feb 15, 2026): Doesn't it already do this for Pushover though? I don't think it needs a separate template, just an option to include image if it's available. Can default not having. I would like it for ntfy, and was going to submit a feature request. Looking at the code (https://github.com/maziggy/bambuddy/blob/40f6ddc059ac3875056f03af384ec9819e8cbec3/backend/app/services/notification_service.py#L243) it looks like it just always sends an image for Pushover. Can just do this for the ones that support it, or have an option to disable it.

BreizhHardware commented

2026-05-06 12:27:29 +02:00

Author

Owner

@maziggy commented on GitHub (Feb 16, 2026):

Yes, you're right. Telegram and ntfy are also supporting images.

Available in branch 0.2.0b.

@maziggy commented on GitHub (Feb 16, 2026): Yes, you're right. Telegram and ntfy are also supporting images. Available in branch 0.2.0b.

BreizhHardware referenced this issue

2026-05-06 12:34:15 +02:00

[PR #237] [MERGED] v0.1.7b #969

BreizhHardware referenced this issue

2026-05-06 12:34:21 +02:00

[PR #282] [MERGED] v0.1.8 #986

BreizhHardware referenced this issue

2026-05-06 12:34:22 +02:00

[PR #281] [CLOSED] v0.1.8 #989