[PR #73] [MERGED] Updated A1/A1mini/P1S Upload fix

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/bambuddy#918

BreizhHardware commented

2026-05-06 12:33:56 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/73
Author: @VREmma
Created: 1/11/2026
Status: ✅ Merged
Merged: 1/11/2026
Merged by: @maziggy

Base: 0.1.6-final ← Head: fix/a1p1_file_upload

📝 Commits (1)

9969005 Updated A1/A1mini/P1S Upload fix

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 backend/app/services/bambu_ftp.py (+6 -2)

📄 Description

Description

Updated BambuFTP class for A1/A1mini/P1S upload fix while leaving it thread safe.

https://github.com/maziggy/bambuddy/issues/31

Fixes #31

Type of Change

[X ] Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

Made it ignore the TLS wrapper only during file upload
Added P1S/P1P to printer list.

Testing

I have tested this on my local machine
I have tested with my printer model: A1, X1C

Checklist

My code follows the project's coding style
I have commented my code where necessary
I have updated the documentation (if needed)
My changes generate no new warnings
I have tested my changes thoroughly

Additional Notes

Since the kampfklecks said their P1S worked with the A1 only branch code I had, I went ahead and added P1S and P1P to the printer list for the bypass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/73 **Author:** [@VREmma](https://github.com/VREmma) **Created:** 1/11/2026 **Status:** ✅ Merged **Merged:** 1/11/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.1.6-final` ← **Head:** `fix/a1p1_file_upload` --- ### 📝 Commits (1) - [`9969005`](https://github.com/maziggy/bambuddy/commit/9969005f6c52ea48225cc68eccbf5e2dd84ae0ba) Updated A1/A1mini/P1S Upload fix ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/services/bambu_ftp.py` (+6 -2) </details> ### 📄 Description ## Description Updated BambuFTP class for A1/A1mini/P1S upload fix while leaving it thread safe. ## Related Issue https://github.com/maziggy/bambuddy/issues/31 Fixes #31 ## Type of Change  - [X ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made  - Made it ignore the TLS wrapper only during file upload - Added P1S/P1P to printer list. ## Testing  - [x] I have tested this on my local machine - [x] I have tested with my printer model: A1, X1C ## Checklist - [x] My code follows the project's coding style - [x] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes Since the [kampfklecks](https://github.com/kampfklecks) said their P1S worked with the A1 only branch code I had, I went ahead and added P1S and P1P to the printer list for the bypass.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

closed this issue
added the
pull-request
label

Rows
Columns

[PR #73] [MERGED] Updated A1/A1mini/P1S Upload fix #918