[PR #260] [MERGED] Fix/virtual printer proxy error

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/bambuddy#978

BreizhHardware commented

2026-05-06 12:34:18 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/260
Author: @karaktaka
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/4/2026
Merged by: @maziggy

Base: 0.1.8b ← Head: fix/virtual_printer_proxy_error

📝 Commits (4)

2289dd6 Add CI and Code Scanning badges to README
84f1347 Reorder import statement for jwt in main.py
bf75cd2 Remove unused import statement for sqlalchemy in main.py
31a8016 Merge branch '0.1.8b' into fix/virtual_printer_proxy_error

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 backend/app/main.py (+1 -3)

📄 Description

Description

There was an unused import statement that interfered with later occurunces of the select function.
I also fixed an issue that could arise if a problem occurs while working with jwt and moved the import a bit up.

Fixes #254

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

removed an unused import statement of 'select' from 'sqlalchemy'
moved the import statement for jwt outside of the try block

Testing

I have tested this on my local machine
I have tested with my printer model: P1S

Checklist

My code follows the project's coding style
I have commented my code where necessary
I have updated the documentation (if needed)
My changes generate no new warnings
I have tested my changes thoroughly

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/260 **Author:** [@karaktaka](https://github.com/karaktaka) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.1.8b` ← **Head:** `fix/virtual_printer_proxy_error` --- ### 📝 Commits (4) - [`2289dd6`](https://github.com/maziggy/bambuddy/commit/2289dd6ca3eac8fca2987d24e157115ced5db5f1) Add CI and Code Scanning badges to README - [`84f1347`](https://github.com/maziggy/bambuddy/commit/84f1347bd0d0126bec67c08028b7361e872d00ed) Reorder import statement for jwt in main.py - [`bf75cd2`](https://github.com/maziggy/bambuddy/commit/bf75cd2527a45f01f548ec69e026c0d38533d35d) Remove unused import statement for sqlalchemy in main.py - [`31a8016`](https://github.com/maziggy/bambuddy/commit/31a8016c80c7735f3ce09cd98a65674c7c0dcec1) Merge branch '0.1.8b' into fix/virtual_printer_proxy_error ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/main.py` (+1 -3) </details> ### 📄 Description ## Description There was an unused import statement that interfered with later occurunces of the select function. I also fixed an issue that could arise if a problem occurs while working with jwt and moved the import a bit up. ## Related Issue Fixes #254 ## Type of Change  - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made - removed an unused import statement of 'select' from 'sqlalchemy' - moved the import statement for jwt outside of the try block ## Testing  - [x] I have tested this on my local machine - [x] I have tested with my printer model: P1S ## Checklist - [x] My code follows the project's coding style - [x] I have commented my code where necessary - [x] I have updated the documentation (if needed) - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

closed this issue
added the
pull-request
label

Rows
Columns

[PR #260] [MERGED] Fix/virtual printer proxy error #978