[PR #280] [CLOSED] Fix/queue item expired #985

Closed
opened 2026-05-06 12:34:21 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/280
Author: @MisterBeardy
Created: 2/5/2026
Status: Closed

Base: mainHead: fix/queue-item-expired


📝 Commits (2)

  • a489fb8 Add 'expired' status to PrintQueueItem and update translations
  • d15ca4e Updated queue API

📊 Changes

6 files changed (+9 additions, -4 deletions)

View changed files

📝 backend/app/schemas/print_queue.py (+1 -1)
📝 frontend/src/api/client.ts (+1 -1)
📝 frontend/src/i18n/locales/de.ts (+1 -0)
📝 frontend/src/i18n/locales/en.ts (+1 -0)
📝 frontend/src/i18n/locales/ja.ts (+1 -0)
📝 frontend/src/pages/QueuePage.tsx (+4 -2)

📄 Description

Description

Resolved issue with expired print queue items preventing the print queue page from loading
Now displays Queue item expired - older than 24 hours

Fixes #276

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

Backend:

Added expired to the queue item response schema so API responses validate when a stale item is marked expired. See backend/app/schemas/print_queue.py:86.
Frontend:

  1. Extended the print queue item status union to include expired.
  2. Updated queue status labels/translations to include expired (EN/DE/JA).
  3. Updated the queue page to recognize/display expired in status UI handling.

Screenshots

image

Testing

Added several items to the queue
Already had some older items that were added previously and those now show the expired after 24 hours
created a small script to adjust the time on a single queue item to 25+ hours and after making the change, letting the system refresh, the message was displayed on the queue item.

  • I have tested this on my local machine
  • I have tested with my printer model:

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • I have updated the documentation (if needed)
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes

Quick fix to resolve the error, if more needs to be done let me know.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/280 **Author:** [@MisterBeardy](https://github.com/MisterBeardy) **Created:** 2/5/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/queue-item-expired` --- ### 📝 Commits (2) - [`a489fb8`](https://github.com/maziggy/bambuddy/commit/a489fb87f3a7772344d17b3a86ae2c790932f818) Add 'expired' status to PrintQueueItem and update translations - [`d15ca4e`](https://github.com/maziggy/bambuddy/commit/d15ca4ef809b119b776269305a7b1c78af3e78d5) Updated queue API ### 📊 Changes **6 files changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/schemas/print_queue.py` (+1 -1) 📝 `frontend/src/api/client.ts` (+1 -1) 📝 `frontend/src/i18n/locales/de.ts` (+1 -0) 📝 `frontend/src/i18n/locales/en.ts` (+1 -0) 📝 `frontend/src/i18n/locales/ja.ts` (+1 -0) 📝 `frontend/src/pages/QueuePage.tsx` (+4 -2) </details> ### 📄 Description ## Description Resolved issue with expired print queue items preventing the print queue page from loading Now displays Queue item expired - older than 24 hours ## Related Issue Fixes #276 ## Type of Change <!-- Mark the relevant option with an "x" --> - [X] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made <!-- List the specific changes made in this PR --> Backend: Added expired to the queue item response schema so API responses validate when a stale item is marked expired. See [backend/app/schemas/print_queue.py:86](vscode-webview://002ee62v1bp3jhntupa52af2u9k7nattd2s7icbuejgn50kvhmb4/backend/app/schemas/print_queue.py:86). Frontend: 1. Extended the print queue item status union to include expired. 2. Updated queue status labels/translations to include expired (EN/DE/JA). 3. Updated the queue page to recognize/display expired in status UI handling. ## Screenshots <!-- If applicable, add screenshots to demonstrate your changes --> <img width="404" height="521" alt="image" src="https://github.com/user-attachments/assets/55d5ee9b-1868-4a16-8e6d-0a8f4ac966fd" /> ## Testing <!-- Describe how you tested your changes --> Added several items to the queue Already had some older items that were added previously and those now show the expired after 24 hours created a small script to adjust the time on a single queue item to 25+ hours and after making the change, letting the system refresh, the message was displayed on the queue item. - [x] I have tested this on my local machine - [ ] I have tested with my printer model: <!-- e.g., X1C, P1S, A1 --> ## Checklist - [x] My code follows the project's coding style - [ ] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [x] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes <!-- Add any additional information that reviewers should know --> Quick fix to resolve the error, if more needs to be done let me know. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:34:21 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/bambuddy#985
No description provided.