[PR #303] [MERGED] Fix: Use TZ from .env instead of hardcoded value

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/bambuddy#992

BreizhHardware commented

2026-05-06 12:34:23 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/303
Author: @bnap00
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/9/2026
Merged by: @maziggy

Base: 0.1.9b ← Head: fix/timezone-env-variable

📝 Commits (7)

91ff138 Added two steps to the docker-test job in ci.yml
8503cbc Updated CONTRIBUTING.md
c950c19 Updated README
75c049b Updated install scripts and related docs
f094c16 Updated install scripts and related docs
8b24193 Fix: Use TZ from .env instead of hardcoded value
dc306af Merge branch '0.1.9b' into fix/timezone-env-variable

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 docker-compose.yml (+1 -1)

📄 Description

The timezone collected during docker-install.sh was being saved to .env but docker-compose.yml had a hardcoded TZ=Europe/Berlin.

Changed to TZ=${TZ:-Europe/Berlin} to use .env value with fallback.

Description

Fixes hardcoded timezone in docker-compose.yml that ignored .env setting
Container now uses TZ value from .env file with Europe/Berlin as fallback

Fixes #

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

Fixes hardcoded timezone in docker-compose.yml that ignored .env setting

Screenshots

Testing

I have tested this on my local machine
I have tested with my printer model:

Checklist

My code follows the project's coding style
I have commented my code where necessary
I have updated the documentation (if needed)
My changes generate no new warnings
I have tested my changes thoroughly

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/303 **Author:** [@bnap00](https://github.com/bnap00) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/9/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.1.9b` ← **Head:** `fix/timezone-env-variable` --- ### 📝 Commits (7) - [`91ff138`](https://github.com/maziggy/bambuddy/commit/91ff1386c48ca5a5b228636f990f273ae6c1aafd) Added two steps to the docker-test job in ci.yml - [`8503cbc`](https://github.com/maziggy/bambuddy/commit/8503cbc5bfd354405b841fe7953e7bd4eedb2612) Updated CONTRIBUTING.md - [`c950c19`](https://github.com/maziggy/bambuddy/commit/c950c191689a384c1ebae2923e984f1f25520290) Updated README - [`75c049b`](https://github.com/maziggy/bambuddy/commit/75c049b05cb3cb58cd702364f741bd472e1c34f0) Updated install scripts and related docs - [`f094c16`](https://github.com/maziggy/bambuddy/commit/f094c160121aeccf833b6a55164a2f1d3828c601) Updated install scripts and related docs - [`8b24193`](https://github.com/maziggy/bambuddy/commit/8b24193709800b053485cbf4bf84aeb298a0f7a7) Fix: Use TZ from .env instead of hardcoded value - [`dc306af`](https://github.com/maziggy/bambuddy/commit/dc306af888cc8af8c621f1c9bbbb362413fca132) Merge branch '0.1.9b' into fix/timezone-env-variable ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docker-compose.yml` (+1 -1) </details> ### 📄 Description The timezone collected during docker-install.sh was being saved to .env but docker-compose.yml had a hardcoded TZ=Europe/Berlin. Changed to TZ=${TZ:-Europe/Berlin} to use .env value with fallback. ## Description - Fixes hardcoded timezone in docker-compose.yml that ignored .env setting - Container now uses TZ value from .env file with Europe/Berlin as fallback ## Related Issue Fixes # ## Type of Change  - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made - Fixes hardcoded timezone in docker-compose.yml that ignored .env setting - - ## Screenshots  ## Testing  - [x] I have tested this on my local machine - [ ] I have tested with my printer model:  ## Checklist - [x] My code follows the project's coding style - [ ] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [ ] My changes generate no new warnings - [ ] I have tested my changes thoroughly ## Additional Notes  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

closed this issue
added the
pull-request
label

Rows
Columns

[PR #303] [MERGED] Fix: Use TZ from .env instead of hardcoded value #992