[PR #305] [MERGED] Limit maximum TLS version in ftp_server to 1.2

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/bambuddy#993

BreizhHardware commented

2026-05-06 12:34:23 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/305
Author: @notti
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/9/2026
Merged by: @maziggy

Base: 0.1.9b ← Head: main

📝 Commits (2)

47ed16a Limit maximum TLS version in ftp_server to 1.2
1d0e89f Merge branch '0.1.9b' into main

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 backend/app/services/virtual_printer/ftp_server.py (+1 -0)

📄 Description

This might fix (#58) getting uploads from the linux version of the BambuStudio network plugin. Issue observer is connection resets with larger uploads (somewhere >80k).

Description

This limits TLS of the virtual ftp_server to exactly 1.2 (min 1.2 and max 1.2)

Fixes #58 - further testing would be goo.

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Changes Made

limited TLS version in ftp_server.py

Screenshots

Testing

I have tested this on my local machine
I have tested with my printer model:

Checklist

My code follows the project's coding style
I have commented my code where necessary
I have updated the documentation (if needed)
My changes generate no new warnings
I have tested my changes thoroughly

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/305 **Author:** [@notti](https://github.com/notti) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/9/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.1.9b` ← **Head:** `main` --- ### 📝 Commits (2) - [`47ed16a`](https://github.com/maziggy/bambuddy/commit/47ed16ae60fb0381636d35fc8dc7b4d128c14346) Limit maximum TLS version in ftp_server to 1.2 - [`1d0e89f`](https://github.com/maziggy/bambuddy/commit/1d0e89f571593f87f14671cb12089e6b5fa29c4d) Merge branch '0.1.9b' into main ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/services/virtual_printer/ftp_server.py` (+1 -0) </details> ### 📄 Description This might fix (#58) getting uploads from the linux version of the BambuStudio network plugin. Issue observer is connection resets with larger uploads (somewhere >80k). ## Description This limits TLS of the virtual ftp_server to exactly 1.2 (min 1.2 and max 1.2) ## Related Issue Fixes #58 - further testing would be goo. ## Type of Change  - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update ## Changes Made - limited TLS version in ftp_server.py ## Screenshots  ## Testing  - [x] I have tested this on my local machine - [ ] I have tested with my printer model:  ## Checklist - [x] My code follows the project's coding style - [x] I have commented my code where necessary - [ ] I have updated the documentation (if needed) - [ ] My changes generate no new warnings - [x] I have tested my changes thoroughly ## Additional Notes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

closed this issue
added the
pull-request
label

BreizhHardware referenced this issue

2026-05-06 12:35:21 +02:00

[PR #1029] [MERGED] v0.2.3 final #1149

Rows
Columns

[PR #305] [MERGED] Limit maximum TLS version in ftp_server to 1.2 #993