[PR #330] [MERGED] Remove print() debugging from external_camera.py

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/bambuddy#999

BreizhHardware commented

2026-05-06 12:34:25 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/maziggy/bambuddy/pull/330
Author: @jeffsf
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/11/2026
Merged by: @maziggy

Base: 0.2.0b ← Head: fix/ext-cam-print-2026-02

📝 Commits (4)

8225c29 Merge pull request #324 from maziggy/0.1.9
5d0d249 Fix CI backend-tests failing to collect FTP test suite
40f4e60 Remove print() debugging from external_camera.py
8570e10 Merge branch '0.2.0b' into fix/ext-cam-print-2026-02

📊 Changes

1 file changed (+3 additions, -6 deletions)

View changed files

📝 backend/app/services/external_camera.py (+3 -6)

📄 Description

There were several instances where print() debugging was used instead of or in addition to formal logging. These messages were tagged [EXT-CAM].

Where there was already a logging call, the print statement was removed. Where there was not, logger.debug() was used as a replacement.

Description

Clean up what appears to be legacy print() debugging

(n/a)

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Test addition or update

Any third-party code that is looking for [EXT-CAM] on stdout will not get those messages. Use log messages instead.

Changes Made

Remove existing print() logging in external_camera.py
Replace with logger.debug() calls if not already logged

Screenshots

Testing

I have tested this on my local machine
I have tested with my printer model:

Checklist

My code follows the project's coding style
I have commented my code where necessary
I have updated the documentation (if needed)
My changes generate no new warnings
I have tested my changes thoroughly

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/maziggy/bambuddy/pull/330 **Author:** [@jeffsf](https://github.com/jeffsf) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/11/2026 **Merged by:** [@maziggy](https://github.com/maziggy) **Base:** `0.2.0b` ← **Head:** `fix/ext-cam-print-2026-02` --- ### 📝 Commits (4) - [`8225c29`](https://github.com/maziggy/bambuddy/commit/8225c29cfebdc6fb505c741d3e2dbf6b02230759) Merge pull request #324 from maziggy/0.1.9 - [`5d0d249`](https://github.com/maziggy/bambuddy/commit/5d0d249f1dc82f422f2bbcd31f238cfb9779694c) Fix CI backend-tests failing to collect FTP test suite - [`40f4e60`](https://github.com/maziggy/bambuddy/commit/40f4e60f0492e59c66f73f50fc9f1f317e2929ab) Remove print() debugging from external_camera.py - [`8570e10`](https://github.com/maziggy/bambuddy/commit/8570e10f0588a9f9f43dc2a252cebb010134a5a5) Merge branch '0.2.0b' into fix/ext-cam-print-2026-02 ### 📊 Changes **1 file changed** (+3 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/app/services/external_camera.py` (+3 -6) </details> ### 📄 Description There were several instances where print() debugging was used instead of or in addition to formal logging. These messages were tagged `[EXT-CAM]`. Where there was already a logging call, the print statement was removed. Where there was not, logger.debug() was used as a replacement. ## Description Clean up what appears to be legacy print() debugging ## Related Issue (n/a) ## Type of Change  - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [X] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Test addition or update Any third-party code that is looking for `[EXT-CAM]` on stdout will not get those messages. Use log messages instead. ## Changes Made  - Remove existing print() logging in external_camera.py - Replace with logger.debug() calls if not already logged ## Screenshots  ## Testing  - [X] I have tested this on my local machine - [X] I have tested with my printer model:  ## Checklist - [X] My code follows the project's coding style - [X] I have commented my code where necessary - [X] I have updated the documentation (if needed) - [X] My changes generate no new warnings - [X] I have tested my changes thoroughly ## Additional Notes  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

closed this issue
added the
pull-request
label

Rows
Columns

[PR #330] [MERGED] Remove print() debugging from external_camera.py #999