[PR #147] refactor: extract duplicate weather processing logic #175

New issue

Open

opened 2026-05-07 00:19:03 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:19:03 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/IAmTomShaw/f1-race-replay/pull/147
Author: @shash-hq
Created: 1/2/2026
Status: 🔄 Open

Base: main ← Head: fix/code-duplication

📝 Commits (6)

bece282 Feat: Add Fastest Lap Sectors to Qualifying Leaderboard
b21580e Fix(data): Add error logging for missing sector data
55affd9 fix(deps): pin compatible dependencies for python 3.14
b132a87 fix(cli): use argparse and decouple library logic
5872136 refactor: extract duplicate weather processing logic
8b36736 fix(ui): remove detailed sector timings from leaderboard per review

📊 Changes

4 files changed (+139 additions, -126 deletions)

View changed files

📝 main.py (+50 -40)
📝 requirements.txt (+6 -5)
📝 src/f1_data.py (+60 -74)
📝 src/ui_components.py (+23 -7)

📄 Description

Extracts repeated weather data resampling logic into a _process_weather_data helper function in src/f1_data.py to reduce code duplication.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/IAmTomShaw/f1-race-replay/pull/147 **Author:** [@shash-hq](https://github.com/shash-hq) **Created:** 1/2/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/code-duplication` --- ### 📝 Commits (6) - [`bece282`](https://github.com/IAmTomShaw/f1-race-replay/commit/bece28290b1ae21e3edf713ec368743a2159b2b9) Feat: Add Fastest Lap Sectors to Qualifying Leaderboard - [`b21580e`](https://github.com/IAmTomShaw/f1-race-replay/commit/b21580e71ea383730853f4351170aecfdc1c3c32) Fix(data): Add error logging for missing sector data - [`55affd9`](https://github.com/IAmTomShaw/f1-race-replay/commit/55affd9d4a38b09568eb904a8be22df1c5b4bcc9) fix(deps): pin compatible dependencies for python 3.14 - [`b132a87`](https://github.com/IAmTomShaw/f1-race-replay/commit/b132a8777456e5737b4b230fc82a8f40cc15cc57) fix(cli): use argparse and decouple library logic - [`5872136`](https://github.com/IAmTomShaw/f1-race-replay/commit/58721364609a02e7aa5e0e2c917108860b8b7199) refactor: extract duplicate weather processing logic - [`8b36736`](https://github.com/IAmTomShaw/f1-race-replay/commit/8b36736674f883d377f0ca14bb463256da7ba065) fix(ui): remove detailed sector timings from leaderboard per review ### 📊 Changes **4 files changed** (+139 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `main.py` (+50 -40) 📝 `requirements.txt` (+6 -5) 📝 `src/f1_data.py` (+60 -74) 📝 `src/ui_components.py` (+23 -7) </details> ### 📄 Description Extracts repeated weather data resampling logic into a _process_weather_data helper function in src/f1_data.py to reduce code duplication. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>