[PR #160] [MERGED] Fixing leaderboard issues #186

New issue

Closed

opened 2026-05-07 00:19:06 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:19:06 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/IAmTomShaw/f1-race-replay/pull/160
Author: @IAmTomShaw
Created: 1/9/2026
Status: ✅ Merged
Merged: 1/9/2026
Merged by: @IAmTomShaw

Base: main ← Head: 158-race-replay-leaderboard-inaccurate

📝 Commits (2)

6007146 Fixing leaderboard issues
342db94 Fixed random leaderboard changes at end of lap

📊 Changes

3 files changed (+22 additions, -10 deletions)

View changed files

📝 src/f1_data.py (+1 -1)
📝 src/interfaces/race_replay.py (+0 -8)
📝 src/ui_components.py (+21 -1)

📄 Description

These leaderboard issues have kept cropping up... but I think I've solved them.

This PR fixes the following:

Randomised leaderboard on Lap 1

After the cars were reaching halfway around the first lap, the order of the leaderboard was being flipped. This has been fixed. However, the leaderboard data still shows some inaccuracies on the first lap due to how the "dist" values are recorded in the data source. There's not much we can do about that at this time, but I'm sure there's a solution out there if someone wants to try.

Drivers being moved to first position as they pass the start/finish line on a new lap

As cars cross the start finish line, sometimes the frames in the data were showing the driver to be in first position, when in reality they were not.

This has been resolved by adding in a missing sorting function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/IAmTomShaw/f1-race-replay/pull/160 **Author:** [@IAmTomShaw](https://github.com/IAmTomShaw) **Created:** 1/9/2026 **Status:** ✅ Merged **Merged:** 1/9/2026 **Merged by:** [@IAmTomShaw](https://github.com/IAmTomShaw) **Base:** `main` ← **Head:** `158-race-replay-leaderboard-inaccurate` --- ### 📝 Commits (2) - [`6007146`](https://github.com/IAmTomShaw/f1-race-replay/commit/6007146d62ff0764f8c5e3e85bd019cfe3807523) Fixing leaderboard issues - [`342db94`](https://github.com/IAmTomShaw/f1-race-replay/commit/342db9426a7e7ddc75f9ea7cbdf1ef1cb96600ba) Fixed random leaderboard changes at end of lap ### 📊 Changes **3 files changed** (+22 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/f1_data.py` (+1 -1) 📝 `src/interfaces/race_replay.py` (+0 -8) 📝 `src/ui_components.py` (+21 -1) </details> ### 📄 Description These leaderboard issues have kept cropping up... but I think I've solved them. This PR fixes the following: **Randomised leaderboard on Lap 1** After the cars were reaching halfway around the first lap, the order of the leaderboard was being flipped. This has been fixed. However, the leaderboard data still shows some inaccuracies on the first lap due to how the "dist" values are recorded in the data source. There's not much we can do about that at this time, but I'm sure there's a solution out there if someone wants to try. **Drivers being moved to first position as they pass the start/finish line on a new lap** As cars cross the start finish line, sometimes the frames in the data were showing the driver to be in first position, when in reality they were not. This has been resolved by adding in a missing sorting function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>