[PR #215] [MERGED] [FIX] Redundancy in computation of time gaps #224

Closed
opened 2026-05-07 00:19:17 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/IAmTomShaw/f1-race-replay/pull/215
Author: @111110100
Created: 2/2/2026
Status: Merged
Merged: 2/5/2026
Merged by: @IAmTomShaw

Base: mainHead: timetrack02


📝 Commits (2)

  • acc2cff Removed redundant computation of gaps
  • d810450 Removed REFERENCE_SPEED_MS constant as it's not going to change

📊 Changes

2 files changed (+50 additions, -65 deletions)

View changed files

📝 src/interfaces/race_replay.py (+0 -33)
📝 src/ui_components.py (+50 -32)

📄 Description

FIX: Redundancy in the computation of time gaps

Reference

Changes

  • Removed REFERENCE_SPEED_MS as it's unlikely to change
  • Removed leader gap calculation on src/interfaces/race_replay.py
  • Moved all calculation on src/ui_components.py

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/IAmTomShaw/f1-race-replay/pull/215 **Author:** [@111110100](https://github.com/111110100) **Created:** 2/2/2026 **Status:** ✅ Merged **Merged:** 2/5/2026 **Merged by:** [@IAmTomShaw](https://github.com/IAmTomShaw) **Base:** `main` ← **Head:** `timetrack02` --- ### 📝 Commits (2) - [`acc2cff`](https://github.com/IAmTomShaw/f1-race-replay/commit/acc2cfffc7b5071e22bfd9f65790eb145bfa2fa3) Removed redundant computation of gaps - [`d810450`](https://github.com/IAmTomShaw/f1-race-replay/commit/d8104507d4389618d69df41db45793d4e6889d42) Removed REFERENCE_SPEED_MS constant as it's not going to change ### 📊 Changes **2 files changed** (+50 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `src/interfaces/race_replay.py` (+0 -33) 📝 `src/ui_components.py` (+50 -32) </details> ### 📄 Description # FIX: Redundancy in the computation of time gaps ## Reference - PR #85 - Issue #204 ## Changes - Removed REFERENCE_SPEED_MS as it's unlikely to change - Removed leader gap calculation on src/interfaces/race_replay.py - Moved all calculation on src/ui_components.py --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 00:19:17 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/f1-race-replay#224
No description provided.