[PR #21] [CLOSED] new and improved DNF and race finish leaderboard #78

New issue

Closed

opened 2026-05-07 00:18:32 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:18:32 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/IAmTomShaw/f1-race-replay/pull/21
Author: @0xgny
Created: 12/1/2025
Status: ❌ Closed

Base: improved-leaderboard ← Head: trying-api

📝 Commits (10+)

e4a40eb added flag and dnf
3603716 v1
35e756b time delta approach
799d6be final touches
64e64fb final touches
e10eeb7 changed flag location
958051b added +1 and penalties
26e8e8b cleaning up
0a7bfb3 it works now
ee3f0fe updating readme

📊 Changes

8 files changed (+1159 additions, -33 deletions)

View changed files

📝 .gitignore (+3 -1)
➕ DNF_AND_FINISH_DETECTION.md (+421 -0)
➕ LEADERBOARD_VERIFICATION.md (+196 -0)
➕ images/flags/chequered_flag.png (+0 -0)
📝 requirements.txt (+2 -1)
📝 src/arcade_replay.py (+260 -29)
📝 src/f1_data.py (+120 -2)
➕ src/leaderboard_verifier.py (+157 -0)

📄 Description

this new update corrects the flaws in my previous pr.

the checkered flag icon is not in the tyres folder anymore and has been renamed
instead of DNF for lapped drivers, they now get the checkered flag once they finish and also have the +N Lap included in the leaderboard
There is now a Penalties section that appears at the end of the race and shows what drivers had position or time penalties during the race
And finally, since i have been running into issues with translating the telemetry data into accurate leaderboard positions (especially at the end of the race), i have now added a separate API (Jolpica F1 API) to run a final check to ensure we have a correct race result. It works pretty well and it solves the main leaderboard issue i've been trying to fix all day. A good way to test it would be with the Las Vegas GP where both papaya boys got DSQ after finishing top 10.

Let me know what you think!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/IAmTomShaw/f1-race-replay/pull/21 **Author:** [@0xgny](https://github.com/0xgny) **Created:** 12/1/2025 **Status:** ❌ Closed **Base:** `improved-leaderboard` ← **Head:** `trying-api` --- ### 📝 Commits (10+) - [`e4a40eb`](https://github.com/IAmTomShaw/f1-race-replay/commit/e4a40ebeb5adbfc201d18dbc80ec5b1b4ce59c72) added flag and dnf - [`3603716`](https://github.com/IAmTomShaw/f1-race-replay/commit/3603716e3664c45c2fda7b5a5c081bff8241a9bc) v1 - [`35e756b`](https://github.com/IAmTomShaw/f1-race-replay/commit/35e756bef1bc5ae668be058c644767d50a5e6dd6) time delta approach - [`799d6be`](https://github.com/IAmTomShaw/f1-race-replay/commit/799d6bef7ca6988f197c7e9290f2a54501f40e52) final touches - [`64e64fb`](https://github.com/IAmTomShaw/f1-race-replay/commit/64e64fb4db73e3cd9210d406945d3341a72116b0) final touches - [`e10eeb7`](https://github.com/IAmTomShaw/f1-race-replay/commit/e10eeb7b8e5d4d1dc26dcf6318f7a77e53a6da61) changed flag location - [`958051b`](https://github.com/IAmTomShaw/f1-race-replay/commit/958051bad1e813d4e18c56a10fa1cf5b01cdeb6d) added +1 and penalties - [`26e8e8b`](https://github.com/IAmTomShaw/f1-race-replay/commit/26e8e8b73196087f0c9dd194089215c1f5c684ae) cleaning up - [`0a7bfb3`](https://github.com/IAmTomShaw/f1-race-replay/commit/0a7bfb3397b5bd77696a288404548e502d8d6111) it works now - [`ee3f0fe`](https://github.com/IAmTomShaw/f1-race-replay/commit/ee3f0fe0898c57ddddc44c822c2b043090fd50d9) updating readme ### 📊 Changes **8 files changed** (+1159 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -1) ➕ `DNF_AND_FINISH_DETECTION.md` (+421 -0) ➕ `LEADERBOARD_VERIFICATION.md` (+196 -0) ➕ `images/flags/chequered_flag.png` (+0 -0) 📝 `requirements.txt` (+2 -1) 📝 `src/arcade_replay.py` (+260 -29) 📝 `src/f1_data.py` (+120 -2) ➕ `src/leaderboard_verifier.py` (+157 -0) </details> ### 📄 Description this new update corrects the flaws in my previous pr. 1. the checkered flag icon is not in the tyres folder anymore and has been renamed 2. instead of `DNF` for lapped drivers, they now get the checkered flag once they finish and also have the `+N Lap` included in the leaderboard 3. There is now a Penalties section that appears at the end of the race and shows what drivers had position or time penalties during the race 4. And finally, since i have been running into issues with translating the telemetry data into accurate leaderboard positions (especially at the end of the race), i have now added a separate API (Jolpica F1 API) to run a final check to ensure we have a correct race result. It works pretty well and it solves the main leaderboard issue i've been trying to fix all day. A good way to test it would be with the Las Vegas GP where both papaya boys got DSQ after finishing top 10. Let me know what you think! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>