[GH-ISSUE #1493] If we dont build with github action, app can easily crash #1054

New issue

Closed

opened 2026-05-07 00:29:54 +02:00 by BreizhHardware · 1 comment

BreizhHardware commented

2026-05-07 00:29:54 +02:00

Owner

Originally created by @cyrinux on GitHub (Nov 20, 2025).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/1493

Hi,
In case for whatever reason we rebuild in piggy way, the code is weak in the main.go for the commit sha reading that can easily lead to overflow and crash.
The culprit is the commit[:7], in my case the main issue was my git version which crash, goreleaser continue and so set the commit and tags to "none". Thus at start the app try to do "none"[:7] and crash.
Can we make the code more robust with something like:

commitShort := commit
if len(commit) > 7 {
    commitShort = commit[:7]
}
...

Originally created by @cyrinux on GitHub (Nov 20, 2025). Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/1493 Hi, In case for whatever reason we rebuild in piggy way, the code is weak in the main.go for the commit sha reading that can easily lead to overflow and crash. The culprit is the `commit[:7]`, in my case the main issue was my git version which crash, goreleaser continue and so set the commit and tags to "none". Thus at start the app try to do `"none"[:7]` and crash. Can we make the code more robust with something like: ``` commitShort := commit if len(commit) > 7 { commitShort = commit[:7] } ... ```

BreizhHardware

2026-05-07 00:29:54 +02:00

closed this issue
added the
🪲 bug

server
labels

BreizhHardware commented

2026-05-07 00:29:55 +02:00

Author

Owner

@binwiederhier commented on GitHub (Feb 4, 2026):

This was fixed as part of github.com/binwiederhier/ntfy@856f150958

@binwiederhier commented on GitHub (Feb 4, 2026): This was fixed as part of https://github.com/binwiederhier/ntfy/commit/856f15095846c0f06275e019b8545276658e2968