[PR #451] [MERGED] Remove buffering from nginx config, make config secure by default #1305

Closed
opened 2026-05-07 01:01:28 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/451
Author: @SuperSandro2000
Created: 10/23/2022
Status: Merged
Merged: 11/2/2022
Merged by: @binwiederhier

Base: mainHead: patch-1


📝 Commits (1)

  • 2d39ae1 Remove buffering from nginx config, make config secure by default

📊 Changes

1 file changed (+6 additions, -25 deletions)

View changed files

📝 docs/config.md (+6 -25)

📄 Description

Turning off proxy buffering is not recommend by upstream https://www.nginx.com/blog/avoiding-top-10-nginx-configuration-mistakes/#proxy_buffering-off by default. And making configuration more secure by removing TLSv1 TLSv1.1 and redirecting to https all the time to never leak credentials.

PS: https is not annoying and curl can follow redirects with -L.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/451 **Author:** [@SuperSandro2000](https://github.com/SuperSandro2000) **Created:** 10/23/2022 **Status:** ✅ Merged **Merged:** 11/2/2022 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`2d39ae1`](https://github.com/binwiederhier/ntfy/commit/2d39ae1d1a96b8a70e2bb45be5d859ed5fffba79) Remove buffering from nginx config, make config secure by default ### 📊 Changes **1 file changed** (+6 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+6 -25) </details> ### 📄 Description Turning off proxy buffering is not recommend by upstream https://www.nginx.com/blog/avoiding-top-10-nginx-configuration-mistakes/#proxy_buffering-off by default. And making configuration more secure by removing TLSv1 TLSv1.1 and redirecting to https all the time to never leak credentials. PS: https is not annoying and curl can follow redirects with -L. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-07 01:01:28 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ntfy#1305
No description provided.