[PR #665] [CLOSED] Allow newer python when building docs #1373

New issue

Closed

opened 2026-05-07 01:01:48 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:01:48 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/665
Author: @cyqsimon
Created: 3/8/2023
Status: ❌ Closed

Base: main ← Head: allow-newer-python

📝 Commits (4)

8d80de5 Add python version search script
f959795 Update Makefile to use script
d44570b Script returns full binary name
008ff70 Improve python binary selection logic

📊 Changes

2 files changed (+53 additions, -15 deletions)

View changed files

📝 Makefile (+7 -15)
➕ tools/get-python-bin.sh (+46 -0)

📄 Description

Previously in Makefile, there are provisions to use python3.8 if python3 is not new enough. However it doesn't check for versions newer than 3.8, which could be problematic if the user has python3.6 and python3.9, but python3 points to python3.6. This is a frequent occurrence on RHEL systems.

This change also makes sure that the version of pip called matches the version of python used. Now I'm not that familiar with Python, so I cannot say for certain whether this is strictly necessary. But I cannot imagine there to be any downsides with doing this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/665 **Author:** [@cyqsimon](https://github.com/cyqsimon) **Created:** 3/8/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `allow-newer-python` --- ### 📝 Commits (4) - [`8d80de5`](https://github.com/binwiederhier/ntfy/commit/8d80de598a970381281ee5aa596336d1a9f0a24e) Add python version search script - [`f959795`](https://github.com/binwiederhier/ntfy/commit/f95979586d489be6bb538dd89c1b1f21c1a3a204) Update Makefile to use script - [`d44570b`](https://github.com/binwiederhier/ntfy/commit/d44570b557cc2bc8367f4f8727187b858c98916c) Script returns full binary name - [`008ff70`](https://github.com/binwiederhier/ntfy/commit/008ff709c820e50cb45c85ab7da52f665b819484) Improve python binary selection logic ### 📊 Changes **2 files changed** (+53 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+7 -15) ➕ `tools/get-python-bin.sh` (+46 -0) </details> ### 📄 Description Previously in `Makefile`, there are provisions to use `python3.8` if `python3` is not new enough. However it doesn't check for versions newer than 3.8, which could be problematic if the user has `python3.6` and `python3.9`, but `python3` points to `python3.6`. This is a frequent occurrence on RHEL systems. This change also makes sure that the version of `pip` called matches the version of `python` used. Now I'm not that familiar with Python, so I cannot say for certain whether this is strictly necessary. But I cannot imagine there to be any downsides with doing this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>