mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 16:35:53 +02:00
[GH-ISSUE #168] SWAG reverse proxy config push request. #138
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#138
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sudo-kraken on GitHub (Mar 14, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/168
This guide assumes you are using a working SWAG setup from Linux Server IO and want to add the Nfty service to your domain for external access. Below is the conf file that I use, if should be placed in your mount point of /config/nginx/proxy-confs and named nfty.subdomain.conf so that swag picks it up, the name is irrelevant but it must be in this folder with the .conf file extension.
This will run Ntfy on a subdomain called Ntfy, in the case below you need to update the IP address of the Nfty server for this example I have chosen the IP 10.0.10.10 and the port that http is bound on to 1111.
Let me know if you need any more info for the documentation.
@binwiederhier commented on GitHub (Mar 16, 2022):
Looks like SWAG is just like nginx. I don't see any additional parameters that's not already in the docs. Thank you for providing these!
@SuperSandro2000 commented on GitHub (Oct 19, 2022):
Why is proxy_buffering and proxy_request_buffering disabled? According to 10 common nginx mistakes proxy_buffering should not be disabled.
@binwiederhier commented on GitHub (Oct 19, 2022):
Because if you upload a larger file slowly the backend will time out. Iirc
@SuperSandro2000 commented on GitHub (Oct 19, 2022):
Please take a look at https://www.nginx.com/blog/avoiding-top-10-nginx-configuration-mistakes/#proxy_buffering-off . I think we should rather increase the timeout for uploads or rework them to send 100s between rather than disabling this option.
@binwiederhier commented on GitHub (Oct 21, 2022):
ntfy does not ship with an nginx config; it merely suggests one in the docs. I am happy to accept PRs against the docs if this is important to you. However, I do recall reasons for why buffering was disabled in the first place, and we'd have to do testing with the other settings. All I can say is it works.
That said, I do think a proxy should be a passthrough, and not smart like that. Buffering is certainly unexpected from a user perspective IMHO.